From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2A45C433E5 for ; Thu, 16 Jul 2020 05:13:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD44D207BB for ; Thu, 16 Jul 2020 05:13:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Q5lR3J0x"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="FFfk/Mgq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD44D207BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7jnZECBXgr2r3E5qHbNBT7LLn9fZ3swTI8JdFGIiyrY=; b=Q5lR3J0xm+W5GsH6rQs4wYXj1 zFz1Ouc6w28/L1J92k+pD29vLNhUWTh4slxbspCrAQMoXs2K3O4Ac20bAPmV+0xKIie1GuWtOXJTR mIfZ+LXyf4TJE3QzYWzcmZljVWNTMbKlWlo6uJbAKy4De8CEwpXHHX/umrx1wzlh2EYtq/wl25S9d NnVOt9cZG92kPIUM/uUExLQa93bU/pTwhiGvjveS51rN6U/535TCvFU48hRYbj9YDCPQVy/OdMv2g Jx8OQ5SfHapWeeAoU8i5GEY4DBO5f8RZN5SleKJftrA2uPEhrdKLa02ArU9tu8/wSo1iWoxyLEajI usssB7Lzw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvwB4-0005Ox-4P; Thu, 16 Jul 2020 05:11:26 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvwB1-0005OM-JO for linux-arm-kernel@lists.infradead.org; Thu, 16 Jul 2020 05:11:24 +0000 Received: from localhost (unknown [122.171.202.192]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A226F207BC; Thu, 16 Jul 2020 05:11:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594876282; bh=fVIx7exM1IL4il1EvPnQv2j2V1fBwT20/XpSLo7h7UA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FFfk/MgqkxjA56TqPGaFqo3E5C+UKWoOOglSrFeYYnF/KgHxASQLgFomcd5uiZvRb KnNUejif5jQf0QE3YNyKokUBewlqLrdf4a21iJIb4jysDeBRgzJAEwe0TvHtfyjslP 1+XQ67ae0Mr7Gra1wG7mGb56g1/D8m4H820f5Yko= Date: Thu, 16 Jul 2020 10:41:18 +0530 From: Vinod Koul To: Alim Akhtar Subject: Re: [PATCH v12 2/2] phy: samsung-ufs: add UFS PHY driver for samsung SoC Message-ID: <20200716051118.GB55478@vkoul-mobl> References: <20200703171135.77389-1-alim.akhtar@samsung.com> <20200703171135.77389-2-alim.akhtar@samsung.com> <20200713061737.GD34333@vkoul-mobl> <077501d65b0e$e1630100$a4290300$@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <077501d65b0e$e1630100$a4290300$@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200716_011124_112001_1CB13EA7 X-CRM114-Status: GOOD ( 12.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, krzk@kernel.org, kwmad.kim@samsung.com, robh+dt@kernel.org, kishon@ti.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alim, On 16-07-20, 06:47, Alim Akhtar wrote: > > > +static int samsung_ufs_phy_symbol_clk_init(struct samsung_ufs_phy > > > +*phy) { > > > + int ret = 0; > > > > superfluous init, am sure I flagged it before as well > > > Yes, you did, but 0-DAY CI kernel test gave warning [1], so I kept this as > it is. > [1] https://lkml.org/lkml/2020/7/3/81 But you moved away from return below to goto, so that is no longer the case. First use of ret is for clk_prepare_enable() call below which is not conditional hence this is superfluous. Earlier it was not as it was conditional so required to be initialized > > > > + > > > + phy->tx0_symbol_clk = devm_clk_get(phy->dev, "tx0_symbol_clk"); > > > + if (IS_ERR(phy->tx0_symbol_clk)) { > > > + dev_err(phy->dev, "failed to get tx0_symbol_clk clock\n"); > > > + goto out; > > > + } > > > + > > > + phy->rx0_symbol_clk = devm_clk_get(phy->dev, "rx0_symbol_clk"); > > > + if (IS_ERR(phy->rx0_symbol_clk)) { > > > + dev_err(phy->dev, "failed to get rx0_symbol_clk clock\n"); > > > + goto out; > > > + } > > > + > > > + phy->rx1_symbol_clk = devm_clk_get(phy->dev, "rx1_symbol_clk"); > > > + if (IS_ERR(phy->rx0_symbol_clk)) { > > > + dev_err(phy->dev, "failed to get rx1_symbol_clk clock\n"); > > > + goto out; > > > + } > > > + > > > + ret = clk_prepare_enable(phy->tx0_symbol_clk); > > > + if (ret) { > > > + dev_err(phy->dev, "%s: tx0_symbol_clk enable failed %d\n", > > __func__, ret); > > > + goto out; > > > + } -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel