From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9C5DC433E2 for ; Thu, 16 Jul 2020 06:30:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 747172067D for ; Thu, 16 Jul 2020 06:30:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qaVDbA/x"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="I/bm0yRR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 747172067D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cFGRDhqJ9BhNL3zM2t+stQtVMDxeTtiPGZ9ht7QjZL0=; b=qaVDbA/xrZT0wm7TWZml2sVvW 6YL+SXpOXSIX6y74aWJE00dn9jz1MxW7fxYxQC//REC8FeBOG7snIywaki5lNN1/DbZCxNFwAP+A0 2HfyKmCSB/KwTSQteFAhymNQXtJOCsD0epe6eOJGlO//FnaKVi35RRRVnztoZaqAljr4XX81Zmm8Q ZB8nX4eWwqEpKnZfl1wwEZ/7Jnfad8lEye9xbhx+wZYO3yjJU+7ikQYc2EvRqYbFpO46R4U94Vb/Q fGnGggyPCNWnIotqIT3tyvCo7Cz5BN7N2N2+xg+SCFZRQ9PMDqkOHkckmmvoJBseFgwFG0BzmlR+j kCJvCG/iA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvxOr-0007fd-5B; Thu, 16 Jul 2020 06:29:45 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvxOo-0007eZ-KO for linux-arm-kernel@lists.infradead.org; Thu, 16 Jul 2020 06:29:43 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4093B2067D; Thu, 16 Jul 2020 06:29:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594880981; bh=iATruulsL90Sg1KydgMR1kTilJXahpTdK2f3qjPAm5s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I/bm0yRRjEIZ7clDi+UquLgaByP6yK9ICz5nR9Mo3mweyKXxMVcOddeSmThEh+9P1 yBtDXQXLDr3ulxg87IXrDIOOu9GIuS6rIuyAQV302PwgRVrLQe6rVLvBMgTqEpreC+ g1BAkmKGRjFmUWS7AU5ptJ6ABJqqOi41H8q478Hs= Date: Thu, 16 Jul 2020 08:29:36 +0200 From: Greg Kroah-Hartman To: Bhanu Prakash Maiya Subject: Re: [PATCH v3 1/2] platform/chrome: cros_ec_uart: Add cros-ec-uart transport layer Message-ID: <20200716062936.GB958325@kroah.com> References: <20200715221150.v3.1.I7605646b16c98c0095eee7fbe39f8f7b2b59e6f4@changeid> <20200716062807.GA958325@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200716062807.GA958325@kroah.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200716_022942_760600_A43E124C X-CRM114-Status: GOOD ( 13.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Mauro Carvalho Chehab , Duncan Laurie , devicetree@vger.kernel.org, Furquan Shaikh , Benson Leung , linux-kernel@vger.kernel.org, "David S . Miller" , Raul E Rangel , Enric Balletbo i Serra , Guenter Roeck , Lee Jones , Eric Peers , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 16, 2020 at 08:28:07AM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 15, 2020 at 10:14:29PM -0700, Bhanu Prakash Maiya wrote: > > From: Bhanu Prakash Maiya > > > > This patch enables uart transport layer for cros_ec framework. > > The cros-ec-uart binds with EC device working on uart transport to > > send request and receive response. > > > > Signed-off-by: Bhanu Prakash Maiya > > If this really is a "UART", why is this not a serial/tty driver? Ah, it's a serdev driver. that wasn't obvious. Please write a much better changelog saying what this driver is and why it needs to be the type that it is, as I totally missed that from these 2 sentences. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel