From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D825C433E3 for ; Thu, 16 Jul 2020 07:02:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3ECEC206F4 for ; Thu, 16 Jul 2020 07:02:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nidiBCpq"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="U46Azy+K" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3ECEC206F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HLgpV7REL4bfAluH5umTCl+ZFXxiwd18gzUcZoPjOdI=; b=nidiBCpqWgt+12QFetQ6HdJBB J6GHRrdud7odJJ5+fsO7a0MVi026OPM73kSKWmzovym0EHVK/6+bHnLbtgiAYbg8znRoPqWGjO5fJ AuIoOIh0XRT+t84BE1ZV3GXIF+5EvGRVGEbfPAe5hj1daxJMNqwbgMxqkhrU9eEwICocY7k0D+yzm ECbhJMq5CbpyilGU41rpMJrbstgBqI5wBTw/6ucoEt6kWyWPDsrVhsV6KeN9k7XpCKBXy5qCKRbtI yXFIdGdxnHHJye2lH8PcSEVqdi29pk0UIeH5BspC4SkOXZwz1EhEVXU07LyhzMIgOqFoTEaMUtZry XBfVbYZWw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvxsk-0002kD-13; Thu, 16 Jul 2020 07:00:38 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvxsh-0002jN-OW for linux-arm-kernel@lists.infradead.org; Thu, 16 Jul 2020 07:00:36 +0000 Received: from Mani-XPS-13-9360 (unknown [157.50.199.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EE6DC2064C; Thu, 16 Jul 2020 07:00:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594882833; bh=Qct6MZ1QaNERKb7aX6s5WHVRW6dIsCv2vuonJPxJwfk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U46Azy+KKOewokELUn/94s4XOAIPTR23B1XiYwcSU/SqGgvTviw/VrHQv4h4JAwxI wjE6GyCvV6HKwjzn5dKgNnCkbJzbhtwsy3ltt/SLMdTQfMi1u9QGm29qLwlNnbCDmD xXPwaj0ZHWxvERqvk5uXNHDsvxDfP2xDGK098dA0= Date: Thu, 16 Jul 2020 12:30:25 +0530 From: Manivannan Sadhasivam To: Patrick Delaunay Subject: Re: [PATCH] ARM: dts: stm32: Correct spi4 pins in stm32mp15-pinctrl.dtsi Message-ID: <20200716070025.GF3271@Mani-XPS-13-9360> References: <20200708114324.7309-1-patrick.delaunay@st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200708114324.7309-1-patrick.delaunay@st.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200716_030035_884030_15809CD9 X-CRM114-Status: GOOD ( 14.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Alexandre Torgue , linux-kernel@vger.kernel.org, Rob Herring , Maxime Coquelin , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 08, 2020 at 01:43:24PM +0200, Patrick Delaunay wrote: > Move spi4_pins_a nodes from pinctrl_z to pinctrl > as the associated pins are not in BANK Z. > Yikes, that's a nasty misplacement! Thanks for fixing. > Fixes: 498a7014989dfdd9a47864b55704dc829ed0dc90 Fixes tag should be of below: Fixes: 498a7014989d ("ARM: dts: stm32: Add missing pinctrl entries for STM32MP15") > Signed-off-by: Patrick Delaunay Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > > arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 28 ++++++++++++------------ > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi > index 7eb858732d6d..6aedbd7077ff 100644 > --- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi > +++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi > @@ -1574,6 +1574,20 @@ > }; > }; > > + spi4_pins_a: spi4-0 { > + pins { > + pinmux = , /* SPI4_SCK */ > + ; /* SPI4_MOSI */ > + bias-disable; > + drive-push-pull; > + slew-rate = <1>; > + }; > + pins2 { > + pinmux = ; /* SPI4_MISO */ > + bias-disable; > + }; > + }; > + > usart2_pins_a: usart2-0 { > pins1 { > pinmux = , /* USART2_TX */ > @@ -1776,18 +1790,4 @@ > bias-disable; > }; > }; > - > - spi4_pins_a: spi4-0 { > - pins { > - pinmux = , /* SPI4_SCK */ > - ; /* SPI4_MOSI */ > - bias-disable; > - drive-push-pull; > - slew-rate = <1>; > - }; > - pins2 { > - pinmux = ; /* SPI4_MISO */ > - bias-disable; > - }; > - }; > }; > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel