From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70F79C433E1 for ; Thu, 16 Jul 2020 08:06:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39D2E20657 for ; Thu, 16 Jul 2020 08:06:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Eyr9RS4K"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="aiQTn2fN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="tZhlqkLu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39D2E20657 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=G/S5Jx+dSuq/fE8VnuyuB3R27kG+OM1Oeyy5cd0fJiE=; b=Eyr9RS4K/bPUhqbKeiR3jie4d Ba/aoxzueSzRoH3o7zHIMUezfTqnMahH18Uu0ijmKLUcv1LnD8jSFdD2cDOUXl80c5tFR/puQNztD CpxrD95peNY86cnNh/iHXxgVP12w+CisV9ELaYazoJ4j+5BDDnw3zigII3FhU90oLCcwZKxnbxueu 7TThFNFHfkli8BNmUjrxoUrXfWPXmD/4hNPFj7ThhrR4htxe1H5NMjQxdlj9NAKIgN0W6dPyrWSeO ZIkcjks34x4x+lA1UAKUWUIqZ2xWvMWwjm9VedO2NsIZrjf+HtwgzC9nEzydk3EN4pgvgm936tir7 2yKjBualA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvysk-0002PO-3g; Thu, 16 Jul 2020 08:04:42 +0000 Received: from new4-smtp.messagingengine.com ([66.111.4.230]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvysh-0002Oj-Gv for linux-arm-kernel@lists.infradead.org; Thu, 16 Jul 2020 08:04:40 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 19279580398; Thu, 16 Jul 2020 04:04:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 16 Jul 2020 04:04:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=6FRaGsNVf4Oj7I0udxEaM7YNj9M cwIA3wCwlWWtmTOA=; b=aiQTn2fNb8TfhHxIIwch/tNLmkKDW4oYncGU+pC15hf /CZeH6c3bGetKEm41U4n8RKpyxul0jnz3DcIhJCaNtO8C7um3iir043+vQi3YDtn p3KSDXE9WMLXo1L+xBuYSxEoXBm+TPz12CrX20keiALJNnflBZ4hv/vifGIxqcaw x3BMYik95WMw2c5yOLzg0mPtUiADeD+MVVm89pXz5wezeqnkf88VVH+VrjBzYKek nhqXGlnbJ43bE5yi+PXw88WwQZ6Jpje55m8zttJyNctSZk6cpm1leb91dVkN6S6g YfYNloTKbatEwy3w/hrodWYfxea352+YqjVkKRHZ2lg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=6FRaGs NVf4Oj7I0udxEaM7YNj9McwIA3wCwlWWtmTOA=; b=tZhlqkLu9ORCerc8ehZCwX xqkBavvP+D7IPmyj9NbSY1OMEqNh7MuwFvvT6g7a/oZ5w0aXT0vEwuVdm18cGkl3 NdAtelCFZae9WYPjBgfQFfmeZdV6B+dWqTB7wabg5Pj4rWlCaqzo5q0p1iYsPF2D sUgue23P19QSpR/2ns5cHUPFqwXmvaigz3hiDEPoQ4mzKBQ1Vnxhzs9ZhbTx8Pz7 rTavUGbTeTgKpR0x0y9CLospD3047VfBOMi0dwr+X4olIKxxVztjZzcAiITJ8rD1 yZv/sMIdQX4Q41zsr9F2NZSagWPLjyWX+5GC04NxWXcQDy1MWjtRa/ZfOkQVGIPw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrfeefgdduvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgepudenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 3B8E0306005F; Thu, 16 Jul 2020 04:04:37 -0400 (EDT) Date: Thu, 16 Jul 2020 10:04:35 +0200 From: Maxime Ripard To: Chen-Yu Tsai Subject: Re: [PATCH 5/5] ARM: dts: sun7i: Add MSI Primo73 tablet Message-ID: <20200716080435.3td5il4eskh5jcru@gilmour.lan> References: <20200714071305.18492-1-wens@kernel.org> <20200714071305.18492-6-wens@kernel.org> MIME-Version: 1.0 In-Reply-To: <20200714071305.18492-6-wens@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200716_040439_619061_96B36F88 X-CRM114-Status: GOOD ( 29.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Siarhei Siamashka , David Airlie , Rob Herring , Chen-Yu Tsai , Thierry Reding , dri-devel@lists.freedesktop.org, Daniel Vetter , Sam Ravnborg , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============8999836706817942450==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8999836706817942450== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dnhfbvytdbc524k4" Content-Disposition: inline --dnhfbvytdbc524k4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Jul 14, 2020 at 03:13:05PM +0800, Chen-Yu Tsai wrote: > From: Chen-Yu Tsai >=20 > The Primo73 is an MSI branded Allwinner A20-based 7-inch tablet. It has > a metal back case with a plastic insert around where the WiFi antenna is. > The tablet is (as of July of 2020) no longer available from retailers. > Kernel sources (as required by GPL) are no longer available from the > vendor, MSI. The device support page still lists the link, but it is > dead. >=20 > The tablet features a non-identifiable 1024x600 7" MIPI DPI TFT panel, > Goodix GT911-based capacitive touchscreen, 1GB DRAM, 8GB MLC NAND, > RTL8188ETV-based WiFi, an NXP MMA8452 accelerometer for orientation, > a GC2035 2 megapixel rear camera, a GC0308 0.3 megapixel front camera, > a mini-HDMI output, a micro-USB port, a headphone jack and single speaker. >=20 > The board design is believe to follow Allwinner's reference design. This > judgement is based on the fact that the I/O pins and GPIO lines used > match up with the reference design. Assumptions about the regulator tree > are based on this. >=20 > The LCD panel only has some serial number markings, and what appears to > be a part number: "OS1N71J003", which is also a prefix for one of the > serial number markings. Searching for this part number yielded no > results. As such, the color depth display timings are directly listed > in the device tree. The timing are from the FEX file recovered from the > device. The color depth was derived from the dithering setting from the > FEX file, as well as independent testing with a color gradient image. > The internal board, as well as the ribbon cable for the panel, route the > full 24 bits of color. So the 2 extra bits are dropped either by the > panel itself or somewhere within the LCD panel module casing. >=20 > Add a device tree for this tablet. Almost the whole device is supported. > The only things missing are the two cameras, which don't have device > tree bindings or driver support. The vendor for the LCD panel is left > out, since there is nothing to go with. >=20 > Signed-off-by: Chen-Yu Tsai > --- >=20 > The panel-dpi binding requires a more-specific compatible string. > However given the vendor of the panel is unknown, I'm not sure what > the best course of action is here. I opted to put the part number in > without a vendor prefix. I guess we could just make up a comptible from the tablet name here? Something like msi,primo73-panel ? > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/sun7i-a20-primo73.dts | 279 ++++++++++++++++++++++++ > 2 files changed, 280 insertions(+) > create mode 100644 arch/arm/boot/dts/sun7i-a20-primo73.dts >=20 > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index e6a1cac0bfc7..c09cda958db5 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -1133,6 +1133,7 @@ dtb-$(CONFIG_MACH_SUN7I) +=3D \ > sun7i-a20-orangepi-mini.dtb \ > sun7i-a20-pcduino3.dtb \ > sun7i-a20-pcduino3-nano.dtb \ > + sun7i-a20-primo73.dtb \ > sun7i-a20-wexler-tab7200.dtb \ > sun7i-a20-wits-pro-a20-dkt.dtb > dtb-$(CONFIG_MACH_SUN8I) +=3D \ > diff --git a/arch/arm/boot/dts/sun7i-a20-primo73.dts b/arch/arm/boot/dts/= sun7i-a20-primo73.dts > new file mode 100644 > index 000000000000..f3b1002ceb50 > --- /dev/null > +++ b/arch/arm/boot/dts/sun7i-a20-primo73.dts > @@ -0,0 +1,279 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (C) 2020 Chen-Yu Tsai > + */ > + > +/dts-v1/; > +#include "sun7i-a20.dtsi" > +#include "sunxi-common-regulators.dtsi" > + > +#include > +#include > +#include > +#include > + > +/{ > + model =3D "MSI Primo73 Tablet"; > + compatible =3D "msi,primo73", "allwinner,sun7i-a20"; > + > + aliases { > + serial0 =3D &uart0; > + }; > + > + backlight: backlight { > + compatible =3D "pwm-backlight"; > + pwms =3D <&pwm 0 50000 PWM_POLARITY_INVERTED>; > + enable-gpios =3D <&pio 7 7 GPIO_ACTIVE_HIGH>; /* PH7 */ > + }; > + > + chosen { > + stdout-path =3D "serial0:115200n8"; > + }; > + > + hdmi-connector { > + compatible =3D "hdmi-connector"; > + type =3D "b"; > + > + port { > + hdmi_con_in: endpoint { > + remote-endpoint =3D <&hdmi_out_con>; > + }; > + }; > + }; > + > + panel: panel { > + compatible =3D "os1n71j003", "panel-dpi"; > + backlight =3D <&backlight>; > + power-supply =3D <®_vcc5v0>; /* Actually driven from IPSOUT */ > + enable-gpios =3D <&pio 7 8 GPIO_ACTIVE_HIGH>; /* PH8 */ > + height-mm =3D <86>; > + width-mm =3D <155>; > + bits-per-color =3D <6>; > + > + panel-timing { > + clock-frequency =3D <60000000>; > + hactive =3D <1024>; > + vactive =3D <600>; > + hfront-porch =3D <160>; > + hback-porch =3D <60>; > + hsync-len =3D <100>; > + vback-porch =3D <13>; > + vfront-porch =3D <10>; > + vsync-len =3D <10>; > + de-active =3D <1>; > + pixelclk-active =3D <0>; > + }; The clock frequency doesn't seem to match the rest of the timings though, it should be around 51MHz. Was this taken from the fex file too? Maxime --dnhfbvytdbc524k4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXxAKEwAKCRDj7w1vZxhR xVq3AQDecTAKa3nVz2cO7syghzWkCakk/sBcrbXaSGlzYa1/tAEArIg4KfsWe5vV 6ITtzFf1KFzrrjCWsO8WMMgvfHe/QwU= =NrX2 -----END PGP SIGNATURE----- --dnhfbvytdbc524k4-- --===============8999836706817942450== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8999836706817942450==--