From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77993C433E3 for ; Thu, 16 Jul 2020 08:52:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 42DD82074B for ; Thu, 16 Jul 2020 08:52:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="smhWtHMp"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="lZz7/S2v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42DD82074B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=W7pglf6W/gZrJkM9kVnjxy5r6TX5iMtT4Ee7Fmi4Vxo=; b=smhWtHMp84h5ryWOViWW1VqEh8 gsXgom/z3sd8OsCa0lZUZuhPwkVOHCQrPSnMvHgoMM/HqvBLPRMfxEm0yZJeqXOAiEEHC2yGsOROM AHRQlBKvuRRM5V9cHSX8ctNiy65zo28YumjF7tsARJa8ij4DdHW4gD8VioBH7crVM86Dser4Ee0K9 DrLYJeD+wYVUYB2fWZ5+lKWIju8OL7fLMzOhwbCT1+erGCasJp3oS03MrJEfRcn7SX+1pBY5j7F25 HccAqf+1XskYW1m9T2sIQxeJDe7meCg0ivuGZB6h/TthTWX7Gm+xwreaTjQwdu2WaiK8TmlKYOsMO MzLQin2g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvzba-0001Y4-0B; Thu, 16 Jul 2020 08:51:02 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvzbX-0001XN-0C for linux-arm-kernel@lists.infradead.org; Thu, 16 Jul 2020 08:50:59 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C7ABE2067D; Thu, 16 Jul 2020 08:50:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594889458; bh=U7X430J5V6ePsxTX3punZtP6BZO/DUniM8aSGD0rCbE=; h=Date:From:To:Subject:References:In-Reply-To:From; b=lZz7/S2vinkg3caYNt3YEW0+aHk66D0ubE/cVS+1d1BJj1TOMJLdy0VXqxtqvmFif cDATDWQ5495bMsQhe9jCZDMOaj8c/C54/Gzxzj3D8BOc5ai8vt33x1Nk/IMcu71aBm 4fkAgq1cHMXKB9HNNTG5q2laTa6Mvod6Foqi0R5M= Date: Thu, 16 Jul 2020 09:50:53 +0100 From: Will Deacon To: Sai Prakash Ranjan , linux-arm-msm@vger.kernel.org, Joerg Roedel , Robin Murphy , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, John Stultz , freedreno@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: Re: [Freedreno] [PATCH v9 4/7] iommu/arm-smmu: Add a pointer to the attached device to smmu_domain Message-ID: <20200716085053.GB6771@willie-the-truck> References: <20200626200042.13713-1-jcrouse@codeaurora.org> <20200626200042.13713-5-jcrouse@codeaurora.org> <20200713150901.GA3072@willie-the-truck> <20200713171917.GA3815@jcrouse1-lnx.qualcomm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200713171917.GA3815@jcrouse1-lnx.qualcomm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200716_045059_137040_2293A0D0 X-CRM114-Status: GOOD ( 18.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 13, 2020 at 11:19:17AM -0600, Jordan Crouse wrote: > On Mon, Jul 13, 2020 at 04:09:02PM +0100, Will Deacon wrote: > > On Fri, Jun 26, 2020 at 02:00:38PM -0600, Jordan Crouse wrote: > > > diff --git a/drivers/iommu/arm-smmu.h b/drivers/iommu/arm-smmu.h > > > index 5f2de20e883b..d33cfe26b2f5 100644 > > > --- a/drivers/iommu/arm-smmu.h > > > +++ b/drivers/iommu/arm-smmu.h > > > @@ -345,6 +345,7 @@ struct arm_smmu_domain { > > > struct mutex init_mutex; /* Protects smmu pointer */ > > > spinlock_t cb_lock; /* Serialises ATS1* ops and TLB syncs */ > > > struct iommu_domain domain; > > > + struct device *dev; /* Device attached to this domain */ > > > > This really doesn't feel right to me -- you can generally have multiple > > devices attached to a domain and they can come and go without the domain > > being destroyed. Perhaps you could instead identify the GPU during > > cfg_probe() and squirrel that information away somewhere? > > I need some help here. The SMMU device (qcom,adreno-smmu) will have at least two > stream ids from two different platform devices (GPU and GMU) and I need to > configure split-pagetable and stall/terminate differently on the two domains. Hmm. How does the GPU driver know which context bank is assigned to the GPU and which one is assigned to the GMU? I assume it needs this information so that it can play its nasty tricks with the TTBR registers? I ask because if we need to guarantee stability of the context-bank assignment, then you could match on that in the ->init_context() callback, but now I worry that it currently works by luck :/ Do we need to add an extra callback to allocate the context bank? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel