From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B94F9C433DF for ; Thu, 16 Jul 2020 23:07:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 626B62100A for ; Thu, 16 Jul 2020 23:07:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rHE9ZOdX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 626B62100A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Q9vcQ7YKLb1DLU5AjwFb3VTvIt1iGNzjRiUUd9F0Dl4=; b=rHE9ZOdXcIz28PdLOuniBZyLf lxkvHwcAbYsB8KNovGLbTl2ZfcsRTpKuWUy9GGVJYgabde+VUMvr9MJLUfYoLNBsc5ywWOWr1/wrM qolZVqulTDVsNAOKScFReVEzmkHQUFbzh1wEAZIcBexXHLi8KrCiATPB2Lo9pceaIKzEVAqkxTI5H 89Oe1bd/EE8FN2t5vlI3eIoI9vzi0hQ66RliJmpz7gHKp1JH2HagmdSQYnolHhBorVtodUnICWaJQ PLXngdnpsUzGqSVcRTD1vtZ5ihApbY2qLo0sEprLSmvZlSjGlFrh3ZV1pb7A3X1eCMkvsZjjg8GvN Ap/ncc5IA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwCvx-0004MU-W1; Thu, 16 Jul 2020 23:04:58 +0000 Received: from mail-io1-f66.google.com ([209.85.166.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwCvv-0004Lz-0R for linux-arm-kernel@lists.infradead.org; Thu, 16 Jul 2020 23:04:56 +0000 Received: by mail-io1-f66.google.com with SMTP id a12so8070906ion.13 for ; Thu, 16 Jul 2020 16:04:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eDT8ZBhNeJbznzfPJdQt1GGooj/iP+F7BcxCoXIsS98=; b=WCbgphB3w0eiAqS7sezcA8nDHzRZV6BqISYM5A+TkV+rdZeEI6EvM9D9Q9lTw3CKzh wuR2l4y/HxZytNjMuFJKJXA9T/Zu8Xvbn1ywgPFxKXcMc2wn6PYiQpdYbjf2QjNjAuMM ejXln4tUgk7RLVghS6m/1lRTL2IOuvVcu8PwD7W4Zi5xjlttSX4rlp1yf9+vtzDnLEwA iiNl+4K8Af4u19HUwCZ8SVwcVIwtMkDo6sG5R2AyuBp6p/YTqso3WMCMqgUokl7YMVzk RwHR3cbvmsHh22WG6Hs+1Y0UKJ2i+z66PFM2FwrpsXh56ieJgv71rZezhsdBacq5KWK8 zCdg== X-Gm-Message-State: AOAM531Dt2yAUTEL8QPlJ5DyssN10VJyd5f0/LrJ3pUQ0u6XmLJODTW7 IdsaLlLQKa+pun/BjuNACw== X-Google-Smtp-Source: ABdhPJxtvwZsJGPyF4/aHmjE6iE0550P7hSG08wHNUdd2IYc9L30ABvSfVU3gTVaBW7qJaETeEmXVA== X-Received: by 2002:a05:6638:223:: with SMTP id f3mr7706474jaq.144.1594940693894; Thu, 16 Jul 2020 16:04:53 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id q2sm3358270ilp.82.2020.07.16.16.04.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 16:04:53 -0700 (PDT) Received: (nullmailer pid 3053333 invoked by uid 1000); Thu, 16 Jul 2020 23:04:51 -0000 Date: Thu, 16 Jul 2020 17:04:51 -0600 From: Rob Herring To: Masahiro Yamada Subject: Re: [PATCH] dt-bindings: uniphier-thermal: add minItems to socionext,tmod-calibration Message-ID: <20200716230451.GA3041278@bogus> References: <20200707102338.989660-1-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200707102338.989660-1-yamada.masahiro@socionext.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200716_190455_088756_23936CDD X-CRM114-Status: GOOD ( 19.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Amit Kucheria , Kunihiko Hayashi , linux-pm@vger.kernel.org, Daniel Lezcano , linux-kernel@vger.kernel.org, Zhang Rui , Frank Rowand , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 07, 2020 at 07:23:38PM +0900, Masahiro Yamada wrote: > As the description says, this property contains a pair of calibration > values. The number of items must be exactly 2. > > Add minItems to check a too short property. > > While I was here, I also added this property to the example because > this is the case in the real DT file, > arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi > > Also, fix the interrupt type (edge -> level) to align with the > real DT. > > Signed-off-by: Masahiro Yamada > --- > > .../bindings/thermal/socionext,uniphier-thermal.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml > index 553c9dcdaeeb..57ffd0c4c474 100644 > --- a/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml > +++ b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml > @@ -29,6 +29,7 @@ properties: > > socionext,tmod-calibration: > $ref: /schemas/types.yaml#/definitions/uint32-array > + minItems: 2 The intent was if minItems is not defined, then the default is the same as maxItems. This is not the default for json-schema, so the tooling is supposed to add it. But looking at processed-schema.yaml, it doesn't seem to be happening for one case here. I'm working on a fix in the tools. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel