From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46191C433E3 for ; Sat, 18 Jul 2020 14:35:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 124142076A for ; Sat, 18 Jul 2020 14:35:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="24yvRQdL"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Gge3Lrrj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 124142076A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aRbjdZtGFdIRGV3aJSsUaR/DM8xgeJLjgAVM6urKwag=; b=24yvRQdLLpRN22CcSU2RJFkKG qaD3cTHknnk4opkRB3G0T9iUIhvsjokXFtqkK3BnS/tj7FmtFnwO7hOZQnDc9z8sMnXXy2vqrsHR7 1QaAaxQ/B9pjz2/AbEA42NyHGBi+LNzmyTCj2EsC22GJ2Nosghvsw8X0H3AuntvUfKdjcNeMzRYRs M+/MHuB5iV5T3UkwN0vUeQFZdww17sk6qWM4hSrtYTR07S7vTbVUwbrUSZ/VOX848oafgYAHG2FB+ tZ4USxm9X0s0gxJ8nGXIjOHI88PHk7N1n7PSGsVQCAO8ZwBRX99vtTjl3Rlxb04gURM+/gFgiXov/ XKCkekPdw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwnuS-0002fY-SO; Sat, 18 Jul 2020 14:33:52 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwnuR-0002f3-2v for linux-arm-kernel@lists.infradead.org; Sat, 18 Jul 2020 14:33:51 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 843B22064B; Sat, 18 Jul 2020 14:33:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595082830; bh=aGwpt6WMtqY5/WwIWAUClRDNeEjX6lZPDr9q46ZIAzA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Gge3LrrjfJKyzp//YFHSwSmJVxw7LfnupVN36U63PeAqSXkxRPKvxWsEHCV/LqNw7 m/EMa0BK62RgKjFd1YnGzoReJaUHRmQSSFzFAPtHYrefkFkPx6R4PFC+BFfN6pfmJH ukVYIi2uU1CsfI2Iw0+T2mhjS1OJ1/vJiOOEru3I= Date: Sat, 18 Jul 2020 15:33:45 +0100 From: Jonathan Cameron To: Lee Jones Subject: Re: [PATCH 05/30] iio: chemical: sgp30: Add description for sgp_read_cmd()'s 'duration_us' Message-ID: <20200718153345.0a6a5720@archlinux> In-Reply-To: <20200716135928.1456727-6-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-6-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200718_103351_206998_79802E8E X-CRM114-Status: GOOD ( 16.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lars@metafoo.de, Andreas Brauchli , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de, linux-arm-kernel@lists.infradead.org, Pascal Sachs Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 16 Jul 2020 14:59:03 +0100 Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/iio/chemical/sgp30.c:236: warning: Function parameter or member 'duration_us' not described in 'sgp_read_cmd' > > Cc: Andreas Brauchli > Cc: Pascal Sachs > Signed-off-by: Lee Jones Perhaps we can do better on the wording. > --- > drivers/iio/chemical/sgp30.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/chemical/sgp30.c b/drivers/iio/chemical/sgp30.c > index 403e8803471a9..82e407d48a0aa 100644 > --- a/drivers/iio/chemical/sgp30.c > +++ b/drivers/iio/chemical/sgp30.c > @@ -227,6 +227,7 @@ static int sgp_verify_buffer(const struct sgp_data *data, > * @cmd: SGP Command to issue > * @buf: Raw data buffer to use > * @word_count: Num words to read, excluding CRC bytes > + * @duration_us: Time to sleep in microseconds Time taken to sensor to take a reading and data to be ready. Something like that maybe? I've not checked the datasheet but from code that looks to be what this describes.. Jonathan > * > * Return: 0 on success, negative error otherwise. > */ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel