From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07834C433E0 for ; Sat, 18 Jul 2020 16:07:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C54F22073A for ; Sat, 18 Jul 2020 16:07:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="C1O8Nc+g"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="djtqJbLl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C54F22073A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uicpigdcZeZpc7m9BTPj3Ua3lTkVa1O9NZ47Cg7unaU=; b=C1O8Nc+gIqf+K6XuCUQbjRT8+ MQAYMIuXu/Va+thZxKlRbuHhCxITyOnuO7CF85OatFHrwVioD/NDUE1QbaD/VJi5iBWWCW5s9hSMy qNBSAjswhttUmUTvlwj6eGLiUes+82Cczhf5Q+RKl5Jpt2gEXsbBtvAN4tSQz0da9PWJVzSIL0V/h 0MFEob9uxQ5gRblyNPnsXlsg+x7tsI/INp8et5mSZohfpRpZXj0UotgRSEjfcVrxyKlD3ZNu3d/3U zC2KPDCMUFjw59sEDIN6PIiQBwr3PHmyE8cg/vDhZ5lvfs4D35C1FwECvO6CssGG3QBfRIc8Gr901 IdyxPj3aA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwpLz-0003Ph-Js; Sat, 18 Jul 2020 16:06:23 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwpLx-0003Os-6E for linux-arm-kernel@lists.infradead.org; Sat, 18 Jul 2020 16:06:21 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B2E142073A; Sat, 18 Jul 2020 16:06:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595088380; bh=pzVdMS6u1xo0HU/Ae/3cQay+CufheJIzPmtKdIjan3w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=djtqJbLl0cXBs7wtkm/Mo8UGFZH5zx7NQfoc0j04xcKC7p5rM3kr1jqxhQr1+u+H6 /jAxKiFXSfVjPvYD+bucW2zBG6yFZkkhXNWIkffTMg+Dafm5sry6FmdnkPWZ3HeK+d 6+Xg1CAsE08cK7/jtlUo1hPaL2rKSucFzfVrcd0M= Date: Sat, 18 Jul 2020 17:06:16 +0100 From: Jonathan Cameron To: Bjorn Andersson Subject: Re: [PATCH 26/30] iio: adc: qcom-pm8xxx-xoadc: Demote standard comment block and supply missing description Message-ID: <20200718170616.1ae2c943@archlinux> In-Reply-To: <20200717201525.GK388985@builder.lan> References: <20200717165538.3275050-1-lee.jones@linaro.org> <20200717165538.3275050-27-lee.jones@linaro.org> <20200717201525.GK388985@builder.lan> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200718_120621_383715_E6636C26 X-CRM114-Status: GOOD ( 20.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lars@metafoo.de, linux-iio@vger.kernel.org, linux-arm-msm@vger.kernel.org, Linus Walleij , linux-kernel@vger.kernel.org, Andy Gross , pmeerw@pmeerw.net, knaack.h@gmx.de, Lee Jones , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 17 Jul 2020 13:15:25 -0700 Bjorn Andersson wrote: > On Fri 17 Jul 09:55 PDT 2020, Lee Jones wrote: > > > Kerneldoc is only suitable for documenting functions and struct/enums. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_INTERNAL' description in 'PM8XXX_CHANNEL_INTERNAL' > > drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_125V' description in 'PM8XXX_CHANNEL_INTERNAL' > > drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_INTERNAL_2' description in 'PM8XXX_CHANNEL_INTERNAL' > > drivers/iio/adc/qcom-pm8xxx-xoadc.c:133: warning: Excess function parameter 'PM8XXX_CHANNEL_MUXOFF' description in 'PM8XXX_CHANNEL_INTERNAL' > > drivers/iio/adc/qcom-pm8xxx-xoadc.c:412: warning: Function parameter or member 'variant' not described in 'pm8xxx_xoadc' > > > > Cc: Andy Gross > > Cc: Bjorn Andersson > > Cc: Linus Walleij > > Cc: linux-arm-msm@vger.kernel.org > > Signed-off-by: Lee Jones > > Reviewed-by: Bjorn Andersson > Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > > --- > > drivers/iio/adc/qcom-pm8xxx-xoadc.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/iio/adc/qcom-pm8xxx-xoadc.c b/drivers/iio/adc/qcom-pm8xxx-xoadc.c > > index c599ffa45a04c..cd5fa30e77df4 100644 > > --- a/drivers/iio/adc/qcom-pm8xxx-xoadc.c > > +++ b/drivers/iio/adc/qcom-pm8xxx-xoadc.c > > @@ -120,7 +120,7 @@ > > #define ADC_ARB_USRP_DATA0 0x19D > > #define ADC_ARB_USRP_DATA1 0x19C > > > > -/** > > +/* > > * Physical channels which MUST exist on all PM variants in order to provide > > * proper reference points for calibration. > > * > > @@ -388,6 +388,7 @@ struct pm8xxx_chan_info { > > * struct pm8xxx_xoadc - state container for the XOADC > > * @dev: pointer to device > > * @map: regmap to access registers > > + * @variant: XOADC variant characteristics > > * @vref: reference voltage regulator > > * characteristics of the channels, and sensible default settings > > * @nchans: number of channels, configured by the device tree > > -- > > 2.25.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel