From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A03CC433DF for ; Sat, 18 Jul 2020 17:15:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4780D20702 for ; Sat, 18 Jul 2020 17:15:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SJSfc+ai" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4780D20702 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sigxcpu.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NY010UWn9DqTEhttRq53DYVUJtRZ6J+fQaOyTzEsPqs=; b=SJSfc+aiV09c0f1YeP65AdeUq ukz8kl8fMhMcAx7HvMn64Eq1wjire8ceh+TjullJSTnPV4PTlHQbWadZ/AneIqCGEdpYHSMrg/uho uX0IO8HZ3UcfCcZnilCuwFZ1pI84OrWgUczt1NW+eLGNUK7vbXKtEA5pUbXh/Y1pB8DGDFUnXjrYG V14DP//Ban0nNdiuX5fio7hZ0ovjzKVeyYEn7cvxBJgRpQoGQRaeaGWZ5ncYh44AD6m3ZmNmrBTOc Jc+Ri16ieeooM938yQ0JrQC7ThzIbwpFuNm3Lb3KDdNJWYm5h/53iGpYwyVkndqxKxjBOc5CkKTkC T3wI2qSOg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwqPf-0000fz-3f; Sat, 18 Jul 2020 17:14:15 +0000 Received: from honk.sigxcpu.org ([24.134.29.49]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwqPc-0000fS-LP for linux-arm-kernel@lists.infradead.org; Sat, 18 Jul 2020 17:14:13 +0000 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id 5B64DFB03; Sat, 18 Jul 2020 19:14:09 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yZrIF0sHGSa6; Sat, 18 Jul 2020 19:14:08 +0200 (CEST) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id BF41542576; Sat, 18 Jul 2020 19:14:07 +0200 (CEST) Date: Sat, 18 Jul 2020 19:14:07 +0200 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Lucas Stach Subject: Re: [PATCH] drm/mxsfb: Make supported modifiers explicit Message-ID: <20200718171407.GA72952@bogon.m.sigxcpu.org> References: <26877532e272c12a74c33188e2a72abafc9a2e1c.1584973664.git.agx@sigxcpu.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200718_131412_857085_930C9BB8 X-CRM114-Status: GOOD ( 15.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Pengutronix Kernel Team , dri-devel@lists.freedesktop.org, David Airlie , Fabio Estevam , Sascha Hauer , linux-kernel@vger.kernel.org, Stefan Agner , NXP Linux Team , Daniel Vetter , Shawn Guo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Mon, Mar 23, 2020 at 04:51:05PM +0100, Lucas Stach wrote: > Am Montag, den 23.03.2020, 15:52 +0100 schrieb Guido G=FCnther: > > In contrast to other display controllers on imx like DCSS and ipuv3 > > lcdif/mxsfb does not support detiling e.g. vivante tiled layouts. > > Since mesa might assume otherwise make it explicit that only > > DRM_FORMAT_MOD_LINEAR is supported. > > = > > Signed-off-by: Guido G=FCnther > = > Reviewed-by: Lucas Stach Can i do anything to get this applied? Cheers, -- Guido > = > > --- > > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 9 +++++++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > = > > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/= mxsfb_drv.c > > index 762379530928..fc71e7a7a02e 100644 > > --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c > > +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c > > @@ -73,6 +73,11 @@ static const uint32_t mxsfb_formats[] =3D { > > DRM_FORMAT_RGB565 > > }; > > = > > +static const uint64_t mxsfb_modifiers[] =3D { > > + DRM_FORMAT_MOD_LINEAR, > > + DRM_FORMAT_MOD_INVALID > > +}; > > + > > static struct mxsfb_drm_private * > > drm_pipe_to_mxsfb_drm_private(struct drm_simple_display_pipe *pipe) > > { > > @@ -334,8 +339,8 @@ static int mxsfb_load(struct drm_device *drm, unsig= ned long flags) > > } > > = > > ret =3D drm_simple_display_pipe_init(drm, &mxsfb->pipe, &mxsfb_funcs, > > - mxsfb_formats, ARRAY_SIZE(mxsfb_formats), NULL, > > - mxsfb->connector); > > + mxsfb_formats, ARRAY_SIZE(mxsfb_formats), > > + mxsfb_modifiers, mxsfb->connector); > > if (ret < 0) { > > dev_err(drm->dev, "Cannot setup simple display pipe\n"); > > goto err_vblank; > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel