From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 981C1C433E3 for ; Mon, 20 Jul 2020 01:12:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64704208B3 for ; Mon, 20 Jul 2020 01:12:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="s4C2hEpY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64704208B3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To:From:Subject:To: Message-Id:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BNQ12korpRCuZ/9Z/5f/sGb5FQY3OtZMfarr/wt23AU=; b=s4C2hEpYQGR5wA9/w66ThHg2k R2vCc4zWsh5xy0e4HeLuwZ6gjej30aXFln6mNtpPJ0yaqhKDr+l9+MokbOB8mh9PNGadq38I0pZbd 32VgFkjFhNuFRiRfboB1uwDlJDQRjzJjHKWLck5ckT6LkGdsXIQM73rMmlpkYFjpEJdtOMcKAF+PR 8z6Iyf/HvSYxiIHrfoAuktGppUdymMM5LUZH+LzNNePK1Wr2l5YRNRj/nuJHCeJ3ruGt73/PiR6ID 2hIvEsVVEbs4MKlJx7AHQGS7DJxfIbf2PiQfwpc7E/gqnYVPhqHbk3uO646JBTyY89iCJrhyfoB0n PtxKgfrgA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxKK1-00083y-CS; Mon, 20 Jul 2020 01:10:25 +0000 Received: from shards.monkeyblade.net ([2620:137:e000::1:9]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxKJy-0007yr-P3 for linux-arm-kernel@lists.infradead.org; Mon, 20 Jul 2020 01:10:23 +0000 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 8B9861284827B; Sun, 19 Jul 2020 18:10:13 -0700 (PDT) Date: Sun, 19 Jul 2020 18:10:12 -0700 (PDT) Message-Id: <20200719.181012.2032747244788963553.davem@davemloft.net> To: rmk+kernel@armlinux.org.uk Subject: Re: [PATCH net] net: dsa: mv88e6xxx: fix in-band AN link establishment From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 19 Jul 2020 18:10:14 -0700 (PDT) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200719_211023_053003_D030398E X-CRM114-Status: GOOD ( 15.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, f.fainelli@gmail.com, jason@lakedaemon.net, martin.p.rowe@gmail.com, devicetree@vger.kernel.org, netdev@vger.kernel.org, gregory.clement@bootlin.com, robh+dt@kernel.org, kuba@kernel.org, sebastian.hesselbarth@gmail.com, vivien.didelot@gmail.com, linux-arm-kernel@lists.infradead.org, hkallweit1@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Russell King Date: Sun, 19 Jul 2020 12:00:35 +0100 > If in-band negotiation or fixed-link modes are specified for a DSA > port, the DSA code will force the link down during initialisation. For > fixed-link mode, this is fine, as phylink will manage the link state. > However, for in-band mode, phylink expects the PCS to detect link, > which will not happen if the link is forced down. > > There is a related issue that in in-band mode, the link could come up > while we are making configuration changes, so we should force the link > down prior to reconfiguring the interface mode. > > This patch addresses both issues. > > Fixes: 3be98b2d5fbc ("net: dsa: Down cpu/dsa ports phylink will control") > Signed-off-by: Russell King Applied and queued up for -stable, but: > @@ -664,6 +664,7 @@ static void mv88e6xxx_mac_config(struct dsa_switch *ds, int port, > const struct phylink_link_state *state) > { > struct mv88e6xxx_chip *chip = ds->priv; > + struct mv88e6xxx_port *p = &chip->ports[port]; > int err; I fixed the reverse christmas tree breakage here by moving the 'p' assignment into the function body. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel