From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B26C8C433DF for ; Sun, 19 Jul 2020 13:52:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FC002080D for ; Sun, 19 Jul 2020 13:52:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jADcwhYZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FC002080D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yUehzQlZ61pj1n7dlWh/FXPUbRa3xVqbFmzii00yXqU=; b=jADcwhYZ3aCwd7s52G949NfFh SvT0DaICkuDxFHNV1qe58dNA3YmBgUjksvcURmtMfafyBmbKxk0H8VPhb8ubnFWot6JzOkzBhsTXE mXKCi6Vk5n+GfCrLuJu1uhpLitGnq8klezhkrlGdowJQ6e5DM/iUx5keNCxNXA8Wu06XtO+2Pl3eC MuK52BsuMA7DITOXsUk51NJ8yvImG184mYZbHADdlzOwaRisJDfj3p3gaafe75bciApWXvlQGX9A6 IwtJzlUiBTAU5CLaXEPMULt8dRn+fQNZ0F6sY/xpm/lDobSjpF+mUxfQq2KduokvIFKuNMWK3FUOu eQYxHfCpg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jx9ht-0000cz-Ge; Sun, 19 Jul 2020 13:50:21 +0000 Received: from mga02.intel.com ([134.134.136.20]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jx9hn-0000bs-Lp for linux-arm-kernel@lists.infradead.org; Sun, 19 Jul 2020 13:50:20 +0000 IronPort-SDR: j3lHPmsrLbncr4ckI1LYs+UKLA+3TThkkedXnOvAgRA8RVX50H8uwVqbUJGRkJ7yDqCY2GFcKX mbiT3116nXNA== X-IronPort-AV: E=McAfee;i="6000,8403,9686"; a="137910253" X-IronPort-AV: E=Sophos;i="5.75,370,1589266800"; d="scan'208";a="137910253" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2020 06:50:08 -0700 IronPort-SDR: 2YJuQ/0QKvefYMfDyI9Y6N4/9LyEVGpAFcdg6Z5LPv51p5eSuM2Vq/zuL9N+SXd8DSYBcKNAe9 Y8Nw7DmR1tIw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,370,1589266800"; d="scan'208";a="486963458" Received: from lkp-server02.sh.intel.com (HELO 50058c6ee6fc) ([10.239.97.151]) by fmsmga006.fm.intel.com with ESMTP; 19 Jul 2020 06:50:06 -0700 Received: from kbuild by 50058c6ee6fc with local (Exim 4.92) (envelope-from ) id 1jx9hd-00019d-Ji; Sun, 19 Jul 2020 13:50:05 +0000 Date: Sun, 19 Jul 2020 21:49:07 +0800 From: kernel test robot To: Chuhong Yuan Subject: [PATCH] media: exynos4-is: fix ptr_ret.cocci warnings Message-ID: <20200719134907.GA16381@c288844b3313> References: <202007192158.9kUQhoax%lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <202007192158.9kUQhoax%lkp@intel.com> X-Patchwork-Hint: ignore User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200719_095015_889726_4AA25157 X-CRM114-Status: GOOD ( 14.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, kbuild-all@lists.01.org, Krzysztof Kozlowski , Hans Verkuil , Kyungmin Park , Kukjin Kim , Sylwester Nawrocki , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: kernel test robot drivers/media/platform/exynos4-is/media-dev.c:1273:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 18ffec750578 ("media: exynos4-is: Add missed check for pinctrl_lookup_state()") CC: Chuhong Yuan Signed-off-by: kernel test robot --- tree: git://linuxtv.org/media_tree.git master head: 8f2a4a9d5ff5202d0b3e3a144ebb9b67aabadd29 commit: 18ffec750578f7447c288647d7282c7d12b1d969 [119/306] media: exynos4-is: Add missed check for pinctrl_lookup_state() media-dev.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/media/platform/exynos4-is/media-dev.c +++ b/drivers/media/platform/exynos4-is/media-dev.c @@ -1270,10 +1270,7 @@ static int fimc_md_get_pinctrl(struct fi pctl->state_idle = pinctrl_lookup_state(pctl->pinctrl, PINCTRL_STATE_IDLE); - if (IS_ERR(pctl->state_idle)) - return PTR_ERR(pctl->state_idle); - - return 0; + return PTR_ERR_OR_ZERO(pctl->state_idle); } static int cam_clk_prepare(struct clk_hw *hw) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel