From: Shawn Guo <shawnguo@kernel.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: peng.fan@nxp.com, mturquette@baylibre.com,
laurent.pinchart@ideasonboard.com, chen.fang@nxp.com,
festevam@gmail.com, linux-clk@vger.kernel.org,
sfr@canb.auug.org.au, abel.vesa@nxp.com,
Anson Huang <Anson.Huang@nxp.com>,
andrew.smirnov@gmail.com, yuehaibing@huawei.com,
georg.waibel@wiedemann-group.de, Linux-imx@nxp.com,
Georg.Waibel@wiedemann-group.com, s.hauer@pengutronix.de,
daniel.baluta@nxp.com, linux-arm-kernel@lists.infradead.org,
aisheng.dong@nxp.com, fugang.duan@nxp.com, horia.geanta@nxp.com,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
j.remmet@phytec.de
Subject: Re: [PATCH V6 6/6] clk: imx6sl: Fix build warning reported by kernel test robot
Date: Mon, 20 Jul 2020 09:55:54 +0800 [thread overview]
Message-ID: <20200720015553.GB11560@dragon> (raw)
In-Reply-To: <159486121748.1987609.16422613903444902156@swboyd.mtv.corp.google.com>
On Wed, Jul 15, 2020 at 06:00:17PM -0700, Stephen Boyd wrote:
> Quoting Anson Huang (2020-07-06 22:09:39)
> > Use readl_relaxed() instead of __raw_readl(), and use BIT(x)
> > instead of (1 << X) to fix below build warning reported by kernel
> > test robot:
> >
> > drivers/clk/imx/clk-imx6sl.c:149:49: warning: Shifting signed 32-bit
> > value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
> > while (!(__raw_readl(anatop_base + PLL_ARM) & BM_PLL_ARM_LOCK))
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > Reported-by: kernel test robot <lkp@intel.com>
> > ---
>
> The subject is poor. Please improve it so that it summarizes the change
> instead of the reaction to a warning from a robot.
>
> > New patch.
> > ---
> > drivers/clk/imx/clk-imx6sl.c | 15 ++++++++-------
> > 1 file changed, 8 insertions(+), 7 deletions(-)
> >
>
> This should come earlier in the series too so that the build warning
> doesn't come out before this patch is applied.
Anson,
Please update the series per request from Stephen. I have dropped the
series from my branch.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-20 1:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 5:09 [PATCH V6 0/6] Support building i.MX ARMv8 platforms clock driver as module Anson Huang
2020-07-07 5:09 ` [PATCH V6 1/6] clk: composite: Export clk_hw_register_composite() Anson Huang
2020-07-07 5:09 ` [PATCH V6 2/6] clk: imx: Support building i.MX common clock driver as module Anson Huang
2020-07-16 0:57 ` Stephen Boyd
2020-07-07 5:09 ` [PATCH V6 3/6] clk: imx: Add clock configuration for ARMv7 platforms Anson Huang
2020-07-16 0:58 ` Stephen Boyd
2020-07-07 5:09 ` [PATCH V6 4/6] clk: imx8m: Support module build Anson Huang
2020-07-16 0:58 ` Stephen Boyd
2020-07-07 5:09 ` [PATCH V6 5/6] clk: imx8qxp: Support building i.MX8QXP clock driver as module Anson Huang
2020-07-16 0:58 ` Stephen Boyd
2020-07-07 5:09 ` [PATCH V6 6/6] clk: imx6sl: Fix build warning reported by kernel test robot Anson Huang
2020-07-16 1:00 ` Stephen Boyd
2020-07-20 1:55 ` Shawn Guo [this message]
2020-07-13 9:25 ` [PATCH V6 0/6] Support building i.MX ARMv8 platforms clock driver as module Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720015553.GB11560@dragon \
--to=shawnguo@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=Georg.Waibel@wiedemann-group.com \
--cc=Linux-imx@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=andrew.smirnov@gmail.com \
--cc=chen.fang@nxp.com \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=georg.waibel@wiedemann-group.de \
--cc=horia.geanta@nxp.com \
--cc=j.remmet@phytec.de \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox