From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7BB9C433DF for ; Mon, 20 Jul 2020 01:57:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7370620B1F for ; Mon, 20 Jul 2020 01:57:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SXTEyrZa"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="sMTz2hhU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7370620B1F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BPEl1GCVQngQOg55u7TdAzKoMzTt3XZqj9lugIHu3vY=; b=SXTEyrZasdTGH8OMHKLfsx1Pt rR85Asq57wEFFH7OrWfRbJ4MFwlP7FFW05h5uw37k5VPZ16OYgXP5V47cbf1LNZHgfjHJ+plcz0a8 R+LTUS0w+f/Vinvr4TJsRO+uJHRxpuLJJDiFpm5lrBX0v7w0k++U+zFD2i4UDIHf8g3nradTVCTcE VQehHWzd1IDxNSpQgkF5vp3aLl8xGoYGGYBN+cF318zQnEhzPLeiJ8BcPDq8qU0skRpKo26VrVlrg 7cbg64xbXFNwXJAVF9erdChKW30aLMshqkxuzco7qaRw7NXwRfjP8jsrTEUBpJFT4ZOo9AxbGIBLY chlAJkGlg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxL2O-0002Ug-EK; Mon, 20 Jul 2020 01:56:16 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxL2K-0002U5-ML for linux-arm-kernel@lists.infradead.org; Mon, 20 Jul 2020 01:56:13 +0000 Received: from dragon (unknown [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9EB0820809; Mon, 20 Jul 2020 01:56:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595210171; bh=W8YzRx78vB3k/uKqwUom8cLKtr60pKZvb50g41M28uI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sMTz2hhUZp9w8dXrJkd1hWjfwAxDM8zB73GZ8411ME0c7BLSdbyZLmqPCQF8suXmL 5azAd7pqFNBmVzLxN36ONOJ14dGUssXSKfgBcyAwACZ+wh9Sj/fNFG01R/uvk6eZEI PZ4LGToxAiEHuvqwIymw1f4BtJ5KIqiF98x3ShHM= Date: Mon, 20 Jul 2020 09:55:54 +0800 From: Shawn Guo To: Stephen Boyd Subject: Re: [PATCH V6 6/6] clk: imx6sl: Fix build warning reported by kernel test robot Message-ID: <20200720015553.GB11560@dragon> References: <1594098579-25050-1-git-send-email-Anson.Huang@nxp.com> <1594098579-25050-7-git-send-email-Anson.Huang@nxp.com> <159486121748.1987609.16422613903444902156@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <159486121748.1987609.16422613903444902156@swboyd.mtv.corp.google.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200719_215612_815899_0FFBE1BE X-CRM114-Status: GOOD ( 16.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peng.fan@nxp.com, mturquette@baylibre.com, laurent.pinchart@ideasonboard.com, chen.fang@nxp.com, festevam@gmail.com, linux-clk@vger.kernel.org, sfr@canb.auug.org.au, abel.vesa@nxp.com, Anson Huang , andrew.smirnov@gmail.com, yuehaibing@huawei.com, georg.waibel@wiedemann-group.de, Linux-imx@nxp.com, Georg.Waibel@wiedemann-group.com, s.hauer@pengutronix.de, daniel.baluta@nxp.com, linux-arm-kernel@lists.infradead.org, aisheng.dong@nxp.com, fugang.duan@nxp.com, horia.geanta@nxp.com, linux-kernel@vger.kernel.org, kernel@pengutronix.de, j.remmet@phytec.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 15, 2020 at 06:00:17PM -0700, Stephen Boyd wrote: > Quoting Anson Huang (2020-07-06 22:09:39) > > Use readl_relaxed() instead of __raw_readl(), and use BIT(x) > > instead of (1 << X) to fix below build warning reported by kernel > > test robot: > > > > drivers/clk/imx/clk-imx6sl.c:149:49: warning: Shifting signed 32-bit > > value by 31 bits is undefined behaviour [shiftTooManyBitsSigned] > > while (!(__raw_readl(anatop_base + PLL_ARM) & BM_PLL_ARM_LOCK)) > > > > Signed-off-by: Anson Huang > > Reported-by: kernel test robot > > --- > > The subject is poor. Please improve it so that it summarizes the change > instead of the reaction to a warning from a robot. > > > New patch. > > --- > > drivers/clk/imx/clk-imx6sl.c | 15 ++++++++------- > > 1 file changed, 8 insertions(+), 7 deletions(-) > > > > This should come earlier in the series too so that the build warning > doesn't come out before this patch is applied. Anson, Please update the series per request from Stephen. I have dropped the series from my branch. Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel