From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C643DC433DF for ; Mon, 20 Jul 2020 02:13:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 937E72250E for ; Mon, 20 Jul 2020 02:13:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vpi2COsj"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="xYYOIPhj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 937E72250E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8z3dFGwiBpDXfR1LxRrqEisE6IlBO36eq/RVidYEw1c=; b=vpi2COsjHvVXmgZmVSVvQ2T5h BV76qlQqN77rFJ/uOaxpXHigAWn11HLJrxy1e5V+OCyi03fD1NETCJWbBaoz6xCVLF+b9HMF6kSk8 ErC4I1Zxvh1zV2V7/B1DF593g0hm+aAvAHAAHZKw4HEGVqJj0gHbOBu9hg1RfQJPNqtcDihh0eUVP 3a9HG5JOaBtspkNHgu5Z8jgchOd/R3j8xt53ULaf953dxEPce9ixf//06Ibvmfx37tv2AQTIEpjtw ZbVf62RRmOzcJTrC6C+w57TMUWgYP1GbiQ06d+3v/bRZ5ZBerzEWUDiHOP9IbuUBe8VsfEyyBatL5 YJ/EKrXzQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxLHN-00048h-RM; Mon, 20 Jul 2020 02:11:45 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxLHK-000484-RV for linux-arm-kernel@lists.infradead.org; Mon, 20 Jul 2020 02:11:43 +0000 Received: from dragon (unknown [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 15472208B3; Mon, 20 Jul 2020 02:11:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595211101; bh=PgDcAq+4nyz4PbXB7ez/Cs907K+I0Hwh/nXW03+MYaE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xYYOIPhjYHhrVPbinYr1Yu+dMXz1s1oqP1orozIz0nqL8+BlHf4G6rTrMRoHCqrfc yG4A/mlQ25vMLDKLq6LssLNpRR+ieh7scg5n3dK6hVfNRIUzlZ6nTKBrVGfUVRAsEr cn1ufSU/UGfA1eXN/Rqddi2dwmloZUaIMBK65mHA= Date: Mon, 20 Jul 2020 10:11:26 +0800 From: Shawn Guo To: Philippe Schenker Subject: Re: [PATCH 3/3] ARM: dts: colibri-imx7: add usb dual-role switch capability Message-ID: <20200720021125.GC11560@dragon> References: <20200710132423.497230-1-philippe.schenker@toradex.com> <20200710132423.497230-3-philippe.schenker@toradex.com> <73240ab0-5069-40c5-4ade-7fcc2207dfaf@pengutronix.de> <7e6f8135-120f-0831-20ad-25648ea646b8@pengutronix.de> <83b230cef109e1a413ab1036c21ad763a1d127eb.camel@toradex.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <83b230cef109e1a413ab1036c21ad763a1d127eb.camel@toradex.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200719_221142_977000_A5904368 X-CRM114-Status: GOOD ( 25.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "a.fatoum@pengutronix.de" , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "linux-imx@nxp.com" , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 14, 2020 at 08:20:34AM +0000, Philippe Schenker wrote: > On Tue, 2020-07-14 at 09:55 +0200, Ahmad Fatoum wrote: > > Hello Philippe, > > > > On 7/13/20 1:53 PM, Philippe Schenker wrote: > > > On Mon, 2020-07-13 at 11:46 +0200, Ahmad Fatoum wrote: > > > > Hello Philippe, > > > > > > > > > + extcon_usbc_det: usbc_det { > > > > > + compatible = "linux,extcon-usb-gpio"; > > > > > > > > According to 4602f3bff266 ("usb: common: add USB GPIO based > > > > connection > > > > detection driver"): > > > > "the old way using extcon to support USB Dual-Role switch is now > > > > deprecated > > > > when use Type-B connector." > > > > > > > > Have you considered using a compatible = "gpio-usb-b-connector" > > > > child > > > > node instead? > > > > > > > > Cheers, > > > > Ahmad > > > > > > Thanks for the Hint Ahmad, > > > > > > I already tried and just now tried again but it doesn't work on our > > > hardware. Are you sure this works with chipidea driver? > > > > I haven't, just wanted to point its existence out in case you didn't > > know. > > Seems we need to call of_platform_populate somewhere in the driver. > > Unsure what other changes are necessary. > > Yep, thanks for that! It seems like that need to be really called as I > can't get a probe of the new usb connector driver. I quickly grepped > through code and saw that tegra USB driver is calling > of_platform_populate and they also use that gpio-usb-b-connector. > > > > > > Should this new usb-connector stuff work in general with every old > > > driver? > > > > If the driver support isn't there yet, I think use of extcon is fine > > as is. Shouldn't we improve chipidea driver to get it work with gpio-usb-b-connector? Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel