From: Shawn Guo <shawnguo@kernel.org>
To: Chris Healy <cphealy@gmail.com>
Cc: devicetree@vger.kernel.org, s.hauer@pengutronix.de,
linux-kernel@vger.kernel.org, stefan@agner.ch,
robh+dt@kernel.org, festevam@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: ZII: Disable HW Ethernet switch reset GPIO
Date: Mon, 20 Jul 2020 11:15:35 +0800 [thread overview]
Message-ID: <20200720031534.GJ11560@dragon> (raw)
In-Reply-To: <20200715212227.26436-1-cphealy@gmail.com>
On Wed, Jul 15, 2020 at 02:22:27PM -0700, Chris Healy wrote:
> Disable Ethernet switch reset GPIO with ZII platforms that have it
> enabled to sync up with existing ZII platforms that already have
> it disabled.
I do not follow it. The reset GPIO is part of hardware description. We
shouldn't add or remove it for sake of sync-up with other platforms.
Shawn
>
> Signed-off-by: Chris Healy <cphealy@gmail.com>
> ---
> arch/arm/boot/dts/vf610-zii-cfu1.dts | 2 --
> arch/arm/boot/dts/vf610-zii-spb4.dts | 2 --
> arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts | 2 --
> arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts | 2 --
> 4 files changed, 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/vf610-zii-cfu1.dts b/arch/arm/boot/dts/vf610-zii-cfu1.dts
> index ce1920c052fc..c2668230a4c0 100644
> --- a/arch/arm/boot/dts/vf610-zii-cfu1.dts
> +++ b/arch/arm/boot/dts/vf610-zii-cfu1.dts
> @@ -170,7 +170,6 @@
> interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> interrupt-controller;
> #interrupt-cells = <2>;
> - reset-gpios = <&gpio3 11 GPIO_ACTIVE_LOW>;
>
> ports {
> #address-cells = <1>;
> @@ -354,7 +353,6 @@
> pinctrl_switch: switch-grp {
> fsl,pins = <
> VF610_PAD_PTB28__GPIO_98 0x3061
> - VF610_PAD_PTE2__GPIO_107 0x1042
> >;
> };
>
> diff --git a/arch/arm/boot/dts/vf610-zii-spb4.dts b/arch/arm/boot/dts/vf610-zii-spb4.dts
> index 55b4201e27f6..261317340189 100644
> --- a/arch/arm/boot/dts/vf610-zii-spb4.dts
> +++ b/arch/arm/boot/dts/vf610-zii-spb4.dts
> @@ -127,7 +127,6 @@
> pinctrl-names = "default";
> reg = <0>;
> eeprom-length = <65536>;
> - reset-gpios = <&gpio3 11 GPIO_ACTIVE_LOW>;
> interrupt-parent = <&gpio3>;
> interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> interrupt-controller;
> @@ -312,7 +311,6 @@
>
> pinctrl_gpio_switch0: pinctrl-gpio-switch0 {
> fsl,pins = <
> - VF610_PAD_PTE2__GPIO_107 0x31c2
> VF610_PAD_PTB28__GPIO_98 0x219d
> >;
> };
> diff --git a/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts b/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> index a6c22a79779e..e37b9643269b 100644
> --- a/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> +++ b/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> @@ -113,7 +113,6 @@
> pinctrl-names = "default";
> reg = <0>;
> eeprom-length = <65536>;
> - reset-gpios = <&gpio3 11 GPIO_ACTIVE_LOW>;
> interrupt-parent = <&gpio3>;
> interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> interrupt-controller;
> @@ -288,7 +287,6 @@
>
> pinctrl_gpio_switch0: pinctrl-gpio-switch0 {
> fsl,pins = <
> - VF610_PAD_PTE2__GPIO_107 0x31c2
> VF610_PAD_PTB28__GPIO_98 0x219d
> >;
> };
> diff --git a/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts b/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
> index 3d05c894bdc0..b3d6d4b9fa9c 100644
> --- a/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
> +++ b/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
> @@ -141,7 +141,6 @@
> pinctrl-names = "default";
> reg = <0>;
> eeprom-length = <65536>;
> - reset-gpios = <&gpio3 11 GPIO_ACTIVE_LOW>;
> interrupt-parent = <&gpio3>;
> interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> interrupt-controller;
> @@ -319,7 +318,6 @@
>
> pinctrl_gpio_switch0: pinctrl-gpio-switch0 {
> fsl,pins = <
> - VF610_PAD_PTE2__GPIO_107 0x31c2
> VF610_PAD_PTB28__GPIO_98 0x219d
> >;
> };
> --
> 2.21.3
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-20 3:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 21:22 [PATCH] ARM: dts: ZII: Disable HW Ethernet switch reset GPIO Chris Healy
2020-07-20 3:15 ` Shawn Guo [this message]
2020-07-20 4:48 ` Chris Healy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720031534.GJ11560@dragon \
--to=shawnguo@kernel.org \
--cc=cphealy@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).