From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BC8DC433E0 for ; Mon, 20 Jul 2020 07:32:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2B96F2080D for ; Mon, 20 Jul 2020 07:32:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2HGZNR+A"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="c2blEXv0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B96F2080D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XIty9AKjBeFnXKiFrJ2Q49qxzrRICQxLt4B3VqHVBlQ=; b=2HGZNR+AQgaRvVLl5bfhOBYdo JmJgA2uzjAYG1OCeiWXf8O1x8JEqd+HibC6kwm2rr6jFnZxwQfwfbCQ8wtgHEWnFlPACh9CqXLytV Y7W/69j3zRaWKVrUuqS0omWFjG3kN3dfUDYOtRBt5v8ZARc1PEwsjK+gGn4PtsULpeotAYOyWGX90 2wA9FWwlRgM9L9q/RgDmfIXJh7n3WRq/l2uzAqqjDH9/2cO9KOIXf9UkQ0+afK1qIFuKS/Ul2Ipbk jNiZf/o+sY4/Ukrumm8vRRMKBxRvS9MEhBpcHwYHdmDi9RotyqOazA/l/1ISoYLpE8gGQDgTF3b73 4BRddEy6g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxQGe-00040x-Iu; Mon, 20 Jul 2020 07:31:20 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxQGb-0003yZ-92 for linux-arm-kernel@lists.infradead.org; Mon, 20 Jul 2020 07:31:18 +0000 Received: by mail-wm1-x343.google.com with SMTP id o8so21203819wmh.4 for ; Mon, 20 Jul 2020 00:31:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=OVJCr1m5cczEE11Y4OrOEI2+d5VysNb+avvmYGzz5EQ=; b=c2blEXv0PV3Forf/ih8O0N/mHD2GxHU2L/pCRcwYxPtM45rL0mRfdPLxH55yIKq/hQ A9wJ6pwhd6rMsNEnULADCT0fxYXXijggxfgpwa+AOCL8LW2a6O1iVuYlDSBFXV3uqekV OdRhqh8OBMAJvnxn57iZOwlGdigLtnkVQMBpc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=OVJCr1m5cczEE11Y4OrOEI2+d5VysNb+avvmYGzz5EQ=; b=Bto3y8OEzvZyrJGZWPGM4fn2v6njEpMJbLgzNkCM2eJziOxKdjMy9O3r+sNqJbUlBH Mq5ETZPsBFKLGFvPtNly+aRYTA8NUCPfQcToLYS2xhqqZ6eidXFgeJncXzqMVJkjmliG 25qyD7g2TPMjQXfQW+MBvVs2GH4zGbXzFx3cBeBu6UJokQo/61ROdprVFwPUNkw7+T6K 9jgJaTeb/gCRWDtduKNDHipjFkkuUU29d2wjPSHuB2gsgvFTAhL0Q9SikKm7rzsUl0cq SdyirUQdRHZ1ZxFk2O2Sfjk5jSMnHlXb7YtF+brwb+G6H+7GLDina7swME7H/Wg6A8gL sC1w== X-Gm-Message-State: AOAM532fbcXQWYaqoDGQ5uaagxrE5pajSG54j/h1Wwqhz4s2byy1cEHL tymn3mb2YyG5xhBfIWDLBK5AsA== X-Google-Smtp-Source: ABdhPJxN7p0owcN96PIeSqEMA5x15Cm1uEAARNlBA5eLxTQA3ETt1N2u3muHoio5moLJDyia7v05Vw== X-Received: by 2002:a1c:48e:: with SMTP id 136mr19492056wme.164.1595230274849; Mon, 20 Jul 2020 00:31:14 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id h11sm7051935wrb.68.2020.07.20.00.31.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2020 00:31:14 -0700 (PDT) Date: Mon, 20 Jul 2020 09:31:12 +0200 From: Daniel Vetter To: Guido =?iso-8859-1?Q?G=FCnther?= Subject: Re: [PATCH] drm/mxsfb: Make supported modifiers explicit Message-ID: <20200720073112.GU3278063@phenom.ffwll.local> Mail-Followup-To: Guido =?iso-8859-1?Q?G=FCnther?= , Lucas Stach , Marek Vasut , Stefan Agner , David Airlie , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <26877532e272c12a74c33188e2a72abafc9a2e1c.1584973664.git.agx@sigxcpu.org> <20200718171407.GA72952@bogon.m.sigxcpu.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200718171407.GA72952@bogon.m.sigxcpu.org> X-Operating-System: Linux phenom 5.6.0-1-amd64 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200720_033117_338659_9FA736F0 X-CRM114-Status: GOOD ( 20.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Pengutronix Kernel Team , dri-devel@lists.freedesktop.org, David Airlie , Fabio Estevam , Sascha Hauer , linux-kernel@vger.kernel.org, Stefan Agner , NXP Linux Team , Daniel Vetter , Shawn Guo , linux-arm-kernel@lists.infradead.org, Lucas Stach Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jul 18, 2020 at 07:14:07PM +0200, Guido G=FCnther wrote: > Hi, > On Mon, Mar 23, 2020 at 04:51:05PM +0100, Lucas Stach wrote: > > Am Montag, den 23.03.2020, 15:52 +0100 schrieb Guido G=FCnther: > > > In contrast to other display controllers on imx like DCSS and ipuv3 > > > lcdif/mxsfb does not support detiling e.g. vivante tiled layouts. > > > Since mesa might assume otherwise make it explicit that only > > > DRM_FORMAT_MOD_LINEAR is supported. > > > = > > > Signed-off-by: Guido G=FCnther > > = > > Reviewed-by: Lucas Stach > = > Can i do anything to get this applied? > Cheers, Lucas has drm-misc commit rights, I expect him to push. -Daniel > -- Guido > = > > = > > > --- > > > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 9 +++++++-- > > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > = > > > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsf= b/mxsfb_drv.c > > > index 762379530928..fc71e7a7a02e 100644 > > > --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c > > > +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c > > > @@ -73,6 +73,11 @@ static const uint32_t mxsfb_formats[] =3D { > > > DRM_FORMAT_RGB565 > > > }; > > > = > > > +static const uint64_t mxsfb_modifiers[] =3D { > > > + DRM_FORMAT_MOD_LINEAR, > > > + DRM_FORMAT_MOD_INVALID > > > +}; > > > + > > > static struct mxsfb_drm_private * > > > drm_pipe_to_mxsfb_drm_private(struct drm_simple_display_pipe *pipe) > > > { > > > @@ -334,8 +339,8 @@ static int mxsfb_load(struct drm_device *drm, uns= igned long flags) > > > } > > > = > > > ret =3D drm_simple_display_pipe_init(drm, &mxsfb->pipe, &mxsfb_func= s, > > > - mxsfb_formats, ARRAY_SIZE(mxsfb_formats), NULL, > > > - mxsfb->connector); > > > + mxsfb_formats, ARRAY_SIZE(mxsfb_formats), > > > + mxsfb_modifiers, mxsfb->connector); > > > if (ret < 0) { > > > dev_err(drm->dev, "Cannot setup simple display pipe\n"); > > > goto err_vblank; > > = -- = Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel