From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9D52C433E5 for ; Mon, 20 Jul 2020 07:51:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 944CE20674 for ; Mon, 20 Jul 2020 07:51:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Erjhw6wF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 944CE20674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5LxbplL2dWbUw7rs5v0VmwwINV8x+CQ6Djh85+gc0zo=; b=Erjhw6wFUc3m2p8taG0IhAtmt wB2BOWrLlHeJaPqdhlUCST81KmM2VDwcWKyBaEoHrYpiBR6pFmazllAGdsbw2SWLEU+stUV3ih+c7 bMx4yNvL2S/zbLj8/EsPCqILZXLaDKG/pyzZGe1dauxIdX924hl3R95ldNH4dnsFnQNFWYObULGts 87DTOIZByFrid/oVTRI//Nj3ISdVzylbhowRPvOuSAhF7UZvA90eg55ngJ6x7l1GlzCdT+TlFmXWY z8guc4zxWCAML6m66GVkWGq+dZUZD4kkO+MnRX0PQdmm5n/wuPazC7oYysPYBVr/jUuuZ7ct+EnR8 YXVShFEmg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxQZ5-0005h6-B0; Mon, 20 Jul 2020 07:50:23 +0000 Received: from mail-wr1-f65.google.com ([209.85.221.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxQZ2-0005gR-4N for linux-arm-kernel@lists.infradead.org; Mon, 20 Jul 2020 07:50:21 +0000 Received: by mail-wr1-f65.google.com with SMTP id 88so6512925wrh.3 for ; Mon, 20 Jul 2020 00:50:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qsYFxuiVJQ8AwkMCbPhhmnP96yIZdaIh3P0cMkWmLM4=; b=EMbPWt8jL44HeMgbEKJIJd2NgK3GX0yVi/Hqs6WCe+NMLHoBxbe2nbglNJ3zArGP45 tEOPihnyIolYzklxOBVADhG1o5zc8Jz5/enXeLAp6Qks7e/3fiT0gRtW5Ku7+PBd/sQT yB2WyWZtznI6TDFx9YlJBufvYVSXyOTH/vlLyeofrggXNrtXEPgJ1Dn+VWK0lxxMJxCv GoNGKk55XrqrP72wmnPtuTg1gP1k54aMchs3BCrxzOw3ZWITpxJ3yY5Y/tSjFio4g0ng yVUlW+VtphUGcR2GfuCZgZbGtRvBgWTRH3EMKRkjRtulcdmLnZMEk1Ce/cpCVZqmGRBK qftA== X-Gm-Message-State: AOAM531aPZ10zBTJF1BzjnavYRkLA3spKCTbuvz/LX1cMX/44JslyeOp Ax0/HpZEbnjWPT1GvwAe9Po= X-Google-Smtp-Source: ABdhPJyuB6MNY9/TxDm8Vc5ztVukt0nIGOozl1ml3uktZb5ASxV5ASqOPKzSAElaBaJyVi2UYirVeA== X-Received: by 2002:a5d:6348:: with SMTP id b8mr3712910wrw.362.1595231417394; Mon, 20 Jul 2020 00:50:17 -0700 (PDT) Received: from kozik-lap ([194.230.155.200]) by smtp.googlemail.com with ESMTPSA id p25sm28968324wmg.39.2020.07.20.00.50.15 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 20 Jul 2020 00:50:15 -0700 (PDT) Date: Mon, 20 Jul 2020 09:50:13 +0200 From: Krzysztof Kozlowski To: Anand Moon Subject: Re: [PATCH v4] phy: samsung: Use readl_poll_timeout function Message-ID: <20200720075013.GA6711@kozik-lap> References: <20200713074243.530-1-linux.amoon@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200713074243.530-1-linux.amoon@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200720_035020_191742_520FDA6B X-CRM114-Status: GOOD ( 14.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Vinod Koul , Kukjin Kim , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 13, 2020 at 07:42:43AM +0000, Anand Moon wrote: > Instead of a busy waiting while loop using udelay > use readl_poll_timeout function to check the condition > is met or timeout occurs in crport_handshake function. > readl_poll_timeout is called in non atomic context so > it safe to sleep until the condition is met. > > Fixes: d8c80bb3b55b ("phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800") There is no bug in original code so Fixes tag is not appropriate. Remove it please. Best regards, Krzysztof > Signed-off-by: Anand Moon > --- > Changes v4: > Rebased on to of patch [0] https://patchwork.kernel.org/patch/11651673/ > --Fix the commit message. > --Fix the error timeout condition for -ETIMEDOUT > --- > Changes v3: > --Fix the commit message. > --Drop the variable, used the value directly. > Changes v2: > --used the default timeout values. > --Added missing Fixed tags. > --- > drivers/phy/samsung/phy-exynos5-usbdrd.c | 39 ++++++++---------------- > 1 file changed, 12 insertions(+), 27 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel