From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B08D5C433DF for ; Mon, 20 Jul 2020 11:12:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D1B22073A for ; Mon, 20 Jul 2020 11:12:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2rlTV/bP"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="S2rvxzOt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D1B22073A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=92qFJMbd74NSeUsO41Jf+0DyA08Fiq+qHRl7JmBafik=; b=2rlTV/bPvPwaUgKJ3NBs6aGA0 5ndiohTc/CSHAmbwhh63EnlrATisIGOWn9UcsIgoUG2/53j3Vj5ck3aTrJbBthYlOG2DhYn1oGSpj NjOBpv7Z4FFF1pG44vsV1PJpr6ENBlBP+Laevn+JGPcEY+uXr4RS6Dj59ks2qOzB//8DyR4sQXOXK wg5O5WSAKWbrS/cT7scbPhFUJz1rq7ONw6EJs1aQN/p4gZgluPcS/CVbxr6wdZ6I9qJCgfq0fDjTo WPKwyuYTOEKh7TBOt5EmV9Tc8YFH+W/9S1t8OVKiD08SjsElK+xeo+HFx/1lZN+Zwj/WuNASqsYDM TupAH1VjA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxThd-0000Dh-MX; Mon, 20 Jul 2020 11:11:25 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxThb-0000D4-Bg for linux-arm-kernel@lists.infradead.org; Mon, 20 Jul 2020 11:11:24 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1EF952073A; Mon, 20 Jul 2020 11:11:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595243482; bh=oVyIzYwCQBW5SyCkeejp0Vu+XeorkqSTvfQGJPfw4nU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S2rvxzOtDaZhYo7kOCgH4x/FJzQ7OzhcpPNMJ2cUoW4oUTosW/clma/lHEJ3eO95O XcCnldggXNdChmdeCES2GQpBxI5kSPfTxZ9HVS/2r/Yl8uyAWt74MGgOls9wq3ps2D dko+dlPn3RlY+pL0Tf+44tlOReoCVMra4yD4otbc= Date: Mon, 20 Jul 2020 12:11:17 +0100 From: Will Deacon To: Jean-Philippe Brucker Subject: Re: [PATCH v8 00/12] iommu: Shared Virtual Addressing for SMMUv3 (PT sharing part) Message-ID: <20200720111116.GE11516@willie-the-truck> References: <20200618155125.1548969-1-jean-philippe@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200618155125.1548969-1-jean-philippe@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200720_071123_515195_5CCD88FF X-CRM114-Status: GOOD ( 17.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fenghua.yu@intel.com, jacob.jun.pan@linux.intel.com, catalin.marinas@arm.com, joro@8bytes.org, zhengxiang9@huawei.com, hch@infradead.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Jonathan.Cameron@huawei.com, zhangfei.gao@linaro.org, robin.murphy@arm.com, xuzaibo@huawei.com, linux-arm-kernel@lists.infradead.org, baolu.lu@linux.intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 18, 2020 at 05:51:13PM +0200, Jean-Philippe Brucker wrote: > Since v7 [1], I split the series into three parts to ease review. This > first one adds page table sharing to the SMMUv3 driver. The second one > adds support for I/O page faults through PRI and Stall, and the last one > adds additional and optional features (DVM, VHE and HTTU). SVA needs the > three parts to work. No significant change apart from that, I just > addressed the previous comments. > > I'd rather everything went through the IOMMU tree but I'm assuming patch > 1 will also go through the x86 tree as part of [2]. It is definitely > required by patch 3 which is required by patch 11. I don't know how this > kind of conflict is usually resolved, but if it's a problem I could > further shrink the series to only patches 4-10 this cycle. Modulo my review comments, I think most of this looks alright from the SMMU side. However, I would really like it if the SVA driver parts could be moved into a separate file (e.g. arm-smmu-v3-sva.c), with a separate config option (dependent on the current one, so you can easily build a driver without SVA support). Does that sound remotely feasible? If so, I think it would really help in terms of maintainability, since the SVA model is really all about the mm, whereas the driver model is all about the device. This makes it really hard to read when you have to keep working out whether the current 'handle' is an mm_struct or an arm_smmu_device. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel