From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D279FC433EA for ; Tue, 21 Jul 2020 08:06:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1DBD20B1F for ; Tue, 21 Jul 2020 08:06:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bMsFnXei" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1DBD20B1F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fm2u4JO/v57cx8Zi3Xx9alKL0P8iqRINugYxmtoqO6o=; b=bMsFnXeiUHgLd4pgO/4BsxOgM gjc3AMUWVRr4HlHoX+RtQZ+Vy7yTGrByE7NMM/TzquxNp20YH3iyD6F/9shqO+IDvq6oQftCydfCl /nqD500v3q/qzliJsE0k2AB0IEd0R57ceQt3l7Yo7s63jhiBC40xL/Dx0DNSzUtyVd+6sYNJ1/d1d PPpTqnngHCnlxoCZl277DaPhtlsRyC+8tv1vJ0mIZ/tSHvZt1yWR772WnCyR1FO8QiaI1ZtrId4+A Zcje+9Sm3CvdziDVZmQhMCQ10mK+nrEP2YZYFJwfUmeF7c1ulIMsP7xIYE8j7XZxJcqOuDXr6OyrP XaMVkKHdQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxnGc-0000HE-1w; Tue, 21 Jul 2020 08:04:50 +0000 Received: from mail-wm1-f66.google.com ([209.85.128.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxnGZ-0000Ce-U7 for linux-arm-kernel@lists.infradead.org; Tue, 21 Jul 2020 08:04:48 +0000 Received: by mail-wm1-f66.google.com with SMTP id 22so1865415wmg.1 for ; Tue, 21 Jul 2020 01:04:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=syvFVe39WCS6I7HZqBbb+16Wl3B+m141J405QHoInHE=; b=YJqewda7kWhCxiqDlxzrvb22/Sv0q6ZmMcsHe9Dt7S++aE8QAOw1H18R+63NcKE6YQ JYi1KZCFPTigrYhrpavdzF8uT3FPEckT8vgIbXAu/qOUG96OTdk++kfT8qzlIadIh8HY KxpOBU4Voy5C02sd//L3YiJ6qJSiXhZBz3OtKwgDzrRYD2bM3Z9x1LWTMARJfVPj/Vy3 N4pu76xHVodHaw4MOLnAW64yQM1KdKqDEns2WW23CoXEfPIEGQV2/Wa8NaXh0AhygbvN jlxePxsDdrIYXm0UHBB7sMyUJZnO2Rlrmtcm8u+DoNHkj/GS0RVHIZzLEfvj+DKh8KUj lsPw== X-Gm-Message-State: AOAM530yFRmbRRr9KJC5KKqASaltVScpCNxsXP2El9WHMiNNXPHtDpjO 0cFbH1X+O41lUNXbVqHa03Q= X-Google-Smtp-Source: ABdhPJxda9SdlT7pF9+Os3z3GaDcUTXtBao7aheqKIsfkWKfKAqh6bpMotyBzTDIkJgsfF7Wf+I2vw== X-Received: by 2002:a7b:cb92:: with SMTP id m18mr2786559wmi.94.1595318684880; Tue, 21 Jul 2020 01:04:44 -0700 (PDT) Received: from kozik-lap ([194.230.155.200]) by smtp.googlemail.com with ESMTPSA id u65sm2545294wmg.5.2020.07.21.01.04.43 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 21 Jul 2020 01:04:44 -0700 (PDT) Date: Tue, 21 Jul 2020 10:04:42 +0200 From: Krzysztof Kozlowski To: Tamseel Shams Subject: Re: [PATCH v4] serial: samsung: change to platform_get_irq_optional Message-ID: <20200721080442.GA6580@kozik-lap> References: <20200713135531.68583-1-m.shams@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200713135531.68583-1-m.shams@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200721_040447_984321_A5D20098 X-CRM114-Status: GOOD ( 12.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, kgene@kernel.org, linux-serial@vger.kernel.org, jslaby@suse.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 13, 2020 at 07:25:31PM +0530, Tamseel Shams wrote: > In few older Samsung SoCs like s3c2410, s3c2412 > and s3c2440, UART IP is having 2 interrupt lines. > However, in other SoCs like s3c6400, s5pv210, > exynos5433, and exynos4210 UART is having only 1 > interrupt line. Due to this, "platform_get_irq(platdev, 1)" > call in the driver gives the following false-positive error: > "IRQ index 1 not found" on recent platforms. > > This patch replaces the platform_get_irq() call with > platform_get_irq_optional() and hence avoiding the > false-positive error. The error is not a false positive on S3C platforms, but a real error. The existing code did not handle missing TX IRQ but at least printed a message. Your change hides the message. The real problem here is a missing error handling for TX interrupt. Solving this one, would solve also false-positive error message on newer SoCs. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel