From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B73EC433E3 for ; Tue, 21 Jul 2020 15:57:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CA1620720 for ; Tue, 21 Jul 2020 15:57:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eFchovlh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0CA1620720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DhdjOktpe16waqeCYOxddTx0JU3YkJDymzZajZ1Qv5Y=; b=eFchovlh8iZLec58JPL8OSwOL 8qqZdSIY6MvnFHHZCZa5mXoYXrNgu3ulezTUUG8kAU5ZJQ4nwoxeP2bOFR4BmLL22R29rew96pFdx Npuzq35RIk1W8/P34wGVW5TEXfzfUgAtxPpb986wHthTtPZluHFjP5rff/wIQIvzd1mnSYGbxEtsZ yeVIdScYpk3/gPOtQq32DaLyN9ve+jRx4ENVxOXYp0Py8Ql9iVUmPMaCP2pKoDSTRh88KQPW1T2Jr OoaY3AOj7OI3z1Zxc5BbZE+DhSS/aCrmyCTXnwiIkoy22TKWR+GJ6XVs9LziipnmKwwE3xxx532/c L9fN/WywA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxucX-0000Dl-Bi; Tue, 21 Jul 2020 15:55:57 +0000 Received: from mail-il1-f196.google.com ([209.85.166.196]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxucV-0000DK-4G for linux-arm-kernel@lists.infradead.org; Tue, 21 Jul 2020 15:55:56 +0000 Received: by mail-il1-f196.google.com with SMTP id p15so16759135ilh.13 for ; Tue, 21 Jul 2020 08:55:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dvlYko5OfIP8lrI8XOGQfnCLndyt/xqnxyajLZzgv3s=; b=Gm6Yp4eBt+SqJdS/HNp5Nf+TfoegIY9eDU/0xjajN96EAcmOClP0ATIDRMDlx9dkML 7z2FZ15mueg0cNOrkA3dvDk2IvL5sYt/Ks6TgHEjCFKWfRhh0VIG78N3KYmt1at5TEJH hs04+ZqORKOKcddV423KYbrWzxlgSYtuHw+LnqQATdp9L+IHKmG9vPv6kaJvw+1QoSVo P0D98okKHnog1I4qxnpsy38s13k9FTErTpjafzlvyUUVYjhCQulG+cR/Gq4SwxNrpPIg 5VaER6YVczP7upgBM4eXyvZsiUr1OJu/2gYnJ6L+tFAYMtpxDfwr7Bf/k9g+CgyJqhkE 4iTA== X-Gm-Message-State: AOAM533ggZWyqnogd6G0XUNLgcTHOb92edID7iliTPZH9R6yt0PbNNP4 9PcaEOnDXh6bFQPNdd5Bm7GyRL4GFA== X-Google-Smtp-Source: ABdhPJxgdXoGBuEtLkr77THt9WevERX8Ux/6Vn1A2GflALoOmLd+imCojCPGR8p+QhfrC+vpz7b1Pg== X-Received: by 2002:a92:8492:: with SMTP id y18mr26530282ilk.27.1595346954188; Tue, 21 Jul 2020 08:55:54 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id i12sm11219930ioi.48.2020.07.21.08.55.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2020 08:55:52 -0700 (PDT) Received: (nullmailer pid 365901 invoked by uid 1000); Tue, 21 Jul 2020 15:55:50 -0000 Date: Tue, 21 Jul 2020 09:55:50 -0600 From: Rob Herring To: Lokesh Vutla Subject: Re: [PATCH v2 5/9] dt-bindings: irqchip: Convert ti,sci-intr bindings to yaml Message-ID: <20200721155550.GA358222@bogus> References: <20200721061007.28324-1-lokeshvutla@ti.com> <20200721061007.28324-6-lokeshvutla@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200721061007.28324-6-lokeshvutla@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200721_115555_197269_1D8F345D X-CRM114-Status: GOOD ( 28.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Peter Ujfalusi , Grygorii Strashko , Device Tree Mailing List , Marc Zyngier , Sekhar Nori , Tero Kristo , Santosh Shilimkar , Thomas Gleixner , Linux ARM Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 21, 2020 at 11:40:03AM +0530, Lokesh Vutla wrote: > In order to automate the verification of DT nodes convert > ti,sci-intr.txt ti,sci-intr.yaml. > > Signed-off-by: Lokesh Vutla > --- > .../interrupt-controller/ti,sci-intr.txt | 83 ------------- > .../interrupt-controller/ti,sci-intr.yaml | 113 ++++++++++++++++++ > MAINTAINERS | 2 +- > 3 files changed, 114 insertions(+), 84 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.yaml > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt b/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt > deleted file mode 100644 > index 8b56b2de1c73..000000000000 > --- a/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt > +++ /dev/null > @@ -1,83 +0,0 @@ > -Texas Instruments K3 Interrupt Router > -===================================== > - > -The Interrupt Router (INTR) module provides a mechanism to mux M > -interrupt inputs to N interrupt outputs, where all M inputs are selectable > -to be driven per N output. An Interrupt Router can either handle edge triggered > -or level triggered interrupts and that is fixed in hardware. > - > - Interrupt Router > - +----------------------+ > - | Inputs Outputs | > - +-------+ | +------+ +-----+ | > - | GPIO |----------->| | irq0 | | 0 | | Host IRQ > - +-------+ | +------+ +-----+ | controller > - | . . | +-------+ > - +-------+ | . . |----->| IRQ | > - | INTA |----------->| . . | +-------+ > - +-------+ | . +-----+ | > - | +------+ | N | | > - | | irqM | +-----+ | > - | +------+ | > - | | > - +----------------------+ > - > -There is one register per output (MUXCNTL_N) that controls the selection. > -Configuration of these MUXCNTL_N registers is done by a system controller > -(like the Device Memory and Security Controller on K3 AM654 SoC). System > -controller will keep track of the used and unused registers within the Router. > -Driver should request the system controller to get the range of GIC IRQs > -assigned to the requesting hosts. It is the drivers responsibility to keep > -track of Host IRQs. > - > -Communication between the host processor running an OS and the system > -controller happens through a protocol called TI System Control Interface > -(TISCI protocol). For more details refer: > -Documentation/devicetree/bindings/arm/keystone/ti,sci.txt > - > -TISCI Interrupt Router Node: > ----------------------------- > -Required Properties: > -- compatible: Must be "ti,sci-intr". > -- ti,intr-trigger-type: Should be one of the following: > - 1: If intr supports edge triggered interrupts. > - 4: If intr supports level triggered interrupts. > -- interrupt-controller: Identifies the node as an interrupt controller > -- #interrupt-cells: Specifies the number of cells needed to encode an > - interrupt source. The value should be 1. > - First cell should contain interrupt router input number > - as specified by hardware. > -- ti,sci: Phandle to TI-SCI compatible System controller node. > -- ti,sci-dev-id: TISCI device id of interrupt controller. > -- ti,interrupt-ranges: Set of triplets containing ranges that convert > - the INTR output interrupt numbers to parent's > - interrupt number. Each triplet has following entries: > - - First entry specifies the base for intr output irq > - - Second entry specifies the base for parent irqs > - - Third entry specifies the limit > - > -For more details on TISCI IRQ resource management refer: > -http://downloads.ti.com/tisci/esd/latest/2_tisci_msgs/rm/rm_irq.html > - > -Example: > --------- > -The following example demonstrates both interrupt router node and the consumer > -node(main gpio) on the AM654 SoC: > - > -main_gpio_intr: interrupt-controller0 { > - compatible = "ti,sci-intr"; > - ti,intr-trigger-type = <1>; > - interrupt-controller; > - interrupt-parent = <&gic500>; > - #interrupt-cells = <1>; > - ti,sci = <&dmsc>; > - ti,sci-dev-id = <131>; > - ti,interrupt-ranges = <0 360 32>; > -}; > - > -main_gpio0: gpio@600000 { > - ... > - interrupt-parent = <&main_gpio_intr>; > - interrupts = <192>, <193>, <194>, <195>, <196>, <197>; > - ... > -}; > diff --git a/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.yaml b/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.yaml > new file mode 100644 > index 000000000000..fbc1e8631d6f > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.yaml > @@ -0,0 +1,113 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/interrupt-controller/ti,sci-intr.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments K3 Interrupt Router > + > +maintainers: > + - Lokesh Vutla > + > +allOf: > + - $ref: /schemas/interrupt-controller.yaml# Don't need this. It is selected by the node name. > + > +description: | > + The Interrupt Router (INTR) module provides a mechanism to mux M > + interrupt inputs to N interrupt outputs, where all M inputs are selectable > + to be driven per N output. An Interrupt Router can either handle edge > + triggered or level triggered interrupts and that is fixed in hardware. > + > + Interrupt Router > + +----------------------+ > + | Inputs Outputs | > + +-------+ | +------+ +-----+ | > + | GPIO |----------->| | irq0 | | 0 | | Host IRQ > + +-------+ | +------+ +-----+ | controller > + | . . | +-------+ > + +-------+ | . . |----->| IRQ | > + | INTA |----------->| . . | +-------+ > + +-------+ | . +-----+ | > + | +------+ | N | | > + | | irqM | +-----+ | > + | +------+ | > + | | > + +----------------------+ > + > + There is one register per output (MUXCNTL_N) that controls the selection. > + Configuration of these MUXCNTL_N registers is done by a system controller > + (like the Device Memory and Security Controller on K3 AM654 SoC). System > + controller will keep track of the used and unused registers within the Router. > + Driver should request the system controller to get the range of GIC IRQs > + assigned to the requesting hosts. It is the drivers responsibility to keep > + track of Host IRQs. > + > + Communication between the host processor running an OS and the system > + controller happens through a protocol called TI System Control Interface > + (TISCI protocol). > + > +properties: > + compatible: > + const: ti,sci-intr > + > + ti,intr-trigger-type: > + description: | > + Should be one of the following. > + 1 = If intr supports edge triggered interrupts. > + 4 = If intr supports level triggered interrupts. Looks like constraints. > + allOf: You can drop 'allOf' now. > + - $ref: /schemas/types.yaml#/definitions/uint32 > + > + interrupt-controller: true > + > + '#interrupt-cells': > + const: 1 > + description: | > + The 1st cell should contain interrupt router input hw number. > + > + ti,sci: > + description: phandle to TI-SCI compatible System controller node > + allOf: > + - $ref: /schemas/types.yaml#/definitions/phandle > + > + ti,sci-dev-id: > + description: TI-SCI device id of Interrupt Controller > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 Use the common definition Suman did. > + > + ti,interrupt-ranges: > + description: | > + Interrupt ranges that converts the INTR output hw irq numbers > + to parents's input interrupt numbers. > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32-matrix > + - items: > + items: > + - description: | > + "output_irq" specifies the base for intr output irq > + - description: | > + "parent's input irq" specifies the base for parent irq > + - description: | > + "limit" specifies the limit for translation > + > +required: > + - compatible > + - ti,intr-trigger-type > + - interrupt-controller > + - '#interrupt-cells' > + - ti,sci > + - ti,sci-dev-id > + - ti,interrupt-ranges > + > +examples: > + - | > + main_gpio_intr: interrupt-controller0 { > + compatible = "ti,sci-intr"; > + ti,intr-trigger-type = <1>; > + interrupt-controller; > + interrupt-parent = <&gic500>; > + #interrupt-cells = <1>; > + ti,sci = <&dmsc>; > + ti,sci-dev-id = <131>; > + ti,interrupt-ranges = <0 360 32>; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index d53db30d1365..2f18fbccd71a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -16905,7 +16905,7 @@ S: Maintained > F: Documentation/devicetree/bindings/arm/keystone/ti,sci.txt > F: Documentation/devicetree/bindings/clock/ti,sci-clk.txt > F: Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.txt > -F: Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt > +F: Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.yaml > F: Documentation/devicetree/bindings/reset/ti,sci-reset.txt > F: Documentation/devicetree/bindings/soc/ti/sci-pm-domain.txt > F: drivers/clk/keystone/sci-clk.c > -- > 2.27.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel