From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E47F4C433E2 for ; Wed, 22 Jul 2020 10:30:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B225820729 for ; Wed, 22 Jul 2020 10:30:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="soy6G0UE"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="0yFUs6b3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B225820729 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ncoLNlReOh81rejqp2RSfYqN+JRufFYRHIrE7Ltfl/w=; b=soy6G0UE7iqekmqAReoVwvfYD 2jsQuv/2VTRSYqJ/IqD2ZLzSLwFOpfgSbFfNQp85FlRY+JkQjvDzAZk0mZ6taePbNJ7P9PhvERzrl iVTuEDYdrv4hOgEeRlz0p7IBuMvJ6RwbuzifcpttDshtUIcOoyDyRBujyUUjfJU3m8TT5W97Yy4uJ LyO8bhNXHIEI7nY1e0gRtJKAE1WMOyc72kl1ARxqirMJB8jgnW6nb9O9nRo8NcyDX0onoUSNK30lH vHln7qa2oR5mPrj47nGRWiHQLNs/AXWJHI4Uq9KKzpgTk4025957Wr/cjjic5WopiSJ7sO+4prV3K FMpt7OwCQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyBzm-0006fA-Vp; Wed, 22 Jul 2020 10:29:07 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyBzj-0006eK-Do for linux-arm-kernel@lists.infradead.org; Wed, 22 Jul 2020 10:29:05 +0000 Received: from localhost (p54b33083.dip0.t-ipconnect.de [84.179.48.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 12AA320729; Wed, 22 Jul 2020 10:29:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595413742; bh=lTc4TRlHDScl5Z1G4HHxd8eHjd5BknTeB2jTOiImhU4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0yFUs6b3bNer+1h93+pB9OHGrqgmBCKXlv2B+Fr6ioy4KEsMc+q9WO1UkCQuNY/g2 J46BbsE3+n/aHgR7etj2QOZ2GUPn7abrI094s00GTr03+gp32yAmFM0ooFnIJ5dtRt MWbLN+pKd+robgVcRKusbrpCRzXO+MmWLzOPklcg= Date: Wed, 22 Jul 2020 12:29:00 +0200 From: Wolfram Sang To: Raviteja Narayanam Subject: Re: [PATCH 1/2] Revert "i2c: cadence: Fix the hold bit setting" Message-ID: <20200722102859.GI1030@ninjato> References: <1593784549-21489-1-git-send-email-raviteja.narayanam@xilinx.com> MIME-Version: 1.0 In-Reply-To: <1593784549-21489-1-git-send-email-raviteja.narayanam@xilinx.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200722_062904_639623_A3BDDA91 X-CRM114-Status: GOOD ( 16.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: git@xilinx.com, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, michal.simek@xilinx.com Content-Type: multipart/mixed; boundary="===============0004378291770847273==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0004378291770847273== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="BWWlCdgt6QLN7tv3" Content-Disposition: inline --BWWlCdgt6QLN7tv3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 03, 2020 at 07:25:49PM +0530, Raviteja Narayanam wrote: > This reverts commit d358def706880defa4c9e87381c5bf086a97d5f9. >=20 > There are two issues with "i2c: cadence: Fix the hold bit setting" commit. >=20 > 1. In case of combined message request from user space, when the HOLD > bit is cleared in cdns_i2c_mrecv function, a STOP condition is sent > on the bus even before the last message is started. This is because when > the HOLD bit is cleared, the FIFOS are empty and there is no pending > transfer. The STOP condition should occur only after the last message > is completed. >=20 > 2. The code added by the commit is redundant. Driver is handling the > setting/clearing of HOLD bit in right way before the commit. >=20 > The setting of HOLD bit based on 'bus_hold_flag' is taken care in > cdns_i2c_master_xfer function even before cdns_i2c_msend/cdns_i2c_recv > functions. >=20 > The clearing of HOLD bit is taken care at the end of cdns_i2c_msend and > cdns_i2c_recv functions based on bus_hold_flag and byte count. > Since clearing of HOLD bit is done after the slave address is written to > the register (writing to address register triggers the message transfer), > it is ensured that STOP condition occurs at the right time after > completion of the pending transfer (last message). >=20 > Signed-off-by: Raviteja Narayanam Applied to for-current, thanks! --BWWlCdgt6QLN7tv3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl8YFOsACgkQFA3kzBSg KbZT0BAAj7CTkxywHYj4mY+dcRZVfFPQUg5hgqR23yDUWFDdg7vy7tbjqUXHvnXh AtmREV11AUlyUbDjC+0nrC42HKxVd4BXfqSfXnMZ27jDZ8RVGrUBkfq2TTnaVrwn JYQSihhIojqqOWfVLWeCKjFoonrYCEUyEWucf6WGgFAm1A4+VKHwX74As9dlsRDL 5Tb8K3r33hC//HuuJbR30Vp1zVDH7jLj/Uv5fp+y8v5uFHc2bjYqN+2mSu6194YX yAbZejkFjqK5J7bxlLlM79lyNmMnjw6ahnus8+QP/FoN+/D8tpdqZJZMLz+Efgv+ wj+VmVmO7zWtoOg1jFTAserdcNJ4o+swCYP43Ur1fuECGZjWyOo/9KJoFWLBMPke 1EToZZLuQsLxOgeDf1wvb9KM5pPzDuAcSw5INuCHvTIhYxN8Gss8UmBEbykukUld JRBvDY3jhc8cgNRMhZnVa4yGPk4AVJU/AzhfUyjR7uUrqJGEmE4jMWljwmPTyrH1 vEMUUSlVDwxCd4eeWDJwdhK1+d29+RyH7Sr9m3LNGRmau569nnMJV79UUHO66oBv xzFS2maiwT7Fwv54PjqBKTULjD7Itnvs9/EERIKLtDp4yLEmreNV+3uiNy/RLm3s YbSc2UXp037LXDjIUJwn6WcYHtwfUmbwG/5j5CfGFkPY66l5Vt8= =iU1Q -----END PGP SIGNATURE----- --BWWlCdgt6QLN7tv3-- --===============0004378291770847273== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0004378291770847273==--