From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 487DDC433E3 for ; Wed, 22 Jul 2020 10:30:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 138C620771 for ; Wed, 22 Jul 2020 10:30:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PcewbW77"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="PMggXTyt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 138C620771 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hWkvpJkEVeGrL+ZpV+7/qc4+lo87TlSmm18Y6K+KGD0=; b=PcewbW77FsTXL/YoM9sHJtplM bQBHXuRTcfqUYzJWdWMebbCuKKWLLsmNXNUPh6ZKKNAI1iHD3obk4l+hVKm4m3gQjuWlm36cjwFFu 2WEnK37gi4itCrLdVQGT5At03qoAJPyw/fqMf18jjbUW1kxE7VXPczxG8omshPgsfvk3I4o3ZHdcS Dmclt4pag91P0NICrvererECBbcsGPdiSi5vpZFaNW+57kaNphmoUZ90ThTbVcEg2//kdO4G5MlLX PWus7DvtzuQfN4e9c/CDugVXbBeka7UCiCg6L4e0E+KmxjHPI7Kx70ISWC5gySf45k15citPXYzYA RIHRzmBjQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyC04-0006ig-9M; Wed, 22 Jul 2020 10:29:24 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyBzq-0006fy-3f for linux-arm-kernel@lists.infradead.org; Wed, 22 Jul 2020 10:29:11 +0000 Received: from localhost (p54b33083.dip0.t-ipconnect.de [84.179.48.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CC15E20729; Wed, 22 Jul 2020 10:29:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595413749; bh=KMLpaxcePCpXp4URNPpOHVjKKc7YKBwOyGmXdo5i96Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PMggXTytoMX2+ayoPs8fR6Re/9yytPEBRg2AWVXRH496o7Yc/Jl4Pc05AJTi2TvUI JqT+eGzcamn4d89RaQDf1rJZw+YxMKXtPPztmfHLgeGJAchlFdlBPvf+XoFvPXVMpV kfaqS2zfBzQENcOVSqbGwEoQuK7jPRLjMJBmayh4= Date: Wed, 22 Jul 2020 12:29:06 +0200 From: Wolfram Sang To: Raviteja Narayanam Subject: Re: [PATCH 2/2] i2c: cadence: Clear HOLD bit at correct time in Rx path Message-ID: <20200722102906.GJ1030@ninjato> References: <1593784572-21910-1-git-send-email-raviteja.narayanam@xilinx.com> MIME-Version: 1.0 In-Reply-To: <1593784572-21910-1-git-send-email-raviteja.narayanam@xilinx.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200722_062910_268366_499153F8 X-CRM114-Status: GOOD ( 14.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: git@xilinx.com, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, michal.simek@xilinx.com Content-Type: multipart/mixed; boundary="===============8972162082356548995==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8972162082356548995== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8tZVdKiiYitVG083" Content-Disposition: inline --8tZVdKiiYitVG083 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 03, 2020 at 07:26:12PM +0530, Raviteja Narayanam wrote: > There are few issues on Zynq SOC observed in the stress tests causing > timeout errors. Even though all the data is received, timeout error > is thrown. This is due to an IP bug in which the COMP bit in ISR is > not set at end of transfer and completion interrupt is not generated. >=20 > This bug is seen on Zynq platforms when the following condition occurs: > Master read & HOLD bit set & Transfer size register reaches '0'. >=20 > One workaround is to clear the HOLD bit before the transfer size > register reaches '0'. The current implementation checks for this at > the start of the loop and also only for less than FIFO DEPTH case > (ignoring the equal to case). >=20 > So clear the HOLD bit when the data yet to receive is less than or > equal to the FIFO DEPTH. This avoids the IP bug condition. >=20 > Signed-off-by: Raviteja Narayanam Applied to for-current, thanks! --8tZVdKiiYitVG083 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl8YFPIACgkQFA3kzBSg KbZ6gRAAk+U1RJWBmsO1kg17hPWLV4CKbeQwkokAO7OxQ+Xz4eMBTlAZX9T3vqh5 8bsrQ/oiFTFWqEaKrtkK2kgvUIZqOAwdmXKvEL676ft3cjjg/4oJjr/zfRZWhlq+ FrRHbVo+U1BjiuLmBm/D/hdR/p2AuekW899KrM/ZszFW5+RFcYQRoCF2eMwilLuH 5ZxHAdK66xbOof71C6jlsQOWpFUXDVjRN1Qy7k9iE7tpwscZ4YT/+IJk/h3dQFFH Mgrh05rH4z5vu7ED6Iu3WKjlG1+IUjPbBFB2Ay+Ulc2SZunLKHQw6oNzjp2LxyNu 1lRYwt4xCwkEe8eGXSM5gw+wcS+w0rnZMtDaUWyxzQTCDouykj49Kbt/f8jxawIN 6HVGMZeJvUSioiXEOSOPBtLe9Ra3Wd3FI7G0UfDJAhsBKX2Xn2Jt+HsPs0X2Ey3o cU7xHaIK+oI66RLC+IWzXXXk4wOyBHVNRatacwRGNS9KBPpCDYlv7N5L0Y690y4N FO5iSKxYJKA5k2MypsBLHG/2aiK6RPEYOi2GkNPmEx6wKOuniPtonsOU80Vwrb7m f+DMNmEkiEniGihZGEj4vLwI4ZMgH9JVLKzj5S6ygu7wPqnYEdxZXUYossBmR+rk gt8C1EpIJvFlFioaTSMIR/sdNr5wnuGPpJ+68V+WnPwAwtoSDjA= =uPhR -----END PGP SIGNATURE----- --8tZVdKiiYitVG083-- --===============8972162082356548995== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8972162082356548995==--