From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC1EBC433EB for ; Thu, 23 Jul 2020 15:52:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A85182071A for ; Thu, 23 Jul 2020 15:52:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0U2KX9s2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A85182071A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GgEFHaAd97+8xLuU9q9xJXDoBg1wmidcElzP9Afr4uU=; b=0U2KX9s2us7z7wAPaqvKad5Wn 2pB5C5YCWuICAcikaBMsdRsKc4v1c+kGcOqmNfhlxffmZzOm8to7Vf9bOFPikA9ern0QQOMsRH3cR ndim9xrTEnCMI7i9MPA6NMIQndgoy5Br2dA+FpTTMB11c8/D6KcgS+lsZ7pPPbHCXgD6ZeN0XoKKm VbLupoDXHWRNeeUAsnm38wAta1vM0INlx9lFmC1hmNTg/jiZrqogXXD3pHUAdM4ZroQ2l7ryxPjL6 QP27nLA7pwZhlNSdjTlFT7jHpIBi9RHANXR15mdmZTkM73eq5E1D1t8O+jFLWuvuJG+lomD1sadJY eVbSgutkw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jydUS-0006JX-9E; Thu, 23 Jul 2020 15:50:36 +0000 Received: from mail-io1-f67.google.com ([209.85.166.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jydUP-0006Hc-6p; Thu, 23 Jul 2020 15:50:34 +0000 Received: by mail-io1-f67.google.com with SMTP id v6so6753135iob.4; Thu, 23 Jul 2020 08:50:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Fl2ka9nuUa2SJkSyRR1vF0gTmehADr0HvHCO5Jzmn5U=; b=qdVLgWlGc1Ybt8LGcm9HaviCzIzqJYU7vJ3GagPb2PvZao0vTrO9iLSQqtXL8zuUuQ 0DCRMyng4eev0Udu7CCkqXAH2KStjkriBKq1lPFV9ClDZGUkGC3AVO7dyo+lOjbzHWGE WG4Cvz9dFvJQ2DKaTAC9GhX91utP1UmJEGx2J1QVlW8G3tE0XMqavHgebM62Tk/1+CmS KL1Z65aHEnhvFDiiBSbKmMlVGQrcqF87OQQgibXIOEy3Ed/7GN38CkWwmc6fqsG1bjZg WbTYgzKl1omF1F3Dnp/lHqTJmZJtlauCOp6RiES2YortfUjNPdBbyE9TfObKb8KztcST DfmA== X-Gm-Message-State: AOAM5313mKP1Xuq2Air931aVtQ4zZ+SCIsDNljZ47pN7ZpTBnBV2RrDT P5PeHtl1uGpP1M222KF6ZQ== X-Google-Smtp-Source: ABdhPJzPPDcWqfpQgBQbjNBsc9IEoz9TJucBz+NpyZYMuHEgMCE2vtozhhrLxjbBv746yY3RWvDeHQ== X-Received: by 2002:a6b:5c0a:: with SMTP id z10mr5518781ioh.131.1595519430836; Thu, 23 Jul 2020 08:50:30 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id p20sm1159991iod.27.2020.07.23.08.50.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 08:50:30 -0700 (PDT) Received: (nullmailer pid 435445 invoked by uid 1000); Thu, 23 Jul 2020 15:50:28 -0000 Date: Thu, 23 Jul 2020 09:50:28 -0600 From: Rob Herring To: Jagan Teki Subject: Re: [PATCH v3 1/4] dt-bindings: arm: rockchip: Update ROCKPi 4 binding Message-ID: <20200723155028.GA427258@bogus> References: <20200723090210.41201-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200723090210.41201-1-jagan@amarulasolutions.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200723_115033_265490_E7A01DBC X-CRM114-Status: GOOD ( 17.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Heiko Stuebner , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Suniel Mahesh , Michael Trimarchi , linux-amarula , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 23, 2020 at 02:32:07PM +0530, Jagan Teki wrote: > ROCKPi 4 has 3 variants of hardware platforms called > ROCKPi 4A, 4B, and 4C. > > - ROCKPi 4A has no Wif/BT. > - ROCKPi 4B has AP6256 Wifi/BT, PoE. > - ROCKPi 4C has AP6256 Wifi/BT, PoE, miniDP, USB Host enabled > GPIO pin change compared to 4B, 4C > > So, update the existing ROCKPi 4 binding to support > ROCKPi 4A/B/C hardware platforms. > > Signed-off-by: Jagan Teki > --- > Changes for v3: > - new patch > > Documentation/devicetree/bindings/arm/rockchip.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index db2e35796795..e6f656b0bd56 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -430,8 +430,12 @@ properties: > - const: radxa,rock > - const: rockchip,rk3188 > > - - description: Radxa ROCK Pi 4 > + - description: Radxa ROCK Pi 4A/B/C > items: > + - enum: > + - const: radxa,rockpi4a > + - const: radxa,rockpi4b > + - const: radxa,rockpi4c > - const: radxa,rockpi4 radxa,rockpi4 already meant 'ROCKPi 4A' and should continue to do so. Just add 4B and 4C strings. It's up to you if they should be backwards compatible with 'radxa,rockpi4' (meaning 4A), but I'd guess not unless it's just a board pop option. > - const: rockchip,rk3399 > > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel