From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADB6CC433E8 for ; Thu, 23 Jul 2020 15:53:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A7842071A for ; Thu, 23 Jul 2020 15:53:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xFWCJ2JR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A7842071A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xP4KComqDrF/GrxwVp/HhrRMjWiKuGz+ayDCdiTnfEk=; b=xFWCJ2JRu2Icdbk7ubh50XcXu Wm0gzu+JFgU1ieO2d8bx7TZP3LVEYOcBTdktlY8HKfMGYkOk3cz2QKK5Q4zOTbiSGLSzn0Hq7fdKP Ys63S1XdiPwBSHthF6HlmUI4SSEd/ya5VhczFHA7WlmQog8GYeHGYTESd7PpCdmxid5AE3K81k2th TyNwkpAyujW22Nt1aZAmOFos/ycAHWtgumTMDUgWL3WhRiwuUxRnWka62xOy9N90g65jwsFye+ncV m9RZKT4GkUAg3/q7lKZBdtNranSkOmMoD2E6kbFf8z8EXmdnEDDnEdig9Tn2NRjtUuU3T+AtckWlD 2Sf86UUxw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jydVl-0006dX-OY; Thu, 23 Jul 2020 15:51:57 +0000 Received: from mail-io1-f67.google.com ([209.85.166.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jydVh-0006cR-Sx; Thu, 23 Jul 2020 15:51:54 +0000 Received: by mail-io1-f67.google.com with SMTP id t131so6744759iod.3; Thu, 23 Jul 2020 08:51:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NbSdHK3uJS+qqL6vrqQbHy+2Anft4wIWgOtjJFjijYg=; b=NmMEYvdkGgQPhsyFUDrbexT7kxhpulMjouNu+XJ00z0WtDedfNUYmEq8tlHKcNSFKR aeU32AvZUKWRRSVfSfPYcvoaVhGILXmr6mqFA74eb7w4VbLiwHP4PjL0rS2Dbr+vQSdZ WIndZWu8rU7fZwvoUrmRsXJ4FSh8W+eJ6PaIiZpayn98FKOhJJRXoelj6/oNXp8uSTLx Bus80X+WgWgp77n6AmOqCO/zbgQp05Scg6BwKTcFm4KeOdc0iFplkwodTBnyoQvZQWDF QqufX16xvQA2T3rVhcjwP4D5Xzb4FoezKqOc40Y9L2zJRGhxb2qunmeuvlSaezn0oJtt mBxQ== X-Gm-Message-State: AOAM5334/Todbm6WLnrvr8qKQHKT5dIptZVFdJWu2sALYNQrYppX8pjY viHcduGNnG1DIADoJTw0yXrqWZTSTA== X-Google-Smtp-Source: ABdhPJzIGK0WM0f/vwsNRxuo8j8mErlyCWIqu1SV6ppAJYTQ2bSFq72hCWI+k2Pgg/xIlXhZlztyrg== X-Received: by 2002:a5d:8ac3:: with SMTP id e3mr5728872iot.9.1595519513344; Thu, 23 Jul 2020 08:51:53 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id 5sm1633003ion.7.2020.07.23.08.51.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 08:51:52 -0700 (PDT) Received: (nullmailer pid 437306 invoked by uid 1000); Thu, 23 Jul 2020 15:51:49 -0000 Date: Thu, 23 Jul 2020 09:51:49 -0600 From: Rob Herring To: Jagan Teki Subject: Re: [PATCH v3 1/4] dt-bindings: arm: rockchip: Update ROCKPi 4 binding Message-ID: <20200723155149.GA436360@bogus> References: <20200723090210.41201-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200723090210.41201-1-jagan@amarulasolutions.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200723_115153_954400_6919C4C1 X-CRM114-Status: GOOD ( 13.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Heiko Stuebner , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , Suniel Mahesh , Michael Trimarchi , linux-amarula , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 23 Jul 2020 14:32:07 +0530, Jagan Teki wrote: > ROCKPi 4 has 3 variants of hardware platforms called > ROCKPi 4A, 4B, and 4C. > > - ROCKPi 4A has no Wif/BT. > - ROCKPi 4B has AP6256 Wifi/BT, PoE. > - ROCKPi 4C has AP6256 Wifi/BT, PoE, miniDP, USB Host enabled > GPIO pin change compared to 4B, 4C > > So, update the existing ROCKPi 4 binding to support > ROCKPi 4A/B/C hardware platforms. > > Signed-off-by: Jagan Teki > --- > Changes for v3: > - new patch > > Documentation/devicetree/bindings/arm/rockchip.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > My bot found errors running 'make dt_binding_check' on your patch: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/rockchip.yaml: properties:compatible:oneOf:48:items: [{'enum': [{'const': 'radxa,rockpi4a'}, {'const': 'radxa,rockpi4b'}, {'const': 'radxa,rockpi4c'}]}, {'const': 'radxa,rockpi4'}, {'const': 'rockchip,rk3399'}] is not valid under any of the given schemas (Possible causes of the failure): /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/rockchip.yaml: properties:compatible:oneOf:48:items: [{'enum': [{'const': 'radxa,rockpi4a'}, {'const': 'radxa,rockpi4b'}, {'const': 'radxa,rockpi4c'}]}, {'const': 'radxa,rockpi4'}, {'const': 'rockchip,rk3399'}] is not of type 'object' /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/rockchip.yaml: properties:compatible:oneOf:48:items:0:enum:0: {'const': 'radxa,rockpi4a'} is not of type 'string' /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/rockchip.yaml: properties:compatible:oneOf:48:items:0:enum:1: {'const': 'radxa,rockpi4b'} is not of type 'string' /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/rockchip.yaml: properties:compatible:oneOf:48:items:0:enum:2: {'const': 'radxa,rockpi4c'} is not of type 'string' Documentation/devicetree/bindings/Makefile:20: recipe for target 'Documentation/devicetree/bindings/arm/rockchip.example.dts' failed make[1]: *** [Documentation/devicetree/bindings/arm/rockchip.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs.... /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/rockchip.yaml: ignoring, error in schema: properties: compatible: oneOf: 48: items warning: no schema found in file: ./Documentation/devicetree/bindings/arm/rockchip.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/rockchip.yaml: ignoring, error in schema: properties: compatible: oneOf: 48: items warning: no schema found in file: ./Documentation/devicetree/bindings/arm/rockchip.yaml Makefile:1347: recipe for target 'dt_binding_check' failed make: *** [dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1334641 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel