From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Gavin Shan <gshan@redhat.com>
Cc: mark.rutland@arm.com, catalin.marinas@arm.com,
james.morse@arm.com, shan.gavin@gmail.com, will@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 09/17] drivers/firmware/sdei: Remove while loop in sdei_event_unregister()
Date: Thu, 23 Jul 2020 16:51:07 +0100 [thread overview]
Message-ID: <20200723165107.00001ed7@Huawei.com> (raw)
In-Reply-To: <20200722095740.28560-10-gshan@redhat.com>
On Wed, 22 Jul 2020 19:57:32 +1000
Gavin Shan <gshan@redhat.com> wrote:
> This removes the unnecessary while loop in sdei_event_unregister().
> This shouldn't cause any functional changes.
>
> Signed-off-by: Gavin Shan <gshan@redhat.com>
> ---
> v2: Derived from "drivers/firmware/sdei: Drop unnecessary while loop"
> ---
> drivers/firmware/arm_sdei.c | 30 ++++++++++++++----------------
> 1 file changed, 14 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c
> index ab1088fbdd37..d03371161aaf 100644
> --- a/drivers/firmware/arm_sdei.c
> +++ b/drivers/firmware/arm_sdei.c
> @@ -491,26 +491,24 @@ int sdei_event_unregister(u32 event_num)
>
> mutex_lock(&sdei_events_lock);
> event = sdei_event_find(event_num);
> - do {
> - if (!event) {
> - pr_warn("Event %u not registered\n", event_num);
> - err = -ENOENT;
> - break;
> - }
> + if (!event) {
> + pr_warn("Event %u not registered\n", event_num);
> + err = -ENOENT;
> + goto out;
> + }
>
> - spin_lock(&sdei_list_lock);
> - event->reregister = false;
> - event->reenable = false;
> - spin_unlock(&sdei_list_lock);
> + spin_lock(&sdei_list_lock);
> + event->reregister = false;
> + event->reenable = false;
> + spin_unlock(&sdei_list_lock);
>
> - err = _sdei_event_unregister(event);
> - if (err)
> - break;
> + err = _sdei_event_unregister(event);
> + if (err)
> + goto out;
>
> - sdei_event_destroy(event);
> - } while (0);
> + sdei_event_destroy(event);
> +out:
As in previous I'd give the label a name to indicate there is still work
to be done.
> mutex_unlock(&sdei_events_lock);
> -
That whitespace is arguably slightly useful from a readability point of view.
I would leave it here.
> return err;
> }
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-23 15:53 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 9:57 [PATCH v2 00/17] Refactor SDEI client driver Gavin Shan
2020-07-22 9:57 ` [PATCH v2 01/17] drivers/firmware/sdei: Remove sdei_is_err() Gavin Shan
2020-07-22 9:57 ` [PATCH v2 02/17] drivers/firmware/sdei: Common block for failing path in sdei_event_create() Gavin Shan
2020-07-22 9:57 ` [PATCH v2 03/17] drivers/firmware/sdei: Retrieve event number from event instance Gavin Shan
2020-07-22 9:57 ` [PATCH v2 04/17] drivers/firmware/sdei: Avoid nested statements in sdei_init() Gavin Shan
2020-07-22 9:57 ` [PATCH v2 05/17] drivers/firmware/sdei: Unregister driver on error " Gavin Shan
2020-07-22 9:57 ` [PATCH v2 06/17] drivers/firmware/sdei: Remove duplicate check in sdei_get_conduit() Gavin Shan
2020-07-22 9:57 ` [PATCH v2 07/17] drivers/firmware/sdei: Remove Drop redundant error message in sdei_probe() Gavin Shan
2020-07-22 9:57 ` [PATCH v2 08/17] drivers/firmware/sdei: Remove while loop in sdei_event_register() Gavin Shan
2020-07-22 9:57 ` [PATCH v2 09/17] drivers/firmware/sdei: Remove while loop in sdei_event_unregister() Gavin Shan
2020-07-23 15:51 ` Jonathan Cameron [this message]
2020-07-27 0:22 ` Gavin Shan
2020-07-22 9:57 ` [PATCH v2 10/17] drivers/firmware/sdei: Cleanup on cross call function Gavin Shan
2020-07-23 15:52 ` Jonathan Cameron
2020-07-27 0:33 ` Gavin Shan
2020-07-27 8:58 ` Jonathan Cameron
2020-07-27 9:45 ` Gavin Shan
2020-07-22 9:57 ` [PATCH v2 11/17] drivers/firmware/sdei: Introduce sdei_do_local_call() Gavin Shan
2020-07-23 15:25 ` Jonathan Cameron
2020-07-27 0:41 ` Gavin Shan
2020-07-22 9:57 ` [PATCH v2 12/17] drivers/firmware/sdei: Remove _sdei_event_register() Gavin Shan
2020-07-23 15:25 ` Jonathan Cameron
2020-07-27 0:42 ` Gavin Shan
2020-07-22 9:57 ` [PATCH v2 13/17] drivers/firmware/sdei: Remove _sdei_event_unregister() Gavin Shan
2020-07-22 9:57 ` [PATCH v2 14/17] drivers/firmware/sdei: Move struct sdei_event to header file Gavin Shan
2020-07-23 15:19 ` Jonathan Cameron
2020-07-27 0:46 ` Gavin Shan
2020-07-27 9:02 ` Jonathan Cameron
2020-07-27 9:59 ` Gavin Shan
2020-07-27 13:50 ` Jonathan Cameron
2020-07-28 2:52 ` Gavin Shan
2020-07-22 9:57 ` [PATCH v2 15/17] drivers/firmware/sdei: Identify event by struct sdei_event Gavin Shan
2020-07-22 9:57 ` [PATCH v2 16/17] drivers/firmware/sdei: Retrieve event signaled property on registration Gavin Shan
2020-07-23 15:24 ` Jonathan Cameron
2020-07-27 0:53 ` Gavin Shan
2020-07-27 9:04 ` Jonathan Cameron
2020-07-27 10:03 ` Gavin Shan
2020-07-27 13:56 ` Jonathan Cameron
2020-07-28 2:56 ` Gavin Shan
2020-07-22 9:57 ` [PATCH v2 17/17] drivers/firmware/sdei: Add sdei_event_get_info() Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723165107.00001ed7@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=catalin.marinas@arm.com \
--cc=gshan@redhat.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=shan.gavin@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).