From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D12E4C433EC for ; Thu, 23 Jul 2020 15:53:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E6D72071A for ; Thu, 23 Jul 2020 15:53:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HNuxcvX3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E6D72071A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=Huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DxPm/ydCcpobGvY5tmhtufZc2Yu1SEklMPXfrk9L7WQ=; b=HNuxcvX3ZR1jbh0qu8gvt4R4G KxXKmGSICu8VmmF0dsjE5zIXW4hIQ3vJIw9g6DLzWQb4d/BGTXsmBhv3oux5v4/1e14FA8M2+tl81 5yDCCHiC6xT2ZYDXHNiV/14/WpqQqirzottKLKRcpfaCzfuh9Njywg/NAOMxGeeWczGahYi9t6TdM Q0r7jUCexu7eiYtFv/SuMw6iUQVnVDeCIDslHABDIjgW81D9hVXvW7Wpd3Hd9dew+usxe4lrDbW4a 6ifO8pp94ZTL3Io0GGsegetUc2HCu5T8pXJgWz6+VJSIVQpMt3onk6+v8YfQ9nRNruv4PY9p8Jb3B +Ze0O9dfw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jydWI-0006pU-NR; Thu, 23 Jul 2020 15:52:30 +0000 Received: from lhrrgout.huawei.com ([185.176.76.210] helo=huawei.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jydWG-0006of-RH for linux-arm-kernel@lists.infradead.org; Thu, 23 Jul 2020 15:52:29 +0000 Received: from lhreml710-chm.china.huawei.com (unknown [172.18.7.106]) by Forcepoint Email with ESMTP id 7322FE3B6E2CE5845C3E; Thu, 23 Jul 2020 16:52:27 +0100 (IST) Received: from localhost (10.52.125.229) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Thu, 23 Jul 2020 16:52:27 +0100 Date: Thu, 23 Jul 2020 16:51:07 +0100 From: Jonathan Cameron To: Gavin Shan Subject: Re: [PATCH v2 09/17] drivers/firmware/sdei: Remove while loop in sdei_event_unregister() Message-ID: <20200723165107.00001ed7@Huawei.com> In-Reply-To: <20200722095740.28560-10-gshan@redhat.com> References: <20200722095740.28560-1-gshan@redhat.com> <20200722095740.28560-10-gshan@redhat.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.52.125.229] X-ClientProxiedBy: lhreml725-chm.china.huawei.com (10.201.108.76) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200723_115229_004256_C07D3355 X-CRM114-Status: GOOD ( 15.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, catalin.marinas@arm.com, james.morse@arm.com, shan.gavin@gmail.com, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 22 Jul 2020 19:57:32 +1000 Gavin Shan wrote: > This removes the unnecessary while loop in sdei_event_unregister(). > This shouldn't cause any functional changes. > > Signed-off-by: Gavin Shan > --- > v2: Derived from "drivers/firmware/sdei: Drop unnecessary while loop" > --- > drivers/firmware/arm_sdei.c | 30 ++++++++++++++---------------- > 1 file changed, 14 insertions(+), 16 deletions(-) > > diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c > index ab1088fbdd37..d03371161aaf 100644 > --- a/drivers/firmware/arm_sdei.c > +++ b/drivers/firmware/arm_sdei.c > @@ -491,26 +491,24 @@ int sdei_event_unregister(u32 event_num) > > mutex_lock(&sdei_events_lock); > event = sdei_event_find(event_num); > - do { > - if (!event) { > - pr_warn("Event %u not registered\n", event_num); > - err = -ENOENT; > - break; > - } > + if (!event) { > + pr_warn("Event %u not registered\n", event_num); > + err = -ENOENT; > + goto out; > + } > > - spin_lock(&sdei_list_lock); > - event->reregister = false; > - event->reenable = false; > - spin_unlock(&sdei_list_lock); > + spin_lock(&sdei_list_lock); > + event->reregister = false; > + event->reenable = false; > + spin_unlock(&sdei_list_lock); > > - err = _sdei_event_unregister(event); > - if (err) > - break; > + err = _sdei_event_unregister(event); > + if (err) > + goto out; > > - sdei_event_destroy(event); > - } while (0); > + sdei_event_destroy(event); > +out: As in previous I'd give the label a name to indicate there is still work to be done. > mutex_unlock(&sdei_events_lock); > - That whitespace is arguably slightly useful from a readability point of view. I would leave it here. > return err; > } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel