From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 713EFC433E0 for ; Thu, 23 Jul 2020 15:55:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3905320674 for ; Thu, 23 Jul 2020 15:55:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="laJ43AQi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3905320674 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=Huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zpTUe0JUXl+7eSZoItMFfT7M1sj9fsQHa+Xx3LrjVeg=; b=laJ43AQiJ4aCsu76SRTASBfuc tG7EuBpzx3sfKrmBH8CqVRehUghm00i/iA8SlCYMyHbDbqWoF/9/OYkk8o8TAs+CDmlKxVeHOdVol XASUjU9u4jCDLj+BCRx1m/tLJZ8qvLuR9g1U2WHVf6hjr77pKwMt0VxjAydSw9ySXOBjCPbDH07HS /XD59WL33o9grsnK0Cw0SKCknKioRylnltmAc1wiHAlIBmcVALHNcFeNUGWba7T/CqaQrXx3MXw2E vl+qKwjeS5jcYgn9gsiVMhSFgkRpYHuxWiG2Ms0cpq2c778t2GuWNB/Ebcbl6x4RKXkNrTcPWfwtp Y2ximpY8w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jydXX-0007DY-RG; Thu, 23 Jul 2020 15:53:47 +0000 Received: from lhrrgout.huawei.com ([185.176.76.210] helo=huawei.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jydXT-0007C7-MJ for linux-arm-kernel@lists.infradead.org; Thu, 23 Jul 2020 15:53:44 +0000 Received: from lhreml710-chm.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id CE080937813327AC62F9; Thu, 23 Jul 2020 16:53:42 +0100 (IST) Received: from localhost (10.52.125.229) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Thu, 23 Jul 2020 16:53:42 +0100 Date: Thu, 23 Jul 2020 16:52:22 +0100 From: Jonathan Cameron To: Gavin Shan Subject: Re: [PATCH v2 10/17] drivers/firmware/sdei: Cleanup on cross call function Message-ID: <20200723165222.0000770e@Huawei.com> In-Reply-To: <20200722095740.28560-11-gshan@redhat.com> References: <20200722095740.28560-1-gshan@redhat.com> <20200722095740.28560-11-gshan@redhat.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.52.125.229] X-ClientProxiedBy: lhreml725-chm.china.huawei.com (10.201.108.76) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200723_115343_876305_4AF508B6 X-CRM114-Status: GOOD ( 17.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, catalin.marinas@arm.com, james.morse@arm.com, shan.gavin@gmail.com, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 22 Jul 2020 19:57:33 +1000 Gavin Shan wrote: > This applies cleanup on the corss call functions, no functional cross > changes is introduced: changes are introduced: > > * Cleanup struct sdei_crosscall_arg to use tab between fields > and their types Hmm. I guess there is a consistency argument for doing this but generally that one doesn't look like it actually has much benefit. > * Refactor CROSSCALL_INIT to use "do { ... } while (0)" to be > compatible with scripts/checkpatch.pl Good to tidy that up. > * Remove unnecessary space before @event in sdei_do_cross_call() Good change, but seems to have gotten lost in this patch. > > Signed-off-by: Gavin Shan > --- > v2: Drop changes to sdei_cross_call_return() > Remove unnecessary space before @event in sdei_do_cross_call() > --- > drivers/firmware/arm_sdei.c | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c > index d03371161aaf..04dc144a8f31 100644 > --- a/drivers/firmware/arm_sdei.c > +++ b/drivers/firmware/arm_sdei.c > @@ -73,14 +73,17 @@ static LIST_HEAD(sdei_list); > > /* Private events are registered/enabled via IPI passing one of these */ > struct sdei_crosscall_args { > - struct sdei_event *event; > - atomic_t errors; > - int first_error; > + struct sdei_event *event; > + atomic_t errors; > + int first_error; > }; > > -#define CROSSCALL_INIT(arg, event) (arg.event = event, \ > - arg.first_error = 0, \ > - atomic_set(&arg.errors, 0)) > +#define CROSSCALL_INIT(arg, event) \ > + do { \ > + arg.event = event; \ > + arg.first_error = 0; \ > + atomic_set(&arg.errors, 0); \ > + } while (0) > > static inline int sdei_do_cross_call(void *fn, struct sdei_event * event) > { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel