From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25ECBC433E3 for ; Thu, 23 Jul 2020 16:58:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E12E120771 for ; Thu, 23 Jul 2020 16:58:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vjf9ksb7"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="LHhJBmkp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="XL3SPegn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E12E120771 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AX/sn23GYpyUKM1L7NzXnndn7noOW/iQbPElMd39h10=; b=vjf9ksb76vIOjmvamFW9pwHtE tbLS+M8d9UFVBefjshwIg7XGlahDXB+VN8UmrbpHtoKo77xto8Ngl9KKdDv2y5JJRRC9PRMvau0yV 54BY4IJem84jdGuomrRFsN0MM7LkwSWnKuiBxqQx6bQgnYvyrs3QNI2im1+fiO/LaXLPiP/odjTGp 9IC9iCHAbEdi8DwXwcnlAeuLI3ROuDv1K57BAIcT+ayil9T0oXHobzUYAPJDS5cu6A4UAntgZSwu3 zsWrBaQYnXNqg6lMAbyah2RUadK4xOtk1MEsCfCPlcIcOhRt0sZJ6RHhg3AFCGnaZ+qUgunbRq+dI GOku5Dg4A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyeWF-0000Se-3o; Thu, 23 Jul 2020 16:56:31 +0000 Received: from new2-smtp.messagingengine.com ([66.111.4.224]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyeWD-0000Rz-6G for linux-arm-kernel@lists.infradead.org; Thu, 23 Jul 2020 16:56:29 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 97CED5803E3; Thu, 23 Jul 2020 12:56:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 23 Jul 2020 12:56:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm3; bh=K g1waUoyA+NkTIudzcDA7EYsIpv+8sxwcxiRVeSkViE=; b=LHhJBmkpXMoLlBGlq jKFJhh+YxPr3fQiICWg55PbLzpTYxX09tFLlPgJYRXfmhXxwJnUlTPzlh4kopqBR Nq96KwXiw3ouV+AuGle3rsTCPe7tUtCJ/wZWYSv2KoHu3V74T93ImaR1NCBI51tw wKpIdtkvpgTDRUgGduKX0JM22IF7XG+IJJ1qeM2Qzt/cI+9U/P1YvW9m8fvzRAv7 l4u/QjCQx/Co1+4Nj8EMrfhKa9o3NKaURwGGOY4dopNEp5mfukJN+QhX7aVLFKsK rBjlcHJq+u/FUjXQPEIQ0RvIeG15ThSP9jjjSWKhoKdxaVaIgY4jX3dLb2Juf0eb auHLg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=Kg1waUoyA+NkTIudzcDA7EYsIpv+8sxwcxiRVeSkV iE=; b=XL3SPegnwB5spUxfsdsmxNVGfReZ+zHLQ32sFNVZNXlZt+j1K6t6cieEQ otyWGD1Jq7lpcDUIMSuj3yjIJbd195LKLOdLTqxezYOIcdWdriHEpaLCvzDURYUz qzRj9LgFxpDBgAC502d7syXjgWEQEMBTi2odi1pQunqzs5XijqxPW+ruFclsTscI DYuRkc1hxCKfr+P5wS9ZBwEaqpk2xF0UwtK9HZamyh/1wd0ab6Zni9Ro8V0np3IK eSqv8+kh29px2JseVCJ6Q84js81Qyi36IvDmI2n5UCWrcf8KDl+oocPZ81vkRXVs 3Q3cOjfdEC1zPCJzaqHVxGgtbRfag== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrhedugdduuddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtugfgjgesthhqredttddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpefgjeettdejgffgffdvteeutdehtdehgeehueetkeefgefhtdetjeekledu gedvudenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedune curfgrrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 226EF30600DC; Thu, 23 Jul 2020 12:56:27 -0400 (EDT) Date: Thu, 23 Jul 2020 18:56:25 +0200 From: Maxime Ripard To: Daniel Lezcano Subject: Re: [PATCH v4 08/16] thermal: sun8i: add TEMP_CALIB_MASK for calibration data in sun50i_h6_ths_calibrate Message-ID: <20200723165625.zo5d4sv27y3dtcbb@gilmour.lan> References: <4771acd6-ecd3-b8e1-8605-75d78720b1d3@linaro.org> <836e1b23-1c75-57fe-6e45-f7141272071c@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200723_125629_283444_4EAA72D6 X-CRM114-Status: GOOD ( 16.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: liyong@allwinnertech.com, Amit Kucheria , Linux PM , Frank Lee , Linux Kernel Mailing List , Vasily Khoruzhick , Chen-Yu Tsai , =?utf-8?B?6buE54OB55Sf?= , Frank Lee , Zhang Rui , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 20, 2020 at 12:38:10PM +0200, Daniel Lezcano wrote: > On 20/07/2020 11:27, Frank Lee wrote: > > HI, > > On Fri, Jul 17, 2020 at 3:56 PM Daniel Lezcano > > wrote: > >> > >> On 17/07/2020 09:35, Frank Lee wrote: > >>> On Fri, Jul 17, 2020 at 12:26 PM Daniel Lezcano > >>> wrote: > >>>> > >>>> On 14/07/2020 09:13, Frank Lee wrote: > >>>>> From: Yangtao Li > >>>>> > >>>>> For sun50i_h6_ths_calibrate(), the data read from nvmem needs a round of > >>>>> calculation. On the other hand, the newer SOC may store other data in > >>>>> the space other than 12bit sensor data. Add mask operation to read data > >>>>> to avoid conversion error. > >>>>> > >>>>> Signed-off-by: Yangtao Li > >>>>> Reviewed-by: Yangtao Li > >>>> > >>>> Can you clarify these SoB ? > >>> > >>> Previously I used 'Signed-off-by: Yangtao Li ', > >>> maybe this should be removed directly? > >>> > >>>> > >>>> Frank Lee==Yangtao Li==frank@allwinnertech.com==tiny.windzz@gmail.com ? > >>>> > >>> > >>> Yeah. > >> > >> You are not supposed to add reviewed-by yourself. Please remove it. > > > > Should I resend the entire series or just the thermal patch? > > What about those that have been applied. > > I can not speak on behalf of other maintainers. > > The simplest would be to ask them directly. > > If you want to go forward with the thermal changes, you can send them > separately but Maxim's Ack will be needed anyway. Given that I had a few other comments on the other patches, I guess you can resend the whole series, it will be simpler to track down. Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel