From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30775C433E3 for ; Thu, 23 Jul 2020 19:59:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE82420792 for ; Thu, 23 Jul 2020 19:59:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zePY8nrq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE82420792 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Gc4BYe83kxKGJg3zPh1dXV6dpCVseoCfqZ++P3XgtOc=; b=zePY8nrqukshtV2JEHYrEW81S Tfak2iGyy04PtB0JG7poANdZ/TKBuE9ENc35Xcgelfapa6puFsGl46drFEAFbmw937WE64H2F4puv W7ivmU5+rqLj8+YH2OgNeQXbxHYh7dwYi/YtCmbheLoSVYzuLvU1gZbrw7zlFFzMnGys7Ai6ZBR3s +pWbVY2/w89QeV2vYczYwd7r0HPrsiYjUe8wnRmIOujqnyF8+DN0uu9e6Gf2W5+DY3tEGklhzp98s zrIlszngcvfI6VE4vigR5x4WiCGGEuWeaOguCL+3ZT+9JaPET7dhljHw19BUkR5ieBwr2ujZamsaX TqAf/vLyA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyhLy-00021q-A8; Thu, 23 Jul 2020 19:58:06 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyhLu-00020h-Jq for linux-arm-kernel@lists.infradead.org; Thu, 23 Jul 2020 19:58:03 +0000 X-Originating-IP: 90.65.108.121 Received: from localhost (lfbn-lyo-1-1676-121.w90-65.abo.wanadoo.fr [90.65.108.121]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id EE163E0005; Thu, 23 Jul 2020 19:57:55 +0000 (UTC) Date: Thu, 23 Jul 2020 21:57:55 +0200 From: Alexandre Belloni To: Rob Herring Subject: Re: [PATCH v2 1/3] dt-bindings: rtc: pcf8523: add DSM pm option for battery switch-over Message-ID: <20200723195755.GV3428@piout.net> References: <20200719145028.3370-3-miguelborgesdefreitas@gmail.com> <20200720112401.4620-1-miguelborgesdefreitas@gmail.com> <20200720112401.4620-2-miguelborgesdefreitas@gmail.com> <20200723174905.GA596242@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200723174905.GA596242@bogus> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200723_155802_850904_63F38F0D X-CRM114-Status: GOOD ( 24.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: a.zummo@towertech.it, baruch@tkos.co.il, kernel@pengutronix.de, devicetree@vger.kernel.org, festevam@gmail.com, s.hauer@pengutronix.de, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, linux-imx@nxp.com, miguelborgesdefreitas@gmail.com, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23/07/2020 11:49:05-0600, Rob Herring wrote: > On Mon, Jul 20, 2020 at 12:23:59PM +0100, miguelborgesdefreitas@gmail.com wrote: > > From: Miguel Borges de Freitas > > > > This adds direct-switching mode as a configurable DT flag for > > RTC modules supporting it (e.g. nxp pcf8523). > > DSM switches the power source to the battery supply whenever the > > VDD drops below VBAT. The option is recommended for hw designs > > where VDD is always expected to be higher than VBAT. > > > > Signed-off-by: Miguel Borges de Freitas > > --- > > Changes in v2: > > - Added extended commit message for git history > > - Separate dt bindings documentation into a single patch > > > > Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt | 7 ++++++- > > Documentation/devicetree/bindings/rtc/rtc.yaml | 7 +++++++ > > 2 files changed, 13 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt b/Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt > > index 0b1080c..f715a8f 100644 > > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt > > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt > > @@ -4,10 +4,14 @@ Required properties: > > - compatible: Should contain "nxp,pcf8523". > > - reg: I2C address for chip. > > > > -Optional property: > > +Optional properties: > > - quartz-load-femtofarads: The capacitive load of the quartz(x-tal), > > expressed in femto Farad (fF). Valid values are 7000 and 12500. > > Default value (if no value is specified) is 12500fF. > > +- pm-enable-dsm: battery switch-over function is enabled in direct > > + switching mode. The power failure condition happens when VDD < VBAT, > > + without requiring VDD to drop below Vth(sw)bat. > > + Default value (if not provided) is the standard mode. > > > > Example: > > > > @@ -15,4 +19,5 @@ pcf8523: rtc@68 { > > compatible = "nxp,pcf8523"; > > reg = <0x68>; > > quartz-load-femtofarads = <7000>; > > + pm-enable-dsm; > > }; > > diff --git a/Documentation/devicetree/bindings/rtc/rtc.yaml b/Documentation/devicetree/bindings/rtc/rtc.yaml > > index ee237b2..a0048f4 100644 > > --- a/Documentation/devicetree/bindings/rtc/rtc.yaml > > +++ b/Documentation/devicetree/bindings/rtc/rtc.yaml > > @@ -47,4 +47,11 @@ properties: > > description: > > Enables wake up of host system on alarm. > > > > + pm-enable-dsm: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: > > + Enables the battery switch-over function in direct switching > > + mode. Should be set in systems where VDD is higher than VBAT > > + at all times. > > I'm all for common properties, but is this common across vendors? > This is but this shouldn't be a DT property as it has to be changed dynamically. I'm working on an ioctl interface to change this configuration. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel