From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9335C433EA for ; Thu, 23 Jul 2020 20:23:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF5CC2065F for ; Thu, 23 Jul 2020 20:23:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WGHWupB0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF5CC2065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=G8vYLUbZn2+IBuf5D0GCy3fmL8R2aVv1i0+Sunkz7Mc=; b=WGHWupB07CMpwh22HvCshlcjt yA8wz8IqywR2Imcc09kyw2hiMskyDEs0aeEIkWHRnQZASVWLXebZgjb2rfz8akW2L3ynzDas7rWn4 p46dbTro2uWF58cl+nrN9ubMCspCmUNKXBx+Ig12T+4b8fF9azsEr/NmHCrdZCwkHOm+FpRBnTWAh ZsVZoadr2xU4C5aHruGhDuryrQ+c/OJeRA1IyVhX0y86zawEVxsor5aycjLRm5fqXp/HF0FY39/m1 5RgvN3dEGv4nZzUoWgS6OhEjSEhzim20k1xsCszW0HokaftyArg7qaW7t39yG5O+EVPkIKEqsWDlv eu6G8lnSQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyhjK-0004dR-Tc; Thu, 23 Jul 2020 20:22:14 +0000 Received: from mail-il1-f193.google.com ([209.85.166.193]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyhjG-0004bH-O2; Thu, 23 Jul 2020 20:22:11 +0000 Received: by mail-il1-f193.google.com with SMTP id i18so5429618ilk.10; Thu, 23 Jul 2020 13:22:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8PtLd/nQS2KeriszStyvu2vlXIzpEo/AUp7+ugOv89o=; b=db1sFth6fZ6DXhP/50QvZRsmJW9CPKfYn2uhtbXXYH7W6oDI2bTYxQ+Z1b2iGeZoz+ IIloa4j1HmBwRXpovMVB0p/GSn9mc+S/rloIWs3BzK6i44wgWz3M0PtRJPatgQg3P/7F Pz15l04owUW6H2b2xmPx6LBx45cLQMh9qiw+7k9pKxblAkfOS500gVONSBqtgyLrzlAg 6Z+Y9HzCmER4JYgA39pcBxexiZAsai7zoXyzHxhhDQ3yRobrzQRB4aGizK75yKq2YTtp 8EZP26YASEAu0vfQ59D0xTbTlO/GbGYxJSW3/aa5Qif6ZtlhN87QO/egBM7a3QKwHzVf LmjA== X-Gm-Message-State: AOAM532L0Ne7laoApZ/y0ctWUESUDN8WKrn+Pxuh/OqYRWCiczv8Yrpb ZHc5aCtecPugJEMEqyUBslW/110ARw== X-Google-Smtp-Source: ABdhPJz9ETfckL7Gs2paXfossxHdDkoov3qmWJsBQD6PRGMZvUczCXOPfNMswMcsmYkyKV0QjfdKbQ== X-Received: by 2002:a92:8b51:: with SMTP id i78mr6376682ild.179.1595535729652; Thu, 23 Jul 2020 13:22:09 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id u3sm1965948iol.41.2020.07.23.13.22.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 13:22:07 -0700 (PDT) Received: (nullmailer pid 798999 invoked by uid 1000); Thu, 23 Jul 2020 20:22:07 -0000 Date: Thu, 23 Jul 2020 14:22:07 -0600 From: Rob Herring To: Jagan Teki Subject: Re: [PATCH v2 1/6] dt-bindings: arm: rockchip: Update ROCKPi 4 with 4A binding Message-ID: <20200723202207.GA794123@bogus> References: <20200722190949.215656-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200722190949.215656-1-jagan@amarulasolutions.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200723_162210_832280_DBDCFF25 X-CRM114-Status: GOOD ( 15.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Heiko Stuebner , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Suniel Mahesh , Michael Trimarchi , linux-amarula , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 23, 2020 at 12:39:44AM +0530, Jagan Teki wrote: > ROCKPi 4 has 3 variants of hardware platforms called > ROCKPi 4A, 4B, and 4C. > > - ROCKPi 4A has no Wif/BT. > - ROCKPi 4B has AP6256 Wifi/BT, PoE. > - ROCKPi 4C has AP6256 Wifi/BT, PoE, miniDP, USB Host enabled > GPIO pin change compared to 4B, 4C > > So, update the existing ROCKPi 4 with ROCKPi 4A binding. > > Signed-off-by: Jagan Teki > --- > Changes for v2: > - new patch > > Documentation/devicetree/bindings/arm/rockchip.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index 41f919de1ad4..36057c9e4b83 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -442,9 +442,10 @@ properties: > - const: radxa,rock > - const: rockchip,rk3188 > > - - description: Radxa ROCK Pi 4 > + - description: Radxa ROCK Pi 4A > items: > - const: radxa,rockpi4 > + - const: radxa,rockpi4a > - const: rockchip,rk3399 That's not what I suggested. And this is just wrong as the order is most specific to least specific. This is what I suggest: items: - enum: - radxa,rockpi4 # ROCK Pi 4A - radxa,rockpi4b - radxa,rockpi4c - const: rockchip,rk3399 > > - description: Radxa ROCK Pi N8 > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel