From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EE83C433E1 for ; Fri, 24 Jul 2020 00:39:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 365AF2064B for ; Fri, 24 Jul 2020 00:39:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gT2H008x"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="b0z4jJWs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 365AF2064B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uRzwhAWu3et7zdO0dgqrsFs7UF4vrTiA1DsCWzr30iw=; b=gT2H008xB3IIpCbto/++qf/U0 mVg1Zok9/3uftId6RoTUEk1ZyBWeMxzB0BOrfTNBNoYrKQT2Y0KEoX6XwXvjVNFKtO0jEl61ZhWqr tIG7Cfu12tFK0M+YWvybySVzlRLBU8yjUM5wp1t3hur1Eo5XAU0N98U8PaSnPUsJCBYF6VutDugw8 ILo78DKOBHHEhthJ3jCS9SpAPV9bdeqNrHtuv6IsyChUx/cNfQzR8bXrO7rgXNY7QLnVGB6DTu8dg N58w3ShgTEG6ebZsYT3w0CTcvOEQlJ3UpEZnNRIF98ulO3CsVs6znKwiUvWr6C9iaswYACH5UlOk1 wsUgzXXSQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jylj4-0005JS-Fc; Fri, 24 Jul 2020 00:38:14 +0000 Received: from mail29.static.mailgun.info ([104.130.122.29]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jylj0-0005IZ-BR for linux-arm-kernel@lists.infradead.org; Fri, 24 Jul 2020 00:38:11 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1595551089; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=pdbcydePT2vaNveXt+nOxic0Ssd9gvYI4IpkIArsgvY=; b=b0z4jJWsn/tpFfoaClvDbzJtbnZGne6wM9Brixjmt7qgaG6Ib4xfUB3GtfokZRTjN/3y4CxP Mb1TmBIssEnuP575LDRerinWqRXzfPzmXROoJipdEEJjGnEfGWir0UwEu59SViH6mnaznYlH +4NbZB5on467AcdJox/yGS4L/VA= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n10.prod.us-west-2.postgun.com with SMTP id 5f1a2d703dbcb593a9f7c2d2 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 24 Jul 2020 00:38:08 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 0FA98C4339C; Fri, 24 Jul 2020 00:38:08 +0000 (UTC) Received: from codeaurora.org (unknown [180.166.53.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: tingwei) by smtp.codeaurora.org (Postfix) with ESMTPSA id EC2D8C433C6; Fri, 24 Jul 2020 00:38:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org EC2D8C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=tingweiz@codeaurora.org Date: Fri, 24 Jul 2020 08:37:55 +0800 From: Tingwei Zhang To: Mike Leach Subject: Re: [PATCH v4 00/20] coresight: allow to build coresight as modules Message-ID: <20200724003755.GA3530@codeaurora.org> References: <20200723042802.22511-1-tingwei@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200723_203810_531355_4C59245E X-CRM114-Status: GOOD ( 34.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, Sai Prakash Ranjan , Kim Phillips , Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin , Greg Kroah-Hartman , Coresight ML , Mao Jinlong , Mian Yousaf Kaukab , Russell King , Randy Dunlap , Tingwei Zhang , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thu, Jul 23, 2020 at 07:03:10PM +0800, Mike Leach wrote: > Hi Tingwei, > > Minor Nit: can we get some consistency with the patch naming. > coresight: : > e.g. coresight: cti: allow build as module > where specific components are used. This makes identifying patches for > specific components a lot easier. Thanks for the advice. I'll rename them in next revision. > > Also it would be good to add my patch [1] to this series as requested > by Mathieu - it will ensure that the patch set works as a complete > set. My fault. I thought he was talking about the change you shared which depends on my change. I'll add your patch in next revision. > > Thanks and Regards > > Mike > > [1] https://lists.linaro.org/pipermail/coresight/2020-July/004275.html > > On Thu, 23 Jul 2020 at 05:28, Tingwei Zhang > wrote: > > > > Allow to build coresight as modules. This gives developers the > feasibility to > > test their code without reboot. > > > > This series is based on below two series. > > > > - "coresight: allow to build components as modules" > > https://lkml.org/lkml/2018/6/5/989 > > - "coresight: make drivers modular" > > https://lkml.org/lkml/2020/1/17/468 > > > > Change from v3: > > Rebase to coresight-next (Mike and Mathieu) > > Reorder try_get_module() (Suzuki) > > Clean up etmdrvdata[] in device remote path (Mike) > > Move cti_remove_conn_xrefs to cti_remove (Mike) > > > > Change from v2: > > Rebase to 5.8-rc5. Export coresight_add_sysfs_link and > > coresight_remove_sysfs_link > > Fix one cut and paste error on MODULE_DESCRIPTION of CTI > > > > Change from v1: > > Use try_module_get() to avoid module to be unloaded when device is used > > in active trace session. (Mathieu P) > > > > Change from above two series. > > This series adds the support to dynamically remove module when the > device in > > that module is enabled and used by some trace path. It disables all > trace > > paths with that device and release the trace path. > > > > Kim Phillips (7): > > coresight: use IS_ENABLED for CONFIGs that may be modules > > coresight: allow etm3x to be built as a module > > coresight: allow etm4x to be built as a module > > coresight: allow etb to be built as a module > > coresight: allow tpiu to be built as a module > > coresight: allow tmc to be built as a module > > coresight: allow funnel and replicator drivers to be built as modules > > > > Mian Yousaf Kaukab (4): > > coresight: export global symbols > > coresight: remove multiple init calls from funnel driver > > coresight: remove multiple init calls from replicator driver > > coresight: tmc-etr: add function to register catu ops > > > > Tingwei Zhang (9): > > coresight: cpu_debug: add module name in Kconfig > > coresight: cpu_debug: define MODULE_DEVICE_TABLE > > coresight: add coresight prefix to barrier_pkt > > coresight: add try_get_module() in coresight_grab_device() > > allow to build coresight-stm as a module, for ease of development. > > coresight: cti: add function to register cti associate ops > > coresight: allow cti to be built as a module > > coresight: allow catu drivers to be built as modules > > coresight: allow the coresight core driver to be built as a module > > > > drivers/hwtracing/coresight/Kconfig | 54 ++++++++-- > > drivers/hwtracing/coresight/Makefile | 22 ++-- > > drivers/hwtracing/coresight/coresight-catu.c | 37 ++++++- > > drivers/hwtracing/coresight/coresight-catu.h | 2 - > > .../{coresight.c => coresight-core.c} | 102 ++++++++++++++---- > > .../hwtracing/coresight/coresight-cpu-debug.c | 2 + > > .../{coresight-cti.c => coresight-cti-core.c} | 51 ++++++++- > > drivers/hwtracing/coresight/coresight-etb10.c | 22 +++- > > .../hwtracing/coresight/coresight-etm-perf.c | 9 +- > > .../hwtracing/coresight/coresight-etm-perf.h | 5 +- > > ...resight-etm3x.c => coresight-etm3x-core.c} | 27 ++++- > > ...resight-etm4x.c => coresight-etm4x-core.c} | 26 ++++- > > .../hwtracing/coresight/coresight-funnel.c | 62 ++++++++++- > > .../hwtracing/coresight/coresight-platform.c | 1 + > > drivers/hwtracing/coresight/coresight-priv.h | 24 ++--- > > .../coresight/coresight-replicator.c | 63 ++++++++++- > > drivers/hwtracing/coresight/coresight-stm.c | 20 +++- > > drivers/hwtracing/coresight/coresight-sysfs.c | 2 + > > .../{coresight-tmc.c => coresight-tmc-core.c} | 19 +++- > > .../hwtracing/coresight/coresight-tmc-etf.c | 2 +- > > .../hwtracing/coresight/coresight-tmc-etr.c | 21 +++- > > drivers/hwtracing/coresight/coresight-tmc.h | 3 + > > drivers/hwtracing/coresight/coresight-tpiu.c | 19 +++- > > include/linux/coresight.h | 2 +- > > 24 files changed, 520 insertions(+), 77 deletions(-) > > rename drivers/hwtracing/coresight/{coresight.c => coresight-core.c} > (95%) > > rename drivers/hwtracing/coresight/{coresight-cti.c => > coresight-cti-core.c} (96%) > > rename drivers/hwtracing/coresight/{coresight-etm3x.c => > coresight-etm3x-core.c} (97%) > > rename drivers/hwtracing/coresight/{coresight-etm4x.c => > coresight-etm4x-core.c} (98%) > > rename drivers/hwtracing/coresight/{coresight-tmc.c => > coresight-tmc-core.c} (96%) > > > > -- > > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora > Forum, > > a Linux Foundation Collaborative Project > > > > _______________________________________________ > > CoreSight mailing list > > CoreSight@lists.linaro.org > > https://lists.linaro.org/mailman/listinfo/coresight > > > > -- > Mike Leach > Principal Engineer, ARM Ltd. > Manchester Design Centre. UK > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel