From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80743C433DF for ; Fri, 24 Jul 2020 07:38:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4AF5E20748 for ; Fri, 24 Jul 2020 07:38:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pcW1sYFm"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="QxWsqn90" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4AF5E20748 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aewGqRVkZ2B+OSbkuWn56rNgbpeMo5cryjA0c7faxuM=; b=pcW1sYFmesvRMIrQ2dM0AiRdP 8yB/7mx8Gn+cpKq0voZbpHqVYQftqto5chm8Ga8Vk/9bPYMv5oCRZrOyHwOBRtyF/Fk3GUDjoXKGr Px0PQ2aa40X5dVLFPTveEq58A+AyjJBvwMFmhzZtYYax962g1uT/RlMg+a+Bw6GdPZcg2wyUSl3lr op+dpaZpCf3TNJIxQy7XP34QToEMNx4BKKcVR2ndcFOdweqCvrSUbkEqguTz+UaaHgzeE9OajmNtG pFZknRyRGt33qD//Ryq+mrBr0dLdJ8n8S0cCEUfytVcR19pIO0Gr/EgGLSIlGmyQGmMLmYeY8moVK Q/+SpDs4w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jysGK-0008KJ-F6; Fri, 24 Jul 2020 07:37:00 +0000 Received: from mail29.static.mailgun.info ([104.130.122.29]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jysGA-0008HF-GO for linux-arm-kernel@lists.infradead.org; Fri, 24 Jul 2020 07:36:53 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1595576212; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=pf5VmqpNycJYNU149ZUKvkMPox6QIpXsE2q92qZKe7I=; b=QxWsqn900otorlYegC73N8Oor3CgF+8cpW2vKxb08lNpMsGfZ0SU9NgJYCsYt5c/D32CUf77 iSMhSQmSEjpStJbh/ar1xgnjRKCxhr1lZaJ139a4eGUawH5dtvUJHMCZ4CXQrIFp7rR0V1CY l6lDEKuJfhcfrKQpRJ59PO8rcWk= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-west-2.postgun.com with SMTP id 5f1a8f888e9b2c49c6f7db4c (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 24 Jul 2020 07:36:40 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 476E9C433A0; Fri, 24 Jul 2020 07:36:40 +0000 (UTC) Received: from codeaurora.org (unknown [180.166.53.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: tingwei) by smtp.codeaurora.org (Postfix) with ESMTPSA id 68EAFC433C9; Fri, 24 Jul 2020 07:36:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 68EAFC433C9 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=tingweiz@codeaurora.org Date: Fri, 24 Jul 2020 15:36:28 +0800 From: Tingwei Zhang To: Greg Kroah-Hartman Subject: Re: [PATCH v4 06/20] coresight: add try_get_module() in coresight_grab_device() Message-ID: <20200724073627.GA31029@codeaurora.org> References: <20200723042802.22511-1-tingwei@codeaurora.org> <20200723042802.22511-7-tingwei@codeaurora.org> <20200723110707.GA1960107@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200723110707.GA1960107@kroah.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200724_033652_591240_9354222F X-CRM114-Status: GOOD ( 29.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, Sai Prakash Ranjan , Kim Phillips , Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin , coresight@lists.linaro.org, Randy Dunlap , Mian Yousaf Kaukab , Russell King , Mao Jinlong , Tingwei Zhang , Leo Yan , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 23, 2020 at 07:07:07PM +0800, Greg Kroah-Hartman wrote: > On Thu, Jul 23, 2020 at 12:27:48PM +0800, Tingwei Zhang wrote: > > When coresight device is in an active session, driver module of > > that device should not be removed. Use try_get_module() in > > coresight_grab_device() to prevent module to be unloaded. > > Are you sure this works? Why is it needed at all? Why not just tear > down the children properly when a module is removed so that you don't > need this at all? > > > > > Signed-off-by: Tingwei Zhang > > --- > > drivers/hwtracing/coresight/coresight.c | 27 +++++++++++++++++++++---- > > 1 file changed, 23 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/hwtracing/coresight/coresight.c > b/drivers/hwtracing/coresight/coresight.c > > index b7151c5f81b1..17bc76ea86ae 100644 > > --- a/drivers/hwtracing/coresight/coresight.c > > +++ b/drivers/hwtracing/coresight/coresight.c > > @@ -640,7 +640,7 @@ struct coresight_device > *coresight_get_sink_by_id(u32 id) > > * don't appear on the trace path, they should be handled along with > the > > * the master device. > > */ > > -static void coresight_grab_device(struct coresight_device *csdev) > > +static int coresight_grab_device(struct coresight_device *csdev) > > { > > int i; > > > > @@ -648,10 +648,25 @@ static void coresight_grab_device(struct > coresight_device *csdev) > > struct coresight_device *child; > > > > child = csdev->pdata->conns[i].child_dev; > > - if (child && child->type == CORESIGHT_DEV_TYPE_HELPER) > > + if (child && child->type == CORESIGHT_DEV_TYPE_HELPER) { > > + if > (!try_module_get(child->dev.parent->driver->owner)) > > Why the child's parent? Why not the child itself? > > > > + goto err; > > What about the error given to you here? Why throw that away? > try_module_get() returns bool which doesn't have error code. > > pm_runtime_get_sync(child->dev.parent); > > + } > > } > > + if (!try_module_get(csdev->dev.parent->driver->owner)) > > + goto err; > > You don't reduce the child's parent's driver owner module reference > here? > I'll fix in next revision. > Ugh, that's a horid sentence :( > > > pm_runtime_get_sync(csdev->dev.parent); > > + return 0; > > +err: > > + for (i--; i >= 0; i--) { > > + struct coresight_device *child; > > + > > + child = csdev->pdata->conns[i].child_dev; > > + if (child && child->type == CORESIGHT_DEV_TYPE_HELPER) > > + pm_runtime_put(child->dev.parent); > > + } > > + return -ENODEV; > > } > > > > /* > > @@ -663,12 +678,15 @@ static void coresight_drop_device(struct > coresight_device *csdev) > > int i; > > > > pm_runtime_put(csdev->dev.parent); > > + module_put(csdev->dev.parent->driver->owner); > > for (i = 0; i < csdev->pdata->nr_outport; i++) { > > struct coresight_device *child; > > > > child = csdev->pdata->conns[i].child_dev; > > - if (child && child->type == CORESIGHT_DEV_TYPE_HELPER) > > + if (child && child->type == CORESIGHT_DEV_TYPE_HELPER) { > > pm_runtime_put(child->dev.parent); > > + module_put(child->dev.parent->driver->owner); > > + } > > } > > } > > > > @@ -721,7 +739,8 @@ static int _coresight_build_path(struct > coresight_device *csdev, > > if (!node) > > return -ENOMEM; > > > > - coresight_grab_device(csdev); > > + if (coresight_grab_device(csdev)) > > + return -ENODEV; > > Why not return the error given to you? Thanks. I will fix it in next revision. Thanks, Tingwei > > > thanks, > > greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel