From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA6F7C433DF for ; Fri, 24 Jul 2020 09:35:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4F12206D7 for ; Fri, 24 Jul 2020 09:35:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JTOnrYRV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4F12206D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GcTwGB0A2sFjG6EImgwsxJ7OhJLhgAjzWWbZjYuTq+4=; b=JTOnrYRVHarFt462R6c/ekYSS fr1oRXYzp/geOl3ONsrTUrK/I2a7qLuD9vtgEmD7x/1p8Rxj4dyQ4Uch2+r6G9ZuB2Y96w7/3Z+3B TFxwORTwlDeKqW3kJixjqZAjf+kD4voQNLnblKsT3Hm49rkiPUeuryhBkKDBJc45i8y2sbqpYMp8P 97Dcgu4psWaMn7ePr6nB8GzLL3+SNvjJwEiDwI8hj8kNJ/N2kFag/Y1TF+Z1Sd7VgyFGVSWziCYc+ 2z3eoRLjwcz7FgVVdGeDZ1RfqZXxYBO4Fuc3+bHDWU2CQ8xs+TJYS5FiH1PdhHsqLlpTs5JD6wHq1 YSQtEyqdQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyu5I-0007a2-A4; Fri, 24 Jul 2020 09:33:44 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyu2d-0006EY-RH for linux-arm-kernel@lists.infradead.org; Fri, 24 Jul 2020 09:31:06 +0000 Received: from gaia (unknown [95.146.230.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2195320663; Fri, 24 Jul 2020 09:30:56 +0000 (UTC) Date: Fri, 24 Jul 2020 10:30:54 +0100 From: Catalin Marinas To: Anshuman Khandual Subject: Re: [PATCH -next] arm64: Export __cpu_logical_map Message-ID: <20200724093054.GA23388@gaia> References: <20200724030433.22287-1-wangkefeng.wang@huawei.com> <82f750c4-d423-1ed8-a158-e75153745e07@huawei.com> <7998529f-da52-5e46-dd09-b9b11d83ec1a@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7998529f-da52-5e46-dd09-b9b11d83ec1a@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200724_053100_191314_7E80F0E2 X-CRM114-Status: GOOD ( 19.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kefeng Wang , Viresh Kumar , "linux-kernel@vger.kernel.org List" , Mikko Perttunen , Hulk Robot , Sumit Gupta , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 24, 2020 at 01:46:18PM +0530, Anshuman Khandual wrote: > On 07/24/2020 08:38 AM, Kefeng Wang wrote: > > On 2020/7/24 11:04, Kefeng Wang wrote: > >> ERROR: modpost: "__cpu_logical_map" [drivers/cpufreq/tegra194-cpufreq.= ko] undefined! > >> > >> ARM64 tegra194-cpufreq driver use cpu_logical_map, export > >> __cpu_logical_map to fix build issue. > = > Commit 887d5fc82cb4 ("cpufreq: Add Tegra194 cpufreq driver") which adds > this particular driver is present just on linux-next. But as expected, > the driver does not use __cpu_logical_map directly but instead accesses > it via cpu_logical_map() wrapper. Wondering, how did you even trigger > the modpost error ? Since the wrapper is a macro, it just expands to __cpu_logical_map[]. > >> Reported-by: Hulk Robot > >> Signed-off-by: Kefeng Wang > >> --- > >> =A0 arch/arm64/kernel/setup.c | 1 + > >> =A0 1 file changed, 1 insertion(+) > >> > >> diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c > >> index c793276ec7ad9..3aea05fbb9998 100644 > >> --- a/arch/arm64/kernel/setup.c > >> +++ b/arch/arm64/kernel/setup.c > >> @@ -275,6 +275,7 @@ static int __init reserve_memblock_reserved_region= s(void) > >> =A0 arch_initcall(reserve_memblock_reserved_regions); > >> =A0 =A0 u64 __cpu_logical_map[NR_CPUS] =3D { [0 ... NR_CPUS-1] =3D INV= ALID_HWID }; > >> +EXPORT_SYMBOL(__cpu_logical_map); > >> =A0 =A0 void __init setup_arch(char **cmdline_p) > >> =A0 { I can see the Tegra cpuidle also using cpu_logical_map(), though it can't be built as a module, unlike the cpufreq one. I think the patch makes sense. -- = Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel