From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FC5CC433EB for ; Mon, 27 Jul 2020 10:31:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 09F3A2078A for ; Mon, 27 Jul 2020 10:31:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tYtL1oFR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Qlr59OqA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 09F3A2078A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8LLCqYxJK5c7BxVlaJTzR7YV8h0otZkTlNwgyaxGYwg=; b=tYtL1oFRbzJLO04sNQoXXa/Ig BwacroycR73SqiyDxqDBncX3LQNysmj4W6tS3cKuTPGWGORrgFWHQ2xtjoyKZRiUA2zgnSZPZNQbH r3c87XLlYGzvUdae1gXi/GdFjVKXcRUyws04AMI4cTAiLGfWvDeptvw58mXmvtatZOF1j6sc69nFH 2x7Sv9GavtsVanGBJD/VSorJ792yq+c5JJLf2rNBOkovnL59N/Xfh7q9f9OJqCst6vPdnojtAzth9 qMJ8fLhbkk7d1npVb9vJo9iXV0v8FAZvJqqvou2fMVkZ5xhP2IlSkcTA7oonn4kFeknIqnDTJjjen pHbmbZ1zQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k00Oz-0002IB-IS; Mon, 27 Jul 2020 10:30:37 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k00Ov-0002HH-Td for linux-arm-kernel@lists.infradead.org; Mon, 27 Jul 2020 10:30:35 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC33B20786; Mon, 27 Jul 2020 10:30:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595845833; bh=uUBNvzg2ahFLshwdZjYVVAYODV7Yiud3YVtWJ2BgPlE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qlr59OqAYvDXjI25VMFMB/svOpvvlOOktQKdQ//3ebf/w06fH2l5gz6MEsrFoHjtZ WMKmYQjQ7RAtJBmFMK0ujm64fHijK1WsjK3Xvk8KOIzsYhLUHBjl3VoBZHN/520Ia0 kd/UJN+o6UKNqT7cEJdgsE5YbkJFProL0mWMzsFQ= Date: Mon, 27 Jul 2020 11:30:28 +0100 From: Will Deacon To: Marc Zyngier Subject: Re: [PATCH 2/7] KVM: arm64: Rename kvm_vcpu_dabt_isextabt() Message-ID: <20200727103028.GB20194@willie-the-truck> References: <20200724143506.17772-1-will@kernel.org> <20200724143506.17772-3-will@kernel.org> <87tuxuwmqn.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87tuxuwmqn.wl-maz@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200727_063034_453230_153CA2B6 X-CRM114-Status: GOOD ( 16.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Suzuki Poulose , Quentin Perret , James Morse , kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jul 26, 2020 at 12:15:44PM +0100, Marc Zyngier wrote: > On Fri, 24 Jul 2020 15:35:01 +0100, > Will Deacon wrote: > > > > kvm_vcpu_dabt_isextabt() is not specific to data aborts and has nothing > > to do with sign extension. > > Not sign extension, but external abort (it reads as "is external > abort?"). > > This is in keeping with all the other helpers (kvm_vcpu_foo_isbar). If > you want to drop the "data" part (which is indeed not correct), how > about kvm_vcpu_abt_isexternal? or kvm_vcpu_abt_issea? kvm_vcpu_abt_issea() would be great -- the problem is that I confused kvm_vcpu_dabt_issext() and kvm_vcpu_dabt_isextabt() when I was hacking and if you get the wrong one then you're really hosed! I'll update for v2. Cheers, Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel