From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15430C433E1 for ; Mon, 27 Jul 2020 13:58:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D526E2070A for ; Mon, 27 Jul 2020 13:58:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bHPLgFGE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D526E2070A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2B+Q8kMgneUIkc0YVCL2FKp9rQkQw4zH85pSBy/PO+g=; b=bHPLgFGE0dYH+ywwTSxlABBsE zqsQPiukP3eks/4S+bCIWILGbqXB3s1IC9CV5FVn7b2G7ZSkFCo1MPjcpyUpI3cvcQ2rrX3XokuPY nKvrByEOWQvsn8BqQe/TjvK9QmC3Ko16wabB2T0a+K5fU9LcxzdQgwC6cya2l9h8aVb/7PGvb72NK wE3joVvljWmM/b6AxJnxQlPYvGW9EjTTnQhzW4olzWzkWdKXHwO5QIe+Gu/SNEk2WsEwRhHU59eVB y74gPsq3fyL9O9PPwcrhgFZih+D2H2ugjg3pg5hyNPvVwBvFO9+anHhTCyyHwODt7xi8N3KRQ2wcj aBbznTpDQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k03ck-0003Xl-O0; Mon, 27 Jul 2020 13:57:02 +0000 Received: from lhrrgout.huawei.com ([185.176.76.210] helo=huawei.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k03cg-0003Wf-Sh for linux-arm-kernel@lists.infradead.org; Mon, 27 Jul 2020 13:56:59 +0000 Received: from lhreml710-chm.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id 94F8137914299673A847; Mon, 27 Jul 2020 14:56:55 +0100 (IST) Received: from localhost (10.227.96.57) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Mon, 27 Jul 2020 14:56:55 +0100 Date: Mon, 27 Jul 2020 14:56:54 +0100 From: Jonathan Cameron To: Gavin Shan Subject: Re: [PATCH v2 16/17] drivers/firmware/sdei: Retrieve event signaled property on registration Message-ID: <20200727145654.00000063@huawei.com> In-Reply-To: References: <20200722095740.28560-1-gshan@redhat.com> <20200722095740.28560-17-gshan@redhat.com> <20200723162423.000019ea@Huawei.com> <20200727100414.00000ee2@Huawei.com> Organization: Huawei tech. R&D (UK) Ltd. X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.227.96.57] X-ClientProxiedBy: lhreml719-chm.china.huawei.com (10.201.108.70) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200727_095659_073631_53D61B12 X-CRM114-Status: GOOD ( 28.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, catalin.marinas@arm.com, james.morse@arm.com, shan.gavin@gmail.com, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 27 Jul 2020 20:03:32 +1000 Gavin Shan wrote: > Hi Jonathan, > > On 7/27/20 7:04 PM, Jonathan Cameron wrote: > > On Mon, 27 Jul 2020 10:53:27 +1000 > > Gavin Shan wrote: > >> On 7/24/20 1:24 AM, Jonathan Cameron wrote: > >>> On Wed, 22 Jul 2020 19:57:39 +1000 > >>> Gavin Shan wrote: > >>> > >>>> This retrieves the event signaled property when it's created for the > >>>> first time. The property will be needed when SDEI virtualization is > >>>> supported. > >>>> > >>>> Signed-off-by: Gavin Shan > >>> > >>> These last two patches are probably fine but hard to tell without a user. > >>> > >> > >> Good question. Let me explain the background and please let me know > >> if you have more questions. SDEI was suggested by Marc to deliver > >> the notification during the asynchronous page fault, so that the > >> process can be rescheduled in guest. Unfortunately, we don't have > >> SDEI (or virtualized SDEI) supported yet. So the additional event > >> information is needed when SDEI virtualization is supported. > >> > >> The code of SDEI virtualization can be checked out from github: > >> > >> https://github.com/gwshan/linux/tree/sdei (branch: "sdei") > > Thanks. > > > > I'd be tempted to move these two patches to the next series > > that includes the users. > > > > I forgot to say, I'm fine with all the patches I didn't comment on. > > > > Yes, it's fine to move the last two patches to where we need > them. Thanks for your review and comments. May I have your > reviewed-by on those patches you didn't comment on? I would > like to pick the reviwed-by in v3 :) > Sure FWIW (I'm far from an expert in this area!) Reviewed-by: Jonathan Cameron for patches 1-7,13,15 as is 8-10 with trivial changes as discussed. 12 already given Given postponing 16 and 17, that just leaves 11 and 14 that I'd like to take a quick look at in v3. Jonathan > >> > >>>> --- > >>>> drivers/firmware/arm_sdei.c | 6 ++++++ > >>>> include/linux/arm_sdei.h | 1 + > >>>> 2 files changed, 7 insertions(+) > >>>> > >>>> diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c > >>>> index cf10fec57f2a..7518d3febf53 100644 > >>>> --- a/drivers/firmware/arm_sdei.c > >>>> +++ b/drivers/firmware/arm_sdei.c > >>>> @@ -204,6 +204,12 @@ static struct sdei_event *sdei_event_create(u32 event_num, > >>>> goto fail; > >>>> event->type = result; > >>>> > >>>> + err = sdei_api_event_get_info(event_num, SDEI_EVENT_INFO_EV_SIGNALED, > >>>> + &result); > >>>> + if (err) > >>>> + goto fail; > >>>> + event->signaled = result; > >>>> + > >>>> if (event->type == SDEI_EVENT_TYPE_SHARED) { > >>>> reg = kzalloc(sizeof(*reg), GFP_KERNEL); > >>>> if (!reg) { > >>>> diff --git a/include/linux/arm_sdei.h b/include/linux/arm_sdei.h > >>>> index 11af6410dd52..7f3ed7e4b680 100644 > >>>> --- a/include/linux/arm_sdei.h > >>>> +++ b/include/linux/arm_sdei.h > >>>> @@ -51,6 +51,7 @@ struct sdei_event { > >>>> u32 event_num; > >>>> u8 type; > >>>> u8 priority; > >>>> + u8 signaled; > >>>> > >>>> /* This pointer is handed to firmware as the event argument. */ > >>>> union { > >> > > Thanks, > Gavin > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel