From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 672BAC433DF for ; Tue, 28 Jul 2020 06:34:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1DF2F20792 for ; Tue, 28 Jul 2020 06:34:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yg1BsqYe"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wXWPNw43" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DF2F20792 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RnHSKlR9rHpKmnIOPMIL8T++CKz02ibf5svxdrQI1lE=; b=yg1BsqYeFq9PL6gzsYZdNr0jf 3omKz/vdJ4f7tImDRqkPVNw/y7KpzBkDI/SjGy7exyHkj8j7V4M+shsI2/gEEveYtxJcD7ncqCI5J JmqvpZBOx+xQ33lgqMnMvCm3wYRzl90h6poDKNtXIktQ+v+AHKja6ymB4FOUjO0EQZxmNMD/LPnSi oZ+kvG8nC8M/NDdWacnv/LfBIJLRSq+b2q9//e7O+XHIuZTPRMEM59ltmiPiXsP/qIzYJICgO4K/d beOP1jBpjCMhBD9opRTBIkp2WjAjYknClsm7c68ECrtP/UrQ4qFXXOCVLQ9VTHIH9cPFbaH/bK9Yx EEVlp4Baw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0JA5-0008FP-8j; Tue, 28 Jul 2020 06:32:29 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0JA3-0008EP-22 for linux-arm-kernel@lists.infradead.org; Tue, 28 Jul 2020 06:32:28 +0000 Received: by mail-pl1-x641.google.com with SMTP id x9so9376466plr.2 for ; Mon, 27 Jul 2020 23:32:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=R1XV7yzuiaQ7OtaNP9ZBw60TBoQeSPX4RFj4H0V2PEE=; b=wXWPNw434KkwEOsqYkpoS8zrjZS8Asyrx7oJ58T34KdJ38mBxeSc/JedI7kLjrCV9w a1SeHnXVUSIHRQfSX8Oh9rtBTLprjbV0MJUddTmM1vUmZM+GJBKTIVoFmdNvrSgBG0kL UH4Gy/0Ef0oP62w48kOvxuyLrvzF+sh9TB0nG9ZijbpcW4OLFD3XzhKzh+TA+/JP/ZAY yuhxhcRYD62jV8Wlkj+/8onMTNs4Dz1EWtm46SGM1vNDfhWql1olb7AYPoobfNZMqBG5 pmy7/JNnln9kC2vhzZpSJrM1bTgYjA7DYQug6koEHpTV8OCuVRY6CQuRgN1fQQ+FdOKR QSxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=R1XV7yzuiaQ7OtaNP9ZBw60TBoQeSPX4RFj4H0V2PEE=; b=P2YQtU5iI7UaQ0dyG5PEcfOY8E6OLhRcJ85lDoP5OEhBhj4CBtasU1MxiseogISfOi dcrb6ky/roPig5U/PxlAAImXGMCl9MaPq8hquyQrHbyPDTmQGPx0Tj6ggI5IvSsZKTiM t/F32Zc0xVCkg8AaNQf/lqjk0tyZGGZ+qzKzyVLZ1fqDR9Ki5z+aS1Z6SAPzOnzsuR/Z 6ARyfH3/vcYKKi32gqd/6+Sb+WaUsJdJ8sg6E1RHTREfFJdqsb4DQRdUBYK3gxtuyVbS nlAWOPXqYkfyIG+oVFmd5uhyklDhe/cUyQ1lVjg8PQ4Ymbzr1PKxGzGZT4irldL90eC6 XJBQ== X-Gm-Message-State: AOAM531hSYPVdu2hNi+ISSpi9YXxF2AH4r0VGLnxa1HiNOcPHQxim3I7 znbFA01AN/HtSKIUOVWx5tVYEQ== X-Google-Smtp-Source: ABdhPJxteaqumaf0pqol1Li/6eDvJDAmSa/xIX4yFwUUeZrYYWwHSASFU/w3SiEOCbWX3klVCCEOWg== X-Received: by 2002:a17:90b:3010:: with SMTP id hg16mr2897765pjb.69.1595917942810; Mon, 27 Jul 2020 23:32:22 -0700 (PDT) Received: from builder.lan (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id a3sm17274887pgd.73.2020.07.27.23.32.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2020 23:32:21 -0700 (PDT) Date: Mon, 27 Jul 2020 23:28:50 -0700 From: Bjorn Andersson To: Sai Prakash Ranjan Subject: Re: [PATCH 2/4] arm64: dts: qcom: sc7180: Add iommus property to ETR Message-ID: <20200728062850.GC202429@builder.lan> References: <2312c9a10e7251d69e31e4f51c0f1d70e6f2f2f5.1591708204.git.saiprakash.ranjan@codeaurora.org> <20200621072213.GG128451@builder.lan> <20200727205834.GA202429@builder.lan> <207e6b6a297d5ce1bdcac204e297389b@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <207e6b6a297d5ce1bdcac204e297389b@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200728_023227_113655_78055583 X-CRM114-Status: GOOD ( 32.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jonathan Marek , Mathieu Poirier , Suzuki K Poulose , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Boyd , Andy Gross , linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon 27 Jul 21:40 PDT 2020, Sai Prakash Ranjan wrote: > On 2020-07-28 02:28, Bjorn Andersson wrote: > > On Tue 23 Jun 23:56 PDT 2020, Sai Prakash Ranjan wrote: > > > > > Hi Bjorn, > > > > > > On 2020-06-21 13:39, Sai Prakash Ranjan wrote: > > > > Hi Bjorn, > > > > > > > > On 2020-06-21 12:52, Bjorn Andersson wrote: > > > > > On Tue 09 Jun 06:30 PDT 2020, Sai Prakash Ranjan wrote: > > > > > > > > > > > Define iommus property for Coresight ETR component in > > > > > > SC7180 SoC with the SID and mask to enable SMMU > > > > > > translation for this master. > > > > > > > > > > > > > > > > We don't have &apps_smmu in linux-next, as we've yet to figure out how > > > > > to disable the boot splash or support the stream mapping handover. > > > > > > > > > > So I'm not able to apply this. > > > > > > > > > > > > > This is for SC7180 which has apps_smmu not SM8150. > > > > > > > > > > Please let me know if this needs further explanation. > > > > > > > I must have commented on the wrong patch, sorry about that. The SM8150 > > patch in this series does not compile due to the lack of &apps_smmu. > > > > I've picked the other 3 patches. > > > > Thanks Bjorn, I can resend SM8150 coresight change when SMMU support lands > for it > since coresight ETR won't work without it on android bootloaders. > > As for the other 3 patches, Patch 1 and Patch 2 will apply cleanly to the > right coresight > nodes but due to the missing unique context in Patch 3, it could be applied > to some other node. > We had to upload this change 3 times in chromium tree to get it applied to > the right replicator node :) > and this property in Patch 3 is important to fix a hard lockup. I'm not sure > why this patch is missing > the proper context :/ > > I couldn't find the changes yet in qcom/for-next or other branches to see if > it is > applied to right replicator node. In case you haven't applied it yet, Patch > 3 change > should be applied to "replicator@6b06000" node. > Thanks for pointing that out, I've fixed up the incorrectly applied change. (Still not published the branch) For the future I believe you can pass -U to git format-patch to get number of lines of context. Making that bigger than the default 3 should help for the coresight patches. Thanks, Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel