From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B243CC433DF for ; Wed, 29 Jul 2020 06:31:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F006206D7 for ; Wed, 29 Jul 2020 06:31:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sChaU5wN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gcoiY9ry" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F006206D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Sb4DczIUvJRZxViCromsavE8fYqTW6p7Gnf80eNn/KY=; b=sChaU5wNaDSXvkpsh7T4LaVbL kRpVDuMTlbjwhklSe/cihMrohyLjBuleW/QzORudfzJmxX/AwmObjjPdg/SiOuNFYdO7lQIyV4wZo JAVaKJXM/uLZhotgHqQIQg6LwCwuJ5UiZs7d0NWoLMlcmoeI6/d2ZHlNH1ZSZHHQSYheynl70O6kL y8CnJfBkF0dQ6ZHY7ZrOeN0FpoGpG2Yjt0JGfTgTQotMKeHjprl6lPzJ+3y/XLC6aEuGZWtBkPJye 6/YVjubg9ioBKAbpaA4ECuHS08r2nQU8i/mOuImTsb9uof8Maq8h0faHeCDa1qTEYPcaS+B1PvZL3 cNuxMymrg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0fbO-0002AM-Cq; Wed, 29 Jul 2020 06:30:10 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0fbL-000292-6v for linux-arm-kernel@lists.infradead.org; Wed, 29 Jul 2020 06:30:09 +0000 Received: by mail-pf1-x441.google.com with SMTP id w126so12245463pfw.8 for ; Tue, 28 Jul 2020 23:30:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=O5XjxR2D1PW7z/hEvGpFV0uhjH8JAxZgxGwL9HK9m6g=; b=gcoiY9ryexJmt9Xbw9Z4LmrJzGJKAEjz1Ay4NOJDdQleL7RVf095EkO81BF6Z7pk9n nTKHUOI83St7IPdp0OacljP60pvjFh2hIT6VMp8ERRbCBx9781TW9CWH3u5mZTWSumqr kpC54wZjgdKUmOGrdQ3Cx8qoy9SFmzk32B5m6S1ALJ2CQd34iNe1MeG5uevtfBZh/kRy TchIstHf7rdFYlP4Vm7jdvlMatfKrcrksMdzFLIovhGO08TRJF+r65Q+ZD8+8GJxZ6MC UX3egGLFjYu4oO3KOsEI9LMfSrrDtQ0l1lsm0t1X++DAyNCQA6nURQcOz9IdqKBY0B9w jaKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=O5XjxR2D1PW7z/hEvGpFV0uhjH8JAxZgxGwL9HK9m6g=; b=qCAycPhO1FLWPIxwt3FaEvlf1Nt4HMxIRyWGf4O14U8Ex2+H9Rjdk1aZDoiOoAgAjU ZiGX5dgHRPkTWwL/5m0ZMiPL1w8UADtv4BK2oHX2ZiwMvZuBVaZdU/b4Q6CAufrp6fj8 QKXbAdZgju0kPccew84XYfQ3lMuWuOoPOJL5QdFghnQtaiagwnLYKgyFh5BSCmwfkkmZ qmyGUohhWX9vqRKiY/3luo4vSq8n3vS2PlXYl9gDvkhr61Xw9RRhJH7pzddLfNccMxDj C9WAN3jjHnYMKAsQEFh9VFyH1Av+MnJ1Ksb6tO6BVCNXW7+8NXQI94UsxIWNY8RYDKLv mHAw== X-Gm-Message-State: AOAM530iUd9y3Eqyyl3+VH82bIbkeBJlPT8J8Bbn46BzPg1CFFNf+fmr J7nHpKrSZ7Hg78EBccsTNLVGDg== X-Google-Smtp-Source: ABdhPJyLktvCVbk2dFjHebImqHL42LIfVPyfToDmVIO7TNTSaAWvpylf4CgEOc8S2E+lSEFauxtw6w== X-Received: by 2002:aa7:970a:: with SMTP id a10mr29301103pfg.319.1596004204749; Tue, 28 Jul 2020 23:30:04 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([2600:3c01::f03c:91ff:fe8a:bb03]) by smtp.gmail.com with ESMTPSA id z67sm1186482pfc.162.2020.07.28.23.29.55 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Jul 2020 23:30:03 -0700 (PDT) Date: Wed, 29 Jul 2020 14:29:51 +0800 From: Leo Yan To: Wei Li Subject: Re: [PATCH 2/4] perf: arm-spe: Add support for ARMv8.3-SPE Message-ID: <20200729062951.GE4343@leoy-ThinkPad-X240s> References: <20200724091607.41903-1-liwei391@huawei.com> <20200724091607.41903-3-liwei391@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200724091607.41903-3-liwei391@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200729_023007_974584_85490D86 X-CRM114-Status: GOOD ( 27.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Will Deacon , Suzuki K Poulose , Alexander Shishkin , Catalin Marinas , Adrian Hunter , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, zhangshaokun@hisilicon.com, Peter Zijlstra , Ingo Molnar , James Clark , guohanjun@huawei.com, Namhyung Kim , Jiri Olsa , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 24, 2020 at 05:16:05PM +0800, Wei Li wrote: > Armv8.3 extends the SPE by adding: > - Alignment field in the Events packet, and filtering on this event > using PMSEVFR_EL1. > - Support for the Scalable Vector Extension (SVE). > > The main additions for SVE are: > - Recording the vector length for SVE operations in the Operation Type > packet. It is not possible to filter on vector length. > - Incomplete predicate and empty predicate fields in the Events packet, > and filtering on these events using PMSEVFR_EL1. This comment description is not relevant with the changes in this patch, so could remove them. > Add the corresponding decode process of Events packet and Operation Type > packet in perf tool. This patch is to add the raw dumping for Events packet and Operation Type packet. > Signed-off-by: Wei Li > --- > .../arm-spe-decoder/arm-spe-pkt-decoder.c | 69 ++++++++++++++++++- > 1 file changed, 67 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c > index b94001b756c7..10a3692839de 100644 > --- a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c > +++ b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c > @@ -347,6 +347,24 @@ int arm_spe_pkt_desc(const struct arm_spe_pkt *packet, char *buf, > blen -= ret; > } > } > + if (idx > 2) { > + if (payload & 0x800) { > + ret = snprintf(buf, buf_len, " ALIGNMENT"); > + buf += ret; > + blen -= ret; > + } > + if (payload & 0x20000) { > + ret = snprintf(buf, buf_len, " SVE-PRED-PARTIAL"); > + buf += ret; > + blen -= ret; > + } > + if (payload & 0x40000) { > + ret = snprintf(buf, buf_len, " SVE-PRED-EMPTY"); > + buf += ret; > + blen -= ret; > + } > + } > + Correct. > if (ret < 0) > return ret; > blen -= ret; > @@ -354,8 +372,38 @@ int arm_spe_pkt_desc(const struct arm_spe_pkt *packet, char *buf, > } > case ARM_SPE_OP_TYPE: > switch (idx) { > - case 0: return snprintf(buf, buf_len, "%s", payload & 0x1 ? > - "COND-SELECT" : "INSN-OTHER"); > + case 0: { > + if (payload & 0x8) { Some nitpicks for packet format checking ... For SVE operation, the payload partten is: 0b0xxx1xx0. So it's good to check the partten like: /* SVE operation subclass is: 0b0xxx1xx0 */ if ((payload & 0x8081) == 0x80) { .... } If later the packet format is extended, this will not introduce any confliction. > + size_t blen = buf_len; > + > + ret = snprintf(buf, buf_len, "SVE-OTHER"); > + buf += ret; > + blen -= ret; > + if (payload & 0x2) { Here should express as binary results: " FP" or " INT". > + ret = snprintf(buf, buf_len, " FP"); > + buf += ret; > + blen -= ret; > + } > + if (payload & 0x4) { > + ret = snprintf(buf, buf_len, " PRED"); Here should express as binary results: " PRED" or " NOT-PRED". > + buf += ret; > + blen -= ret; > + } > + if (payload & 0x70) { This is incorrect. If bits[6:4] is zero, it presents vector length is 32 bits. > + ret = snprintf(buf, buf_len, " EVL %d", > + 32 << ((payload & 0x70) >> 4)); > + buf += ret; > + blen -= ret; > + } > + if (ret < 0) > + return ret; > + blen -= ret; > + return buf_len - blen; > + } else { Here we can check with more accurate format as defined in ARMv8 ARM: /* Other operation subclass is: 0b0000000x */ if ((payload & 0xfe) == 0x0) { .... } > + return snprintf(buf, buf_len, "%s", payload & 0x1 ? > + "COND-SELECT" : "INSN-OTHER"); > + } > + } > case 1: { > size_t blen = buf_len; > > @@ -385,6 +433,23 @@ int arm_spe_pkt_desc(const struct arm_spe_pkt *packet, char *buf, > ret = snprintf(buf, buf_len, " SIMD-FP"); > buf += ret; > blen -= ret; > + } else if (payload & 0x8) { > + if (payload & 0x4) { > + ret = snprintf(buf, buf_len, " PRED"); Here should express as binary results: " PRED" or " NOT-PRED". > + buf += ret; > + blen -= ret; > + } > + if (payload & 0x70) { This is incorrect. If bits[6:4] is zero, it presents vector length is 32 bits. > + ret = snprintf(buf, buf_len, " EVL %d", > + 32 << ((payload & 0x70) >> 4)); > + buf += ret; > + blen -= ret; > + } > + if (payload & 0x80) { > + ret = snprintf(buf, buf_len, " SG"); Here should express as binary results: " SG" or " NOT-SG". Thanks, Leo > + buf += ret; > + blen -= ret; > + } > } > if (ret < 0) > return ret; > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel