From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2F6FC433DF for ; Wed, 29 Jul 2020 06:53:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 708EE206D4 for ; Wed, 29 Jul 2020 06:53:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="V8Dh6S7z"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EXoygTtg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 708EE206D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NHxn1ewAlQPskVcY1idZH3500LRT/vpWYdnUUmknhx8=; b=V8Dh6S7zM+CPskZtrmWSGDsXP iIfADRSNffzDsKT+cWroUuvxOdBZHF9e43mgp7RubC03ztWZpnWRxEbAtyTcBs5+RCIjycabnfz5k d/Sb0YWXN7c/ysJ4LFrEniZDNFS7pM1Fqk0dUP8oJReHgTcSfnciLw5ihpeZw30e4uXMqGMNNLme7 vrxXmtz/u937TSiU2TBEiTtTwQcbVbv4JcpPQU8+amcqwgP4hs7MVzZcab0Pe/pxJFcPB+SKry9ti N0yGAU4pf+gRSZwMzjBcpk2/NzQupX4TVXEFjeaQfSsQLNaxrPp6414gMTaAZRb6cImzPys35cNAG lvTa8YjBQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0fwW-000553-U0; Wed, 29 Jul 2020 06:52:00 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0fwT-00053w-Kj for linux-arm-kernel@lists.infradead.org; Wed, 29 Jul 2020 06:51:59 +0000 Received: by mail-pl1-x643.google.com with SMTP id k4so11364453pld.12 for ; Tue, 28 Jul 2020 23:51:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=nSv3tkRuZvIrkpS1YdM3QTGiWHU+CEt2ITw4/vvmoto=; b=EXoygTtg9dHzed/G/lfFb/7gmmAiWUOW1Mi+xUYfhGTYRPny4l4+7QW/K64Yt1mFP5 8YARsTH8Yx0dWH2to7Z1WPRrcSNyLXwS1WqzqNFxPGbo1deUYltWAakAZN4iHf2kCLgw MUWmLZWNhdB50KGtnzcjV02/n+7Wkfpece+Z9nhz/RhVbEqsF9jPHC6TxBFVyz5SiR75 AZcMxYU/kFbLuTpaT+fOPQuFpemXaMMa/WEqUW0TLCIwGv9ijQfXNTpI6Zw8uFFTYcj6 hxHIWfvjCAhrZfe6uB2bYDuWCm+mnrabnu4Kw4UcxhgC+4lqaoGnTriwAdg4ICTymkqF eAdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nSv3tkRuZvIrkpS1YdM3QTGiWHU+CEt2ITw4/vvmoto=; b=Aytz4fHwhy09hGQBpxkJ4nWsYdP5lFq8tkjfL94s1N+5gTMWAt7QR0fMlrwc1hVC0q +TZvFBZMFNdgXoBhPJubOkB9O8Qf0bnDSV5Hg0GIJALb2Zo/cwapfvGftsXRHN4W/Grt hqnXledToD2mmJRVyo6G4wlRgCx6NtKT+Zj9ndJGl5SBt0ozq6MjSd9OTWwxJ869E9xP ZgLcCX8LbMGb/QjznL/57nKBjY1INGm5532xWEqms6YBGEzozP8ZYFgb1Nc4FF0+o/mT k4ozzPK5vVhZPwHcY/oIIOYc3R5te2komqrarG3jy7af0+s7nncDrHNYsI3lBd+Zzy3H aV2g== X-Gm-Message-State: AOAM530vrFBWeuIox/AQnKHzYkwKMz/JjJTJ5owUBTpQWiqXW9WaemT9 4cxqyAQAIP9aILJ28olxGjnv6Q== X-Google-Smtp-Source: ABdhPJzpwdzGweCLBvO3IPK08GNulv18V8iBAX6quXtUuLtJy5gzyLc+Bu73Ju/DvdoU1Tc9ugsmYg== X-Received: by 2002:a17:90a:f290:: with SMTP id fs16mr8151036pjb.35.1596005515277; Tue, 28 Jul 2020 23:51:55 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([2600:3c01::f03c:91ff:fe8a:bb03]) by smtp.gmail.com with ESMTPSA id t63sm1094162pfb.210.2020.07.28.23.51.50 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Jul 2020 23:51:54 -0700 (PDT) Date: Wed, 29 Jul 2020 14:51:48 +0800 From: Leo Yan To: Wei Li Subject: Re: [PATCH 3/4] perf auxtrace: Add new itrace options for ARMv8.3-SPE Message-ID: <20200729065148.GF4343@leoy-ThinkPad-X240s> References: <20200724091607.41903-1-liwei391@huawei.com> <20200724091607.41903-4-liwei391@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200724091607.41903-4-liwei391@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200729_025158_398868_FF4493C1 X-CRM114-Status: GOOD ( 22.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Will Deacon , Suzuki K Poulose , Alexander Shishkin , Catalin Marinas , Adrian Hunter , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, zhangshaokun@hisilicon.com, Peter Zijlstra , Ingo Molnar , James Clark , guohanjun@huawei.com, Namhyung Kim , Jiri Olsa , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 24, 2020 at 05:16:06PM +0800, Wei Li wrote: > This patch is to add two options to synthesize events which are > described as below: > > 'u': synthesize unaligned address access events > 'v': synthesize partial/empty predicated SVE events > > This two options will be used by ARM SPE as their first consumer. > > Signed-off-by: Wei Li > --- > tools/perf/Documentation/itrace.txt | 2 ++ > tools/perf/util/auxtrace.c | 8 ++++++++ > tools/perf/util/auxtrace.h | 4 ++++ > 3 files changed, 14 insertions(+) > > diff --git a/tools/perf/Documentation/itrace.txt b/tools/perf/Documentation/itrace.txt > index e817179c5027..25bcf3622709 100644 > --- a/tools/perf/Documentation/itrace.txt > +++ b/tools/perf/Documentation/itrace.txt > @@ -13,6 +13,8 @@ > m synthesize last level cache events > t synthesize TLB events > a synthesize remote access events > + u synthesize unaligned address access events > + v synthesize partial/empty predicated SVE events > g synthesize a call chain (use with i or x) > G synthesize a call chain on existing event records > l synthesize last branch entries (use with i or x) > diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c > index 25c639ac4ad4..2033eb3708ec 100644 > --- a/tools/perf/util/auxtrace.c > +++ b/tools/perf/util/auxtrace.c > @@ -1334,6 +1334,8 @@ void itrace_synth_opts__set_default(struct itrace_synth_opts *synth_opts, > synth_opts->llc = true; > synth_opts->tlb = true; > synth_opts->remote_access = true; > + synth_opts->alignment = true; > + synth_opts->sve = true; > > if (no_sample) { > synth_opts->period_type = PERF_ITRACE_PERIOD_INSTRUCTIONS; > @@ -1507,6 +1509,12 @@ int itrace_parse_synth_opts(const struct option *opt, const char *str, > case 'a': > synth_opts->remote_access = true; > break; > + case 'u': > + synth_opts->alignment = true; > + break; > + case 'v': > + synth_opts->sve = true; > + break; > case ' ': > case ',': > break; > diff --git a/tools/perf/util/auxtrace.h b/tools/perf/util/auxtrace.h > index 142ccf7d34df..972df7b06b0d 100644 > --- a/tools/perf/util/auxtrace.h > +++ b/tools/perf/util/auxtrace.h > @@ -116,6 +116,8 @@ struct itrace_synth_opts { > bool llc; > bool tlb; > bool remote_access; > + bool alignment; Patch 03 and 04 are directive, it's good for me. The naming 'unalignment' would be more clear and avoid confusion. > + bool sve; > unsigned int callchain_sz; > unsigned int last_branch_sz; > unsigned long long period; > @@ -617,6 +619,8 @@ bool auxtrace__evsel_is_auxtrace(struct perf_session *session, > " m: synthesize last level cache events\n" \ > " t: synthesize TLB events\n" \ > " a: synthesize remote access events\n" \ > +" u: synthesize unaligned address access events\n" \ The 'unalignment' events are for 'unaligned address access and size of data'. Otherwise, looks good to me: Reviewed-by: Leo Yan Thanks, Leo > +" v: synthesize partial/empty predicated SVE events\n" \ > " g[len]: synthesize a call chain (use with i or x)\n" \ > " l[len]: synthesize last branch entries (use with i or x)\n" \ > " sNUMBER: skip initial number of events\n" \ > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel