From: Stephan Gerhold <stephan@gerhold.net>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, Sean Paul <sean@poorly.run>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/mcde: Rename flow function
Date: Wed, 29 Jul 2020 10:21:25 +0200 [thread overview]
Message-ID: <20200729082125.GA867@gerhold.net> (raw)
In-Reply-To: <20200728214319.143213-1-linus.walleij@linaro.org>
On Tue, Jul 28, 2020 at 11:43:18PM +0200, Linus Walleij wrote:
> The function mcde_display_send_one_frame() has a historical
> name that stems from being implemented when the driver
> only supported single frame updates.
>
> Rename it mcde_start_flow() so that it reflects the current
> usage.
>
> Cc: Stephan Gerhold <stephan@gerhold.net>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
> ---
> drivers/gpu/drm/mcde/mcde_display.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/mcde/mcde_display.c b/drivers/gpu/drm/mcde/mcde_display.c
> index 1d8ea8830a17..a99cc3fd5ef4 100644
> --- a/drivers/gpu/drm/mcde/mcde_display.c
> +++ b/drivers/gpu/drm/mcde/mcde_display.c
> @@ -994,7 +994,7 @@ static void mcde_display_disable(struct drm_simple_display_pipe *pipe)
> dev_info(drm->dev, "MCDE display is disabled\n");
> }
>
> -static void mcde_display_send_one_frame(struct mcde *mcde)
> +static void mcde_start_flow(struct mcde *mcde)
> {
> /* Request a TE ACK */
> if (mcde->te_sync)
> @@ -1092,7 +1092,7 @@ static void mcde_display_update(struct drm_simple_display_pipe *pipe,
> * is not active yet.
> */
> if (mcde->flow_active == 0)
> - mcde_display_send_one_frame(mcde);
> + mcde_start_flow(mcde);
> }
> dev_info_once(mcde->dev, "sent first display update\n");
> } else {
> --
> 2.26.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-07-29 8:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 21:43 [PATCH 1/2] drm/mcde: Rename flow function Linus Walleij
2020-07-28 21:43 ` [PATCH 2/2] drm/mcde: Fix display data flow control Linus Walleij
2020-07-29 8:44 ` Stephan Gerhold
2020-07-29 8:21 ` Stephan Gerhold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729082125.GA867@gerhold.net \
--to=stephan@gerhold.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).