From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40079C433E0 for ; Wed, 29 Jul 2020 20:18:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D95A2074B for ; Wed, 29 Jul 2020 20:18:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GYb3Qj58" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D95A2074B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jgfRy1MzfxLRh7pi65cNj78czt8hHDLrw9iqwH2WS4I=; b=GYb3Qj58dAiFGrx7U7XiQJPVl BapBukDoyY/Lz2SR1AOla/r45N/cFtxOlQZg6V9srIA1FQmULdM5r5i41KpB3ntT7Le4iRHDvKyD/ KPxiYmnuTJhDeXlr7LxwRL9P8GzmTZt/wD4XITR4q4Dpu5mrhjeO5/xOlrTcZhWQ4PcMvwtijE4I9 3EvrQxzRqE08+MpPEaZaksJq/+CzO76hiR/loO+0ohW6Ih0mWjfM1UjVKSk57fMaQkZ6O/zW62gby WW6cn4IiWqByOtpKoG6JDXIS0h4PreeTEsK1D7nMRbG9F4h17XTEGBCW94jwStZiZYnrWaQ9YjkmT Q2hqRKc9w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0sVK-0005BN-OC; Wed, 29 Jul 2020 20:16:47 +0000 Received: from mail-ej1-f65.google.com ([209.85.218.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0sVE-00059n-QM for linux-arm-kernel@lists.infradead.org; Wed, 29 Jul 2020 20:16:41 +0000 Received: by mail-ej1-f65.google.com with SMTP id g19so11841111ejc.9 for ; Wed, 29 Jul 2020 13:16:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=G9J40aLhPUBHarAksyHrJM+WbtR3gRhMvbXXJTyIEsw=; b=DK+qfRlkKfPL4hcCgAn1NQRv5Iq096IZ+5nxnkfLjq4zLmTj831tyU8B/0ZJqIn668 Ood/UaHwwKN1L/ncvp/BejefZeEIg8X/nqWISHtpDJSMmmZoIvNgjtWd1Ubhja2Z6DvV iRIJn8JdcNuCIKaw/rnDN/HLNfyyYl4zYplBO92PIk93fhpHD86wgUI2a4/yYzNNuWe9 Jm6MXHy7jgG29qUG+ugXB9eVBEteg6SF1MHQIsgaZVy9RIB1+KwZ0swAxsJODB+nLGZf h6xuuxlS51x85y+zSC//jvn6EX9MYmsNQ4eNUdHhsVM1j9k16vI42vU7kRFI47FHwLYq +X/A== X-Gm-Message-State: AOAM532pyCS9IG7nYv4gTYrwilhiMdzS7R3PshZhVjWI0SFn9m5T4Fru 4TJM5zaqXRyOUfoTGL9WsWg= X-Google-Smtp-Source: ABdhPJz8NSZ1YgCRCp5BY64q7jD+PPCB1uyy1HQKw9M5f39sg32SzCcRfdGo1BmuaDhYo5fGcHeBew== X-Received: by 2002:a17:906:78e:: with SMTP id l14mr80328ejc.67.1596053799753; Wed, 29 Jul 2020 13:16:39 -0700 (PDT) Received: from kozik-lap ([194.230.155.213]) by smtp.googlemail.com with ESMTPSA id a23sm2669500eju.68.2020.07.29.13.16.37 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 Jul 2020 13:16:39 -0700 (PDT) Date: Wed, 29 Jul 2020 22:16:35 +0200 From: Krzysztof Kozlowski To: Stephen Boyd Subject: Re: [PATCH 1/7] clk: samsung: s3c64xx: Declare s3c64xx_clk_init() in shared header Message-ID: <20200729201635.GB26917@kozik-lap> References: <20200729160942.28867-1-krzk@kernel.org> <20200729160942.28867-2-krzk@kernel.org> <159605176358.1360974.7715120460121088439@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <159605176358.1360974.7715120460121088439@swboyd.mtv.corp.google.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200729_161640_910450_B4F0FEB6 X-CRM114-Status: GOOD ( 20.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Linus Walleij , Tomasz Figa , Sylwester Nawrocki , Will Deacon , linux-clk@vger.kernel.org, Marek Szyprowski , linux-samsung-soc@vger.kernel.org, Sylwester Nawrocki , Cedric Roux , Russell King , linux-stm32@st-md-mailman.stormreply.com, Lihua Yao , Chanwoo Choi , Kukjin Kim , Michael Turquette , Guenter Roeck , Sergio Prado , linux-watchdog@vger.kernel.org, Arnd Bergmann , Wim Van Sebroeck , Simtec Linux Team , linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, Vincent Sanders , linux-kernel@vger.kernel.org, Kyungmin Park Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 29, 2020 at 12:42:43PM -0700, Stephen Boyd wrote: > Quoting Krzysztof Kozlowski (2020-07-29 09:09:36) > > diff --git a/include/linux/clk/samsung.h b/include/linux/clk/samsung.h > > new file mode 100644 > > index 000000000000..b6b253c46c22 > > --- /dev/null > > +++ b/include/linux/clk/samsung.h > > @@ -0,0 +1,21 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * Copyright (c) 2020 Krzysztof Kozlowski > > + */ > > + > > +#ifndef __LINUX_CLK_SAMSUNG_H_ > > +#define __LINUX_CLK_SAMSUNG_H_ > > + > > +#ifdef CONFIG_ARCH_S3C64XX > > +void __init s3c64xx_clk_init(struct device_node *np, unsigned long xtal_f, > > Don't use __init in header files. It doesn't do anything. > > > + unsigned long xusbxti_f, bool s3c6400, > > + void __iomem *base); > > +#else > > +static inline void __init s3c64xx_clk_init(struct device_node *np, > > Forward declare struct device_node; > > > + unsigned long xtal_f, > > + unsigned long xusbxti_f, > > + bool s3c6400, > > + void __iomem *base) { } > > Include (or compiler_types.h) for __iomem define > please. Thanks for the feedback. I'll send v2. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel