From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Gross <agross@kernel.org>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] soc: qcom: smd-rpm: Fix kerneldoc
Date: Wed, 29 Jul 2020 13:46:28 -0700 [thread overview]
Message-ID: <20200729204628.GL229995@builder.lan> (raw)
In-Reply-To: <20200729074415.28393-2-krzk@kernel.org>
On Wed 29 Jul 00:44 PDT 2020, Krzysztof Kozlowski wrote:
> Fix W=1 compile warnings (invalid kerneldoc):
>
> drivers/soc/qcom/smd-rpm.c:35: warning: Function parameter or member 'dev' not described in 'qcom_smd_rpm'
> drivers/soc/qcom/smd-rpm.c:99: warning: Function parameter or member 'state' not described in 'qcom_rpm_smd_write'
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Thanks for spotting these, applied.
PS. This doesn't have any relationship with the Mediatek patch, the two
goes through different maintainer trees and my manual mailbox filter
almost discarded the series. So please send patches like this
individually in the future.
Thanks,
Bjorn
> ---
> drivers/soc/qcom/smd-rpm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/soc/qcom/smd-rpm.c b/drivers/soc/qcom/smd-rpm.c
> index 877b13850730..1d4eb46b417a 100644
> --- a/drivers/soc/qcom/smd-rpm.c
> +++ b/drivers/soc/qcom/smd-rpm.c
> @@ -20,6 +20,7 @@
> * struct qcom_smd_rpm - state of the rpm device driver
> * @rpm_channel: reference to the smd channel
> * @icc: interconnect proxy device
> + * @dev: rpm device
> * @ack: completion for acks
> * @lock: mutual exclusion around the send/complete pair
> * @ack_status: result of the rpm request
> @@ -86,6 +87,7 @@ struct qcom_rpm_message {
> /**
> * qcom_rpm_smd_write - write @buf to @type:@id
> * @rpm: rpm handle
> + * @state: active/sleep state flags
> * @type: resource type
> * @id: resource identifier
> * @buf: the data to be written
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-29 20:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 7:44 [PATCH 1/2] soc: mediatek: mtk-infracfg: Fix kerneldoc Krzysztof Kozlowski
2020-07-29 7:44 ` [PATCH 2/2] soc: qcom: smd-rpm: " Krzysztof Kozlowski
2020-07-29 20:46 ` Bjorn Andersson [this message]
2020-07-29 7:53 ` [PATCH 1/2] soc: mediatek: mtk-infracfg: " Matthias Brugger
2020-08-19 17:48 ` Krzysztof Kozlowski
2020-08-19 22:39 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729204628.GL229995@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).