From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C39A3C433E0 for ; Thu, 30 Jul 2020 12:28:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93CF42074B for ; Thu, 30 Jul 2020 12:28:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="C91S08WO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93CF42074B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CcQ9Nb5mXL3i94+DWdUoSg7jYdkv6yz4/FrFy4vWT60=; b=C91S08WOxBmlcIQm7lMGNs+tJ EBIH1qJJzSVMmhHLvI3IfSOS3wDSi09EzpuhNG5BYyZNVje9iF2hRwEtDjsxA4ftAvkNbGj5V+Wc3 +cTK8A/g0tbX9P6/Ifh/dxShPaksfxum+w94JaONkUCVAnONP0fEdHvhF3DFhf+AF2N4aCxMNDS9l ZKCS+D7Y6iaLVIqCBX0NGBrrR2ot+fa8iJ7ol3a8Qk943+6jd6W7SKy04+SJNobfizz01A8XGXbwH SobEYl5XXycBXCqiwwqQUggEJMqO9EB7b6dngOFEaXR0eCCfKwSwvOWd2Liungv/LZsqeQ8rKmbox nS/xXuTpg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k17ek-0003WQ-FJ; Thu, 30 Jul 2020 12:27:30 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k17ei-0003W5-2Z for linux-arm-kernel@lists.infradead.org; Thu, 30 Jul 2020 12:27:28 +0000 Received: from gaia (unknown [95.146.230.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CCDE42074B; Thu, 30 Jul 2020 12:27:25 +0000 (UTC) Date: Thu, 30 Jul 2020 13:27:23 +0100 From: Catalin Marinas To: Yue Hu Subject: Re: [PATCH] arm64: mm: add message to die() in die_kernel_fault() Message-ID: <20200730122723.GN25149@gaia> References: <20200730114757.13592-1-zbestahu@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200730114757.13592-1-zbestahu@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200730_082728_249021_675D0C0E X-CRM114-Status: GOOD ( 18.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, linux-kernel@vger.kernel.org, peterx@redhat.com, zbestahu@163.com, huyue2@yulong.com, james.morse@arm.com, akpm@linux-foundation.org, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 30, 2020 at 07:47:57PM +0800, Yue Hu wrote: > From: Yue Hu > > Just to identify the kernel fault more clearly. > > Signed-off-by: Yue Hu > --- > arch/arm64/mm/fault.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c > index 8afb238..3a753c7 100644 > --- a/arch/arm64/mm/fault.c > +++ b/arch/arm64/mm/fault.c > @@ -289,7 +289,7 @@ static void die_kernel_fault(const char *msg, unsigned long addr, > mem_abort_decode(esr); > > show_pte(addr); > - die("Oops", regs, esr); > + die("Oops - Page fault", regs, esr); > bust_spinlocks(0); > do_exit(SIGKILL); > } Don't we already print enough information prior to die()? -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel