From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A081FC433E0 for ; Thu, 30 Jul 2020 17:36:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6ED6F20809 for ; Thu, 30 Jul 2020 17:36:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DtMN/rWb"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VnWTck5x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6ED6F20809 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EU5cFiZDy6sAmvKFSzEGPaPcROOdTBpUAP43tEtrprA=; b=DtMN/rWbr3HSzN60TSuwLb7ml txxYxT97GpGyguHXfk2I0/vKNnX7Q5uHnvlxnyDKhSjrSZB1lsODRvI+jpxAAMFeol/bCZ34iQ5MH Fym1cc048a+JRCuOaXGsdc3MEGP4SW3G88Kaf7qxVV0DUEAzrXdkgx9FZdDV4W7cwBQ6N8PVipRJL dk1uzdh4hhEpW3Qt7Ta/otbaiQHHhnTqzNnT0L+f5HZafIZr2Ubc7j6R+amOo00Y8GBPf2fVES3Cn KnGKw/b/qN9eW4huCu7NHrhp0MjGOGrMPO7ARGrAEiHpljE+reFs7IJcu7jByLD4UYIMKWUM2Ljyp akVYtI7iA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1CS9-0003kT-Vz; Thu, 30 Jul 2020 17:34:50 +0000 Received: from mail-qv1-xf44.google.com ([2607:f8b0:4864:20::f44]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1CS2-0003is-64 for linux-arm-kernel@lists.infradead.org; Thu, 30 Jul 2020 17:34:43 +0000 Received: by mail-qv1-xf44.google.com with SMTP id t6so7965444qvw.1 for ; Thu, 30 Jul 2020 10:34:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=kKBYFk9kySZz7tEHZOuAKEjulhjUQcxCphxcALe8cTI=; b=VnWTck5xxmqkOwWU7xobpDi5KXn1/cdayp+uqCmxXDbjHn/33pZFiUFHSEzMyX69kE e0yOqJAb3tYvgaBfkdqMwDGCRGRMoFpBTG/oxv1/ohbrkl9TlL0odGH6LTpzTPo5kp9W W77zQn2zjc6QuSvGKYvWbBAeKhXhf84k5X7qr/MDiJs1xfoRkH+E2DYbt7lbjnprRjt/ fLkyVk54L2dNiPH4nGbccny4yz3pA6zUTt/AGKGBCWTZRN2Zhs5eKjt11MIsDFPsKYen aWi5Mga0mIrp9hdwhhbUGeWDHw/6VcoZ0ZMpqyXOzvnvV4gmVUItpKSUQ0RgioMancab qebw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kKBYFk9kySZz7tEHZOuAKEjulhjUQcxCphxcALe8cTI=; b=e30jxYK7FOETKkQQKaTGRr8v8GcrnXtJlxLIX2I/ewjNAbihPHBKWdLyV+mzzl69PA GKbJOi470NuV2B7SugmxS/GpEnKVECd6SRN0nRzxiNpQdvWjD8SjlwRKABtANSNXpiRS 3uBKiPLh2a4cJ8rJWpDj2l38ZReehmQ4+72nGmNUjmp8hF4TeqbO4GyDb5VVgN3gKwhp 9Pc95i5R6Ird/EXZHPNAOpssfv8hCEtdY8P7cteGKEUbhBZsh6Tq3W01oblN2F4SRyYQ 6T+ZElLbyS+RIhQ4WLVACjW1R6+uC6AmG0m+301QQfe+c2ERmIFhhx2popuIB1AyPliR h3LA== X-Gm-Message-State: AOAM533VQ2W65m4H1gE/VXdBWQIbv/WcMMhNnGjR00NWONZozvgIN8ww u9pMvDDe/XTSuA4yvJfMVU8= X-Google-Smtp-Source: ABdhPJwEC/UR0H0u5245jHtDhiXoTqKGeMzcClC/F+P0WqKZ+l3DmYz/N3UyGUyyziSvSM16v64qQQ== X-Received: by 2002:a0c:d44e:: with SMTP id r14mr169617qvh.105.1596130480142; Thu, 30 Jul 2020 10:34:40 -0700 (PDT) Received: from ubuntu-n2-xlarge-x86 ([2604:1380:45d1:2600::1]) by smtp.gmail.com with ESMTPSA id e2sm1880549qki.22.2020.07.30.10.34.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2020 10:34:39 -0700 (PDT) Date: Thu, 30 Jul 2020 10:34:37 -0700 From: Nathan Chancellor To: Christoph Hellwig Subject: Re: [PATCH 1/4] arm64: stop using directly Message-ID: <20200730173437.GA1172439@ubuntu-n2-xlarge-x86> References: <20200726160401.311569-1-hch@lst.de> <20200726160401.311569-2-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200726160401.311569-2-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200730_133442_347684_67B541C0 X-CRM114-Status: GOOD ( 21.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, linux-api@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, Jan Kara , linux-fsdevel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jul 26, 2020 at 06:03:58PM +0200, Christoph Hellwig wrote: > Always use so that we can move more declarations to > common code. In two of the three cases the asm include was in addition > to an existing one for anyway. > > Signed-off-by: Christoph Hellwig > --- > arch/arm64/include/asm/stat.h | 2 +- > arch/arm64/kernel/process.c | 1 - > arch/arm64/kernel/ptrace.c | 1 - > 3 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/arm64/include/asm/stat.h b/arch/arm64/include/asm/stat.h > index 3b4a62f5aeb0c3..1b5ac1ef5d04cc 100644 > --- a/arch/arm64/include/asm/stat.h > +++ b/arch/arm64/include/asm/stat.h > @@ -10,7 +10,7 @@ > #ifdef CONFIG_COMPAT > > #include > -#include > +#include This breaks arm64 defconfig: $ make -skj"$(nproc)" ARCH=arm64 CROSS_COMPILE=aarch64-linux- distclean defconfig init/main.o In file included from ./include/linux/compat.h:17, from ./arch/arm64/include/asm/stat.h:13, from ./include/linux/stat.h:6, from ./include/linux/sysfs.h:22, from ./include/linux/kobject.h:20, from ./include/linux/of.h:17, from ./include/linux/irqdomain.h:35, from ./include/linux/acpi.h:13, from ./include/acpi/apei.h:9, from ./include/acpi/ghes.h:5, from ./include/linux/arm_sdei.h:8, from arch/arm64/kernel/asm-offsets.c:10: ./include/linux/fs.h: In function 'vfs_whiteout': ./include/linux/fs.h:1736:32: error: 'S_IFCHR' undeclared (first use in this function) 1736 | return vfs_mknod(dir, dentry, S_IFCHR | WHITEOUT_MODE, WHITEOUT_DEV); | ^~~~~~~ ./include/linux/fs.h:1736:32: note: each undeclared identifier is reported only once for each function it appears in ./include/linux/fs.h: At top level: ./include/linux/fs.h:1886:46: warning: 'struct kstat' declared inside parameter list will not be visible outside of this definition or declaration 1886 | int (*getattr) (const struct path *, struct kstat *, u32, unsigned int); | ^~~~~ ./include/linux/fs.h: In function '__mandatory_lock': ./include/linux/fs.h:2372:25: error: 'S_ISGID' undeclared (first use in this function); did you mean 'SIGIO'? 2372 | return (ino->i_mode & (S_ISGID | S_IXGRP)) == S_ISGID; | ^~~~~~~ | SIGIO ./include/linux/fs.h:2372:35: error: 'S_IXGRP' undeclared (first use in this function) 2372 | return (ino->i_mode & (S_ISGID | S_IXGRP)) == S_ISGID; | ^~~~~~~ ... $ git bisect log # bad: [7b287a5c6ac518c415a258f2aa7b1ebb25c263d2] Add linux-next specific files for 20200730 # good: [d3590ebf6f91350192737dd1d1b219c05277f067] Merge tag 'audit-pr-20200729' of git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit git bisect start '7b287a5c6ac518c415a258f2aa7b1ebb25c263d2' 'd3590ebf6f91350192737dd1d1b219c05277f067' # bad: [1f1ed12be70e9eb4e05ac206c6ad6a5a31f5b921] Merge remote-tracking branch 'crypto/master' git bisect bad 1f1ed12be70e9eb4e05ac206c6ad6a5a31f5b921 # bad: [07fad673c2f1a02440c879c34f8182b12786a735] Merge remote-tracking branch 'hid/for-next' git bisect bad 07fad673c2f1a02440c879c34f8182b12786a735 # good: [7a77c92312546a74d3507484b256ae17bfb2cfe2] Merge remote-tracking branch 'm68knommu/for-next' git bisect good 7a77c92312546a74d3507484b256ae17bfb2cfe2 # good: [40dd62f180e38317e744d7f82c98af31a24fd2c9] Merge remote-tracking branch 'f2fs/dev' git bisect good 40dd62f180e38317e744d7f82c98af31a24fd2c9 # bad: [52138dfdd2192bcfc7d3bc2e79475966ee4b20c4] Merge remote-tracking branch 'printk/for-next' git bisect bad 52138dfdd2192bcfc7d3bc2e79475966ee4b20c4 # good: [a37c3e37fa3fa1381e03d918d708f82927ddd160] Merge remote-tracking branch 'xfs/for-next' git bisect good a37c3e37fa3fa1381e03d918d708f82927ddd160 # good: [4e523547e2bf755d40cb10e85795c2f9620ff3fb] nvme-pci: add a blank line after declarations git bisect good 4e523547e2bf755d40cb10e85795c2f9620ff3fb # bad: [5066741180729f7bad9401de34efda3766c3274a] Merge branches 'fixes' and 'work.quota-compat' into for-next git bisect bad 5066741180729f7bad9401de34efda3766c3274a # good: [4ff8a356daafaafbf90141ee7a3b8fdc18e560a8] ia64: switch to ->regset_get() git bisect good 4ff8a356daafaafbf90141ee7a3b8fdc18e560a8 # good: [ce327e1c54119179066d6f3573a28001febc9265] regset: kill user_regset_copyout{,_zero}() git bisect good ce327e1c54119179066d6f3573a28001febc9265 # good: [1697a322e28ba96d35953c5d824540d172546d36] [elf-fdpic] switch coredump to regsets git bisect good 1697a322e28ba96d35953c5d824540d172546d36 # good: [259bf01c1bd1f049958496a089c4f334fe0c8a48] Merge branches 'work.misc', 'work.regset' and 'work.fdpic' into for-next git bisect good 259bf01c1bd1f049958496a089c4f334fe0c8a48 # bad: [0a3a4497a1de8e68e809a693b549c7ec2f195301] compat: lift compat_s64 and compat_u64 to git bisect bad 0a3a4497a1de8e68e809a693b549c7ec2f195301 # bad: [b902bfb3f0e9d07ec9f48256e57e5c5de6108f8c] arm64: stop using directly git bisect bad b902bfb3f0e9d07ec9f48256e57e5c5de6108f8c # first bad commit: [b902bfb3f0e9d07ec9f48256e57e5c5de6108f8c] arm64: stop using directly I assume the stat header order should be messed around with but I am not sure what exactly that would entail to make sure that nothing else breaks, hence just the report. Cheers, Nathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel