From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5A1AC433E0 for ; Thu, 30 Jul 2020 19:58:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B34C220656 for ; Thu, 30 Jul 2020 19:58:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KbE7Hpdg"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NGnqNsFT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B34C220656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kL2PrpPwNM0XqJ+WjTc4h8WK62JsUYkqpsjyc5x22Ys=; b=KbE7Hpdg//dR4BPxOR7IPcKwy mkEdsMvoBNA166ppv7IfBf1UvRr5vnoFIpdXD6dfZxd0R9jSZbSixSh6rvPmMsqEiviSMvajJsX6u 4Pue8vPyWOaMIlVpruGbQ30qwpv0BdccEQV3TkXCZaSYpXc6gHcbvTlrkvUVqPKt4H+uLGbKp7U90 BHPED/e9rIXX5SEjC5UsfRj/M9H2lQ1GQA3dfgXMHcDrnzsmmW9I7IQudmEwEHIU0ExvbFjTptq02 P07ESiyxfoMPKMFHSiGsWyRNmExhuS/y35o4qFITIZhpODwmEgirBEN6/ITKAtevKpN28kFS8vGfF EqDO+dAkg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1EfW-0000hW-Fu; Thu, 30 Jul 2020 19:56:46 +0000 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1EfT-0000gV-Ks for linux-arm-kernel@lists.infradead.org; Thu, 30 Jul 2020 19:56:44 +0000 Received: by mail-pj1-x1043.google.com with SMTP id t15so5539312pjq.5 for ; Thu, 30 Jul 2020 12:56:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=KzXD0MRi65oSTXHgCyzde0q1srH0GAtc+ha28tXiTLc=; b=NGnqNsFTZlKNXRaJQvbsmWULw8+/G5xUXncje3YJWBb3mLbdKb/zIY43ER/dfAFZEs 0o944uAgnE2HOKxBDwTdhW2CH3OQN+i7KUGd+WKYpBWqpCAQV3vgYlo3cLJ1kBrXF8UK CxodWOaVKLsCsbyZN1Vztyei1X75TBj2TOykBFAatZPzqbWukqayWMH8KDmTNPzMPCyj cYBjonm/+EWJeXx8zW0eBqsq0Z4WxMTxVbzkNpjV7YI8F8kdD0R+0xLkTeLgtHXV1lw/ Ug6vPGFpIF2bstOJ2fpbi03P7d4pS0GXW+0ZW88kEdlu6xi9hykUmHvg3S9Xx588a+7C ZVjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KzXD0MRi65oSTXHgCyzde0q1srH0GAtc+ha28tXiTLc=; b=HeHDRKt51NPMW8zhttnPao4x20SIe3tGPB3XAAq43JA2odTCJr1Fbsuq5oJ+Q70RDL ONL0mSi5pxEPhHFUVDFtlg4cH2G/yw+CFtFLr/M5pQFx1YmNOtKHJqKKpZewMuiNfUec 6ZccVU4ArX0GtE99hWVm1WixkkFvbM07b2/0+5x+XoeJ9eRTxyCWysvFglGRMDdgQsLE lmPZyi7FdKA7h7XUnfmxOqi5r5jdfwCXmJTJZ72Qb6kH+I4JhyLWbrKZ8FyFT3Ht7E1c +2etkW4tgrRatChJqkr5UIJLdQ3KDWPCyk/+5qk6OxeV6d/E9QfKpKz+ZfYcZ82YRy4v CTrQ== X-Gm-Message-State: AOAM531HlbFJyOOW9oF8VjL6ckxFfJzDoS3GoLZUasXbeLV4wIbNX9rg HPY4Wu/5UVLr6j+WXRP0Qgv15JkwAqc= X-Google-Smtp-Source: ABdhPJwl6R8PoPsL0ppPlmpcjuFT65L9AryjbOfKLLj/4Glx60PaO1QR2ebP1qlrkD2f3Z0AJgbAXQ== X-Received: by 2002:a17:90a:89:: with SMTP id a9mr714997pja.171.1596139001101; Thu, 30 Jul 2020 12:56:41 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id g6sm7295794pfr.129.2020.07.30.12.56.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2020 12:56:40 -0700 (PDT) Date: Thu, 30 Jul 2020 13:56:38 -0600 From: Mathieu Poirier To: Suzuki K Poulose Subject: Re: [RFC PATCH 07/14] coresight: etm4x: Always read the registers on the host CPU Message-ID: <20200730195638.GD3155687@xps15> References: <20200722172040.1299289-1-suzuki.poulose@arm.com> <20200722172040.1299289-8-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200722172040.1299289-8-suzuki.poulose@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200730_155643_915461_2F3330C1 X-CRM114-Status: GOOD ( 16.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: coresight@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 22, 2020 at 06:20:33PM +0100, Suzuki K Poulose wrote: > As we are about to add support for sysreg access to ETM4.4+ components, > make sure that we read the registers only on the host CPU. > > Cc: Mathieu Poirier > Cc: Mike Leach > Signed-off-by: Suzuki K Poulose > --- Reviewed-by: Mathieu Poirier > .../coresight/coresight-etm4x-sysfs.c | 23 ++++++++----------- > 1 file changed, 10 insertions(+), 13 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c > index b673e738bc9a..90c75ba31a0c 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c > +++ b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c > @@ -2341,23 +2341,20 @@ static u32 etmv4_cross_read(const struct device *dev, u32 offset) > return reg.data; > } > > -#define coresight_etm4x_reg(name, offset) \ > - coresight_simple_reg32(struct etmv4_drvdata, name, offset) > - > #define coresight_etm4x_cross_read(name, offset) \ > coresight_simple_func(struct etmv4_drvdata, etmv4_cross_read, \ > name, offset) > > -coresight_etm4x_reg(trcpdcr, TRCPDCR); > -coresight_etm4x_reg(trcpdsr, TRCPDSR); > -coresight_etm4x_reg(trclsr, TRCLSR); > -coresight_etm4x_reg(trcauthstatus, TRCAUTHSTATUS); > -coresight_etm4x_reg(trcdevid, TRCDEVID); > -coresight_etm4x_reg(trcdevtype, TRCDEVTYPE); > -coresight_etm4x_reg(trcpidr0, TRCPIDR0); > -coresight_etm4x_reg(trcpidr1, TRCPIDR1); > -coresight_etm4x_reg(trcpidr2, TRCPIDR2); > -coresight_etm4x_reg(trcpidr3, TRCPIDR3); > +coresight_etm4x_cross_read(trcpdcr, TRCPDCR); > +coresight_etm4x_cross_read(trcpdsr, TRCPDSR); > +coresight_etm4x_cross_read(trclsr, TRCLSR); > +coresight_etm4x_cross_read(trcauthstatus, TRCAUTHSTATUS); > +coresight_etm4x_cross_read(trcdevid, TRCDEVID); > +coresight_etm4x_cross_read(trcdevtype, TRCDEVTYPE); > +coresight_etm4x_cross_read(trcpidr0, TRCPIDR0); > +coresight_etm4x_cross_read(trcpidr1, TRCPIDR1); > +coresight_etm4x_cross_read(trcpidr2, TRCPIDR2); > +coresight_etm4x_cross_read(trcpidr3, TRCPIDR3); > coresight_etm4x_cross_read(trcoslsr, TRCOSLSR); > coresight_etm4x_cross_read(trcconfig, TRCCONFIGR); > coresight_etm4x_cross_read(trctraceid, TRCTRACEIDR); > -- > 2.24.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel