From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D47BC433E0 for ; Thu, 30 Jul 2020 13:01:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 482D620842 for ; Thu, 30 Jul 2020 13:01:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nRKr9Vyp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jul0GeYc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 482D620842 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tvlinWPsRjI4nJtN5jbZXcbRiQBMhrRL4rB696cprew=; b=nRKr9VypX0/tdDPYH3zxluR0b Oujj2FVVSYpSrsejhhWAmFlarKZT3U3xAPbxxkAfhENFeO7M/A/nPYhIxTzRqu2sexAGs++0/az4l BiQjRGVojbf31sS1ktixJCODGNGh03EXxFD93ogMmIzlWCoNFz3uAV66LQh0/tkkBqWNCfGWW0G40 KESMKsbfIXtJ70jy553HpxerSYeNYNto+T5GqzdA2u/17CDMzCCV4hS5r0YoL2cdDoWSRVB93exh7 vNbJBPvChhFO0/xHEATZVq40d59tDx75A45Ylu2ytr2vmTYewHeDiEFGw3hACYUeyEAQDK702DCvH bLJcnLh4Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k18AM-0007wp-9M; Thu, 30 Jul 2020 13:00:10 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k18AI-0007vY-MG for linux-arm-kernel@lists.infradead.org; Thu, 30 Jul 2020 13:00:07 +0000 Received: by mail-pl1-x641.google.com with SMTP id u10so4547091plr.7 for ; Thu, 30 Jul 2020 06:00:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fwFyMOazKKiYzOl4gTWFUgJME/fvexSQw+gleCBjVCQ=; b=Jul0GeYcWOTtedHn0n+65O4obMnCkCJmwB7ba/iE8q423Xc9LUXKyRQeZ1a/GDCcXD VURadFwqX0wIDTd5htC23tikixUe/cwhPmGxhEAoKuaqN7SHs0LYSr4XDMD0tJKc+KVL rAJcgPAQqJmLIK2dW0SHZS1DFOoLHQ6HjfkhSjkf7SCUUzX2L1/t5ubpsla6GlsElx90 r80AUL1V9q42J7fqR+unLwVNcDS9rRKrjJtrZqGb3edJrNz3ySpd2Fs3A0cI6p+AO5Nd 1TTo/4xK/pG/qPT1/+tIOCbvE80zd9DeebkgFyi2nRNXfrMmCsNkHp2CeMalTTgVPSD7 CGJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fwFyMOazKKiYzOl4gTWFUgJME/fvexSQw+gleCBjVCQ=; b=XS4dW9b8W4MXzsO7U+xlRVg2DUGXLNp7UVu6bo8CYHrJK3FwB+mX/hElURN6tLXpqH MUyrsNbm8sxfW0kwl4+FEsC5pKNJuM9UuGcGd3dcj51bWCQY1m15siS5JgKd7UARiycV 3KNkVuqUWfxN8sQtXDVcWPOm1ymXRobIVHaX7hCmW35XDL1pnzqo3nWUsQCT8Y+NYAOi UWLf7C6kb3W268bNNlEAYDeDSBBl6roDF45/LXphSXR6bp7wNRX+fwNfn57mTTo+c78a NUb/c27T44c9oRo2argxQT9bBgeyeVcIpT6wYNIto8kqz20DQxm/cAuZpVl7Q8xjDrPv ZMhg== X-Gm-Message-State: AOAM532k6+s/wyXZQdmS6KqhZNya4X17sZ7dH4GI1HQUMmp2wttmqr3X uaVXnbUu8JCErA3OTAlbakY= X-Google-Smtp-Source: ABdhPJyuefbwDvMhZKXxCqSv0gsmfFOOhdLXVfl1m4Bkpw7ImrhKA08NUgsI1dyUUkS/fFijfU7mZA== X-Received: by 2002:a17:902:b403:: with SMTP id x3mr7825079plr.250.1596114004975; Thu, 30 Jul 2020 06:00:04 -0700 (PDT) Received: from localhost ([103.29.143.67]) by smtp.gmail.com with ESMTPSA id g8sm6149026pgr.70.2020.07.30.06.00.02 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Jul 2020 06:00:04 -0700 (PDT) Date: Thu, 30 Jul 2020 21:00:05 +0800 From: Yue Hu To: Catalin Marinas Subject: Re: [PATCH] arm64: mm: add message to die() in die_kernel_fault() Message-ID: <20200730210005.000069a0.zbestahu@gmail.com> In-Reply-To: <20200730122723.GN25149@gaia> References: <20200730114757.13592-1-zbestahu@gmail.com> <20200730122723.GN25149@gaia> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200730_090006_876539_2538B49E X-CRM114-Status: GOOD ( 20.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, linux-kernel@vger.kernel.org, peterx@redhat.com, zbestahu@163.com, huyue2@yulong.com, james.morse@arm.com, akpm@linux-foundation.org, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 30 Jul 2020 13:27:23 +0100 Catalin Marinas wrote: > On Thu, Jul 30, 2020 at 07:47:57PM +0800, Yue Hu wrote: > > From: Yue Hu > > > > Just to identify the kernel fault more clearly. > > > > Signed-off-by: Yue Hu > > --- > > arch/arm64/mm/fault.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c > > index 8afb238..3a753c7 100644 > > --- a/arch/arm64/mm/fault.c > > +++ b/arch/arm64/mm/fault.c > > @@ -289,7 +289,7 @@ static void die_kernel_fault(const char *msg, unsigned long addr, > > mem_abort_decode(esr); > > > > show_pte(addr); > > - die("Oops", regs, esr); > > + die("Oops - Page fault", regs, esr); > > bust_spinlocks(0); > > do_exit(SIGKILL); > > } > > Don't we already print enough information prior to die()? > Yes, we have. But "Oops" is a little common. Add specific message is just to avoid to use it repeatedly by other callers just like die("Oops - BUG",,), die("Oops - KASAN",,). Moreover, die() will call panic() if require, panic() does not know which oops it is. We can let panic() know it for debug expansibility such as store the panic message to reserved memory. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel