From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EB65C433DF for ; Fri, 31 Jul 2020 06:52:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C559207F5 for ; Fri, 31 Jul 2020 06:52:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uWcDEJZE"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="0Q3ICI1V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C559207F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qf2GPBwxW5dmxpQYzd2z7Sma4Sy+rSPUUMqI+tgCV5s=; b=uWcDEJZEMTPndpLNSH1RXunyj h9Jek3ZO6Gl5RkDoyf1y6e0fh5xp/rnKyjk2O/LLv2DBvl/IBzOP1NUm6y417GHkHgc35ZXO85TnG RhhB06ed0rKyXsHPb6BlMsQ+LmAC5qKcPVCLl1xvtb44tPFcMUM009HRJdB2mCGTgKrfz23Ied5sC KWv6EmBBhQf8NO5rv/KkqqmJ6P0Et5vTW/FM55hB5V1O7xvFb74uEkzp2BBKypwz5C0I9l7J2Rahs eCzmplXsRHpwh2mzALNu+0BdaERltphWv0vldV/KKsxXbTvcewxrFz3nslozPhZsJTNlKFwimxJe+ EO+ASxuFA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1Ork-0006rD-UM; Fri, 31 Jul 2020 06:50:04 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1OrB-0006X1-5r for linux-arm-kernel@lists.infradead.org; Fri, 31 Jul 2020 06:49:31 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1AAE620829; Fri, 31 Jul 2020 06:49:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596178167; bh=xPd3z35wKS3rDjjx7Vmt9THjpc672VJ9ztW3nUpT64Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0Q3ICI1V39uoTR2bahOLTiWRuZyStsuQCSxAxlu3tuLNDDdxXkZye4aTApfmI09oP mHeFkactbMxsGxOovfmNKBOEAIKsfLtXqMC8MYm5S6d+4VpFoyQ4kKVEHJXVQtgTz7 tfmLFxdi77Lk/PFCuX5bsTfFP/eQ6cIbQf7fE7HU= Date: Fri, 31 Jul 2020 08:49:15 +0200 From: Greg KH To: Catalin Marinas Subject: Re: [PATCH] arm64/alternatives: move length validation inside the subsection Message-ID: <20200731064915.GI1508201@kroah.com> References: <20200729215152.662225-1-samitolvanen@google.com> <20200730122201.GM25149@gaia> <20200730152330.GA3128@gaia> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200730152330.GA3128@gaia> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200731_024929_949017_5B34E486 X-CRM114-Status: GOOD ( 22.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kees Cook , Nick Desaulniers , LKML , stable@vger.kernel.org, clang-built-linux , Sami Tolvanen , Will Deacon , Ard Biesheuvel , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 30, 2020 at 04:23:31PM +0100, Catalin Marinas wrote: > On Thu, Jul 30, 2020 at 08:13:05AM -0700, Sami Tolvanen wrote: > > On Thu, Jul 30, 2020 at 5:22 AM Catalin Marinas wrote: > > > > > > On Wed, Jul 29, 2020 at 02:51:52PM -0700, Sami Tolvanen wrote: > > > > Commit f7b93d42945c ("arm64/alternatives: use subsections for replacement > > > > sequences") breaks LLVM's integrated assembler, because due to its > > > > one-pass design, it cannot compute instruction sequence lengths before the > > > > layout for the subsection has been finalized. This change fixes the build > > > > by moving the .org directives inside the subsection, so they are processed > > > > after the subsection layout is known. > > > > > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/1078 > > > > Cc: # 4.14+ > > > > > > Commit f7b93d42945c went in 5.8-rc4. Why is this cc stable from 4.14? If > > > Will picks it up for 5.8, it doesn't even need a cc stable. > > > > Greg or Sasha can probably answer why, but this patch is in 4.14.189, > > 4.19.134, 5.4.53, and 5.7.10, which ended up breaking some downstream > > Android kernel builds. > > I see but I don't think we need the explicit cc stable for 4.14. That's > why the Fixes tag is important. If a patch was back-ported, the > subsequent fixes should be picked by the stable maintainers as well. If you know it ahead of time, the explict "# kernel.version" hint is always nice to have as it ensures I will try to backport it that far, and if I have problems, I will ask for help. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel