From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED0D0C433DF for ; Fri, 31 Jul 2020 08:16:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B915520829 for ; Fri, 31 Jul 2020 08:16:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lRn9ezNG"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="K+lwN1PP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B915520829 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9x5SmmOiIZX5PZX3X8aZW904PsuvlHd19SniPKqmlnI=; b=lRn9ezNGN+A9Az5S/KQ4KmQV9 O4R4HFTzOJJukABs/FTjILeIylr7eufEB99wJJ2tjSdh+uCPlBJVjJZLutVGobnXLW2EPaRr6Hm61 t7cQFONZjHaSKN5phGXh7eaBeLw+dsLkeEGfu0HlKfNShrUcBWfA/Mhp1Pxv/3cG7whKlVfyjWlUq rFSLWvd0QvfYlysU8M3HMjkatL5a16/RHse9mQtsfEE6gR4yGmQR8YR6EAGLEW/hfU1Fjd+Tjg9xd fvFU/srYwj1inXyCKtLILvSx3ngwXVCZlQaiynJ8vsFwTArBXhk7LUFk7D/gMN3MvU39DCoV+EQcd j2mX298Kg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1QBi-0001Gc-0q; Fri, 31 Jul 2020 08:14:46 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1QBf-0001FS-11 for linux-arm-kernel@lists.infradead.org; Fri, 31 Jul 2020 08:14:43 +0000 Received: by mail-wm1-x344.google.com with SMTP id t14so3229893wmi.3 for ; Fri, 31 Jul 2020 01:14:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=mqLvWnowlqi0F/JYgNm/w51Gd43hH6qdoKqkY6IFrjw=; b=K+lwN1PP9W4hQIO0DXoR2KOy/67nyhrV5ZmU+SUAtkBHlIUygAj8XyBlvonjFYzDIj qq6fWw3/skMxtuILAV7HdWMaVF3LmQTrQRZl7xM3GsEFXGOX/xjQkpuSuGQFPegoRHa9 /WGLcOWT3p6JNTIGJGWbQlnZ8n63V3B9Btnkb2aqDD2WvxsIHYHsX5PK/lFWdT4tVYMJ JTflK7f2yfdPTzDQuxKBM1IfIzVOjmCZh+MepfUV/cYVINX9R2cJHLHkFjQQfNec5qEw XTuKtYFmPSq1AXrB3/+3rqSkqpPRW2QMy5UVTUQ8SOpAwySfdx4G5ECWfHOGl7gzmWwD vBWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mqLvWnowlqi0F/JYgNm/w51Gd43hH6qdoKqkY6IFrjw=; b=s9N1E+6OPiy5gGNZZdvynOU8cGpF0PgttUwVBS+I+g4Ebt1SvQ+pb5v3h+Aw22yM+X 29HOkFXj/9jvN4UhExFGFNtUAGuklgC41arhtbdzPyGWv2K0qPeF9J9jUpVyrd29yoLN of/Eq6FjmAYz/3BpMLtUsCB5rf7GogkV+xEEsHrCfQhlewEpUBYOWPfdVrE2UrwmrP7z Ij6bpGNGEQHjr8NFdYW7+MX2MOE1UIhzZFF8TWqk2sFwEXkMmNkiFk4JFD7cXTf+n5RB 7YPFSWkR+IRequx6A+tLEJYZAIH81xMB4jaNB8y5PIRQg3+d77g5Xm/Jz5bz03sEPSso pzjw== X-Gm-Message-State: AOAM533wRfvj0aMbbTwcJgh8QUkWtfhF8/8/sW3YlZWnrbh3W71zfTyG 8haZCGYzF1D5qvImLLC9UqD8vw== X-Google-Smtp-Source: ABdhPJwWsIcLz8f6wgdN4NG7SpBXgChRXZTUblxm4WrA7tYJ6CZPPhsc7ExK18PUUgqMc9n8r5mFmw== X-Received: by 2002:a05:600c:230e:: with SMTP id 14mr2661570wmo.3.1596183280121; Fri, 31 Jul 2020 01:14:40 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:f693:9fff:fef4:a7ef]) by smtp.gmail.com with ESMTPSA id 12sm2001488wme.22.2020.07.31.01.14.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2020 01:14:39 -0700 (PDT) Date: Fri, 31 Jul 2020 09:14:36 +0100 From: Quentin Perret To: Will Deacon Subject: Re: [PATCH 02/20] KVM: arm64: Add support for creating kernel-agnostic stage-1 page tables Message-ID: <20200731081436.GA3201636@google.com> References: <20200730153406.25136-1-will@kernel.org> <20200730153406.25136-3-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200730153406.25136-3-will@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200731_041443_146243_ED228487 X-CRM114-Status: GOOD ( 14.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Suzuki Poulose , Marc Zyngier , James Morse , Catalin Marinas , kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey Will, On Thursday 30 Jul 2020 at 16:33:48 (+0100), Will Deacon wrote: > +void *kvm_pgtable_hyp_alloc_cookie(u32 va_bits) > +{ > + struct kvm_pgtable *pgt = kzalloc(sizeof(*pgt), GFP_KERNEL); > + > + if (!pgt) > + return NULL; > + > + pgt->ia_bits = va_bits; > + pgt->start_level = kvm_start_level(va_bits); > + > + pgt->pgd = (kvm_pte_t *)get_zeroed_page(GFP_KERNEL); > + if (!pgt->pgd) { > + kfree(pgt); > + pgt = NULL; > + } > + > + return pgt; > +} > + > +static int hyp_free_walker(u64 addr, u64 end, u32 level, kvm_pte_t *ptep, > + enum kvm_pgtable_walk_flags flag, void * const arg) > +{ > + free_page((unsigned long)kvm_pte_follow(*ptep)); > + return 0; > +} > + > +void kvm_pgtable_hyp_free_cookie(void *cookie) > +{ > + size_t pgd_sz; > + struct kvm_pgtable *pgt = cookie; > + struct kvm_pgtable_walker walker = { > + .cb = hyp_free_walker, > + .flags = KVM_PGTABLE_WALK_TABLE_POST, > + }; > + > + if (kvm_pgtable_walk(cookie, 0, BIT(pgt->ia_bits), &walker)) > + kvm_err("Failed to free page-table pages\n"); > + > + pgd_sz = kvm_pgd_pages(pgt) * PAGE_SIZE; > + free_pages_exact(pgt->pgd, pgd_sz); Given that the pgd is unconditionally a single page for the stage 1 case (as per kvm_pgtable_hyp_alloc_cookie() above), should we simplify this to a simple free_page()? Or did you want to factorize this with the stage 2 free path? > + kfree(pgt); > +} Cheers, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel