From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59E39C433DF for ; Fri, 31 Jul 2020 08:37:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 24E5B207F5 for ; Fri, 31 Jul 2020 08:37:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="azXr/aZS"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="k0JNm5l+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 24E5B207F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wQifDFdg47ahss3S2tWN5ybX91fonjCnqnbiumElLCc=; b=azXr/aZSFp0THlxXqLQAvk1+x oyjr1HoMo0neTchgGyIvNa2j19fucKr267B5gw+RuATUUSWCbmLqgvc6jOnomx9yrUYLBwsrSNuMr ZU3Df0ze1ZQ2LgPJTcvjsAKGQ55xmxZfTcRLikvbtZBJ6O92OTnlwCEoetGdFYKYGmFgpGBlW/CNT xhdk8mCaOxvXgCYj8pV5kHZiUH6mJa9rz3Q+eEGj6MjgycrQKY9JuXgpz5VF7mfHyTzhwqlnfZ+Lm 2ETcFCmbp32MpaHdMHpNY/f74pjl3cJvGbgxhFtGQ5Uyd5Hz87iOQ9E58cEJxqacaPXHvDeSkTwhe bG5mYHvDA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1QWT-0007Nl-Vn; Fri, 31 Jul 2020 08:36:14 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1QWR-0007MR-Fp for linux-arm-kernel@lists.infradead.org; Fri, 31 Jul 2020 08:36:12 +0000 Received: by mail-wm1-x344.google.com with SMTP id p14so7881130wmg.1 for ; Fri, 31 Jul 2020 01:36:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1i12+x9sAajBXVkYs2kk3lSatTN+twSEPgSSI9Cw0jU=; b=k0JNm5l+BC/f3BEyvIRbZVT4kgSe2xXD0n33/nT65AxJzgXp1/v43uJ/SFHgjjg7mO CFFlfaJQNhOPWQc1fzDe/SwbancbzxgFcCX/LF2hitT3+QJ8Svmt9R8brUz6zey6cBZw PttTj6oVWrcPmwz9MLNJPNR+ZY/wY5mM4g14Ymn73hC5NjOHHyabTXl3vDimu78aFanl qiQyhB2r0buGj7ik3LNoTkYxZz7jl9JuVOA6b6jn/k9PH1PSSBcbDQwzj+SxS1tSMhHM RBfn4I0tRz215O1WRT32p/yF1hXL0twb6mX9UffHAH741kFIbBVPsa7mIFTBJ5dhyukE UpqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1i12+x9sAajBXVkYs2kk3lSatTN+twSEPgSSI9Cw0jU=; b=hqTQeZxHRi9O6tkrIVEHQuvgBgIjha2EL0b7WwyLT04V2shYUe0YRLu5iBWtcr3Swz Nn/iBni8MdxtDdzOz9v/eNQaf7KfbQDHDZVgyYSmhA7Eo2bsNQFW4lGFYspWOXdN/fAi hA9PX9klpaWIUkB7nlvWj1piF8OdE81bHAAqK3Y/sDbX5TZlLgXJDW2VIq71aQVbjTSG TqKD+Hc4wrC25N7E+3fmte+pGynDae87JwX+A0IqWbHENXAhJc+98K122ILOZYkt1IJ1 jMIDmbk8Jn1pL2P0RWfDj0FGAE+j1K4NBZT0iX54RqvDOOQ5HI1tBHlGqw8Y+HXfyXlw iYdA== X-Gm-Message-State: AOAM5301Q/eYU/vRck/+HnQg0brAxC+k4MpaVMYOojS/vhhblP9/DMks mzQFFrn8ucu0NSwb1TGKNfvcuA== X-Google-Smtp-Source: ABdhPJxAfdB+rX+zmqNuwo0EkTqS+dEqxJvUq8wuo1WYJcB9nd/M5N0dst+qSxkjPDhJrDsaMnNhug== X-Received: by 2002:a1c:c90d:: with SMTP id f13mr2948544wmb.107.1596184570558; Fri, 31 Jul 2020 01:36:10 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:f693:9fff:fef4:a7ef]) by smtp.gmail.com with ESMTPSA id x11sm11139507wmc.33.2020.07.31.01.36.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2020 01:36:10 -0700 (PDT) Date: Fri, 31 Jul 2020 09:36:06 +0100 From: Quentin Perret To: Will Deacon Subject: Re: [PATCH 02/20] KVM: arm64: Add support for creating kernel-agnostic stage-1 page tables Message-ID: <20200731083606.GA3213389@google.com> References: <20200730153406.25136-1-will@kernel.org> <20200730153406.25136-3-will@kernel.org> <20200731081436.GA3201636@google.com> <20200731081911.GB3201636@google.com> <20200731082208.GA26291@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200731082208.GA26291@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200731_043611_598013_84362AFC X-CRM114-Status: GOOD ( 14.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Suzuki Poulose , Marc Zyngier , James Morse , Catalin Marinas , kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Friday 31 Jul 2020 at 09:22:15 (+0100), Will Deacon wrote: > No, I think you're right. The hyp stage-1 PGD is always a single page, so I > can simplify the free() path. OK, cool. The current code does support concatenated pgds for the hyp stage 1, which is what confused me. Would you mind adding something to the commit message explaining why this is no longer needed or something? Or at least mention it here so I understand :) ? > At one point, I had a common free() path for > stage-1 and stage-2, but that didn't last very long, as the stage-2 > page-table pages are refcounted so you end up having to deal with them > differently anyway. Right, though refcounting the pages for stage 1 might be a good idea too. The current code does it, and I think we'll need it later on for the Protected KVM stuff as unmap() will be needed for stage 1 as well. I'm fine if this is done in a separate series, though. I don't think we need any of that just yet, so we can definitely start 'simple'. Cheers, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel