Re: [PATCH v2 1/9] mfd: mt6360: Rearrange include file

Lee Jones
2020-07-28T06:57:56Z

On Tue, 28 Jul 2020, Gene Chen wrote:

> Lee Jones <lee.jones@linaro.org> 於 2020年7月27日 週一 下午7:08寫道：
> >
> > On Fri, 17 Jul 2020, Gene Chen wrote:
> >
> > > From: Gene Chen <gene_chen@richtek.com>
> > >
> > > Rearrange include file without sorting by alphabet.
> >
> > Why are you making this change?
> >
>
> Personal coding style references from upstream code.
> I can discard this change if it doesn't make sense.

That is really wrong.

This is upstream code. You should abide by the coding style.

Include files should be arranged alphabetically, not arbitrarily.

> > > Signed-off-by: Gene Chen <gene_chen@richtek.com>
> > > ---
> > > drivers/mfd/mt6360-core.c | 11 +++++------
> > > 1 file changed, 5 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/drivers/mfd/mt6360-core.c b/drivers/mfd/mt6360-core.c
> > > index e9cacc2..df4506f 100644
> > > --- a/drivers/mfd/mt6360-core.c
> > > +++ b/drivers/mfd/mt6360-core.c
> > > @@ -5,15 +5,14 @@
> > > * Author: Gene Chen <gene_chen@richtek.com>
> > > */
> > >
> > > +#include <linux/kernel.h>
> > > +#include <linux/module.h>
> > > #include <linux/i2c.h>
> > > -#include <linux/init.h>
> > > +#include <linux/crc8.h>
> > > +#include <linux/slab.h>
> > > +#include <linux/regmap.h>
> > > #include <linux/interrupt.h>
> > > -#include <linux/kernel.h>
> > > #include <linux/mfd/core.h>
> > > -#include <linux/module.h>
> > > -#include <linux/of_irq.h>
> > > -#include <linux/of_platform.h>
> > > -#include <linux/version.h>
> > >
> > > #include <linux/mfd/mt6360.h>
> > >
> >

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog