Re: [PATCH v2 2/7] cpufreq: set invariance scale factor on transition end

Ionela Voinescu
2020-07-29T09:15:35Z

On Monday 27 Jul 2020 at 15:52:41 (+0200), Rafael J. Wysocki wrote:
> On Wed, Jul 22, 2020 at 11:38 AM Ionela Voinescu
> <ionela.voinescu@arm.com> wrote:
> >
> > While the move of the invariance setter calls (arch_set_freq_scale())
> > from cpufreq drivers to cpufreq core maintained the previous
> > functionality for existing drivers that use target_index() and
> > fast_switch() for frequency switching, it also gives the possibility
> > of adding support for users of the target() callback, which is exploited
> > here.
> >
> > To be noted that the target() callback has been flagged as deprecated
> > since:
> >
> > commit 9c0ebcf78fde ("cpufreq: Implement light weight ->target_index() routine")
> >
> > It also doesn't have that many users:
> >
> > cpufreq-nforce2.c:371:2: .target = nforce2_target,
> > cppc_cpufreq.c:416:2: .target = cppc_cpufreq_set_target,
> > gx-suspmod.c:439:2: .target = cpufreq_gx_target,
> > pcc-cpufreq.c:573:2: .target = pcc_cpufreq_target,
> >
> > Similarly to the path taken for target_index() calls in the cpufreq core
> > during a frequency change, all of the drivers above will mark the end of a
> > frequency change by a call to cpufreq_freq_transition_end().
> >
> > Therefore, cpufreq_freq_transition_end() can be used as the location for
> > the arch_set_freq_scale() call to potentially inform the scheduler of the
> > frequency change.
> >
> > This change maintains the previous functionality for the drivers that
> > implement the target_index() callback, while also adding support for the
> > few drivers that implement the deprecated target() callback.
> >
> > Two notes are worthwhile here:
> > - In __target_index(), cpufreq_freq_transition_end() is called only for
> > drivers that have synchronous notifications enabled. There is only one
> > driver that disables them,
> >
> > drivers/cpufreq/powernow-k8.c:1142: .flags = CPUFREQ_ASYNC_NOTIFICATION,
> >
> > which is deprecated.
> >
> > - Despite marking a successful frequency change, many cpufreq drivers
> > will populate the new policy->cur with the new requested frequency,
> > although this might not be the one granted by the hardware.
> >
> > Therefore, the call to arch_set_freq_scale() is a "best effort" one,
> > and it is up to the architecture if the new frequency is used in the
> > new frequency scale factor setting or eventually used by the scheduler.
> > The architecture is in a better position to decide if it has better
> > methods to obtain more accurate information regarding the current
> > frequency (for example the use of counters).
> >
[..]

> I would fold this patch into the previous one.
>
> I don't see much reason for it to be separate and it looks like
> folding it in would cause the previous patch to be simpler.

I kept it separate in this version as a proposal to move the call to
cpufreq_freq_transition_end() and properly justify it in the commit
message.

I'll squash it into the previous one, as recommended.

Thanks,
Ionela.